THIS STARTED IN MANGOS ONE, BUT IS ACTUALLY A CROSS CORE ISSUE - IF YOU CAN, PLEASE MOVE THIS TO THE CROSS CORE SECTION.
Someone recently sent me a video about an analysis of different issues on private servers regarding the combat calculations, one of those issues was the Glancing Blow.
So I checked back on the information given and the code and saw that there is a problem with the combat calculations regarding the Glancing Blow, which seems to be capped to 40% on TBC and WotLK when it shouldn't.
<Insert Rambling about people spending hours on creating YouTube videos, but 0 time sending a bug report>
So I found the issue on One and Two:
- One: https://github.com/mangosone/server/blob/v22.01.62/src/game/Object/Unit.cpp#L2878
- Two: https://github.com/mangostwo/server/blob/v22.01.77/src/game/Object/Unit.cpp#L3253
There were several discussion in the forums already, which lead to no changes regarding that issue, but with the old sources + NuTBC confirming it we should do so accordingly.
I couldn't find reliable sources for anything past the 25% chance, so I went on to create Pull Requests for anything up to Four. Since the 40% was just copy and paste from the previous version, I'd rather go with the 25% starting from TBC.