Jump to content
  • Incomplete Quest Text is shown for Completed Quests


    brotalnia
    • Main Category: Core / Mangos Daemon
      Sub-Category: Quest
      Version: 22.1
      Related to:

    The text that is supposed to be shown only when the quest is incomplete, is shown for completed quests too. The issue comes from the fact that "RequestItemsText" field is used for two different things. Obviously like its name implies, it is used to hold the text that is displayed when a quest requires certain items, but for quests that don't have an item requirement, it holds the incomplete quest text. That text is not supposed to be shown if the quest is complete, as is obvious from every old retail video.

    An easy to test example is the Cutting Teeth quest in the orc starting zone:

    ezgif-1-3d4a9bc9c4.gif.94004b57416de09e0893bf5b0e36d12b.gif

    https://youtu.be/jTSyexUNN9E?t=5m20s

    You can see that on retail, it goes straight to offering the reward. You should not have to click "continue".

    All that is required to fix this is to add an additional check in PlayerMenu::SendQuestGiverRequestItems to see whether the quest has an item requirement before calling SendQuestGiverOfferReward. If it does not require any items, the text should only be shown when the quest is incomplete. Currently it only checks if there is a RequestItemsText.

    Fix that i submitted to Elysium -> https://github.com/elysium-project/server/pull/1001/files



    User Feedback

    Recommended Comments

    Fixed on latest Revision. Tested and on completed Quest it brought me to the Complete page and not the Incomplete page first like OP has mentioned using same example.

     

     

     

    Share this comment


    Link to comment
    Share on other sites


    Guest
    This is now closed for further comments

Contact Us

To contact us click here
You can also email us at [email protected]

Privacy Policy | Terms & Conditions

Repositories

The Link to the master list
of MaNGOS repositories:
Copyright © getMaNGOS. All rights Reserved.

This website is in no way associated with or endorsed by Blizzard Entertainment®
×