Yesterday i was playing with a Gnome on MaNGOS Zero.
Doing quest 'Beer Basted Boar Ribs' in Kharanos (entry id 384 in quest_template) i've noticed that if you buy the item 'Rhapsody Melt' (entry 2894 in item_template) there is a "Rhapsody Malt: 1/1" message that is shown twice.
After some tries i've found that in code of Player.cpp this message is actually triggered in two location:
- Line 16006 - method SendQuestUpdateAddItem - OpCode: SMSG_QUESTUPDATE_ADD_ITEM
- Line 20175 - method BuyItemFromVendor - OpCode: SMSG_BUY_ITEM
What i have tried is to comment the sendPacket call in BuyItemFromVendor and tested with the following quests:
Quest with entry id 179 and Title 'Dwarven Outfitters' required item with entry id '750' item name 'Tough Wolf Meat'. (this is a collectin quest killing mobs)
Quest with entry id 384 and Title 'Beer Basted Boar Ribs' required item with entry id '2894' item name 'Rhapsody Melt'. (this is a killing quest with 1 item that need to be purchased by the innkeper)
unfortunately i have no experience with OPCODE or client/server workflow.
Not sure if this can be considered a good fix or not or what this comment can involve.
Attached there are screenshot before and after commenting line 20175.