Search the Community
Showing results for tags 'quests'.
Found 2 results
The text that is supposed to be shown only when the quest is incomplete, is shown for completed quests too. The issue comes from the fact that "RequestItemsText" field is used for two different things. Obviously like its name implies, it is used to hold the text that is displayed when a quest requires certain items, but for quests that don't have an item requirement, it holds the incomplete quest text. That text is not supposed to be shown if the quest is complete, as is obvious from every old retail video. An easy to test example is the Cutting Teeth quest in the orc starting zone: https://youtu.be/jTSyexUNN9E?t=5m20s You can see that on retail, it goes straight to offering the reward. You should not have to click "continue". All that is required to fix this is to add an additional check in PlayerMenu::SendQuestGiverRequestItems to see whether the quest has an item requirement before calling SendQuestGiverOfferReward. If it does not require any items, the text should only be shown when the quest is incomplete. Currently it only checks if there is a RequestItemsText. Fix that i submitted to Elysium -> https://github.com/elysium-project/server/pull/1001/files
The structure of the SMSG_QUESTGIVER_QUEST_DETAILS packet is wrong. You can see here that the emotes are not included at all: https://github.com/mangoszero/server/blob/d0a4af096e528533044e7029446d1c5c9e98a16c/src/game/WorldHandlers/GossipDef.cpp#L422 These are the emotes that are played by the quest giver when he offers you a quest. DetailsEmotes do exist in vanilla, so the structure of the packet must be fixed to send the emotes. Some examples: https://youtu.be/jTSyexUNN9E?t=1m21s Kaltunk does a talk emote when offering the quest. https://youtu.be/jTSyexUNN9E?t=27m47s Gar'thok does a yell emote when offering the quest. https://youtu.be/YcEqpVfrE7U?t=42m28s Misha Tor'kren does a cry emote when offering the quest. Here is how SendQuestGiverQuestDetails looks on Elysium, the emotes are fixed there: https://github.com/elysium-project/server/blob/2e0826ef90686e431b8fcc00bac3d445f986ce37/src/game/GossipDef.cpp#L438