Jump to content

[7569][typo] in dot bonus dmg calculation


pasdVn

Recommended Posts

From b813984d37f5ecf1756050a3c6fafdf5db9ca45a Mon Sep 17 00:00:00 2001
From: pasdVn <[email protected]>
Date: Wed, 25 Mar 2009 10:55:04 +0100
Subject: [PATCH] fixed typo in dot bonus damage calculation (for stacks>1)

---
src/game/Unit.cpp |    4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index f151b6f..470de75 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -7698,8 +7698,8 @@ uint32 Unit::SpellDamageBonus(Unit *pVictim, SpellEntry const *spellProto, uint3
                    DotTicks = DotDuration / spellProto->EffectAmplitude[x];
                if(DotTicks)
                {
-                    DoneAdvertisedBenefit /= DotTicks*int32(stack);
-                    TakenAdvertisedBenefit /= DotTicks*int32(stack);
+                    DoneAdvertisedBenefit = DoneAdvertisedBenefit*int32(stack)/DotTicks;
+                    TakenAdvertisedBenefit = TakenAdvertisedBenefit*int32(stack)/DotTicks;
                }
            }
        }
-- 
1.6.0.2.1172.ga5ed0

I think the given calculation is wrong. Would mean that bonus damage decreases if the stack increases. In fact it should get also (e.g.) 3 times the bonus if there are 3 stacks.

Link to comment
Share on other sites

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use