[latest] More or less correct Sacrifice, Consume Shadows (maybe other) autocast fix

[hunuza]

Somebody can confirm whether Last Stand should be really autocastable?

Still I think that if the flag is correct, SpellFamily checks should be unnecessary.

[shadtews]

Would the hunter pet ability "Heart of Phoenix" fall into this catagory? What is supposed to happen is when it is enabled and your pet dies, it will return to life with full health. What happens now is, when it is enabled, it gets triggered even though the pet is full health, and then goes into its cooldown state.

http://www.wowhead.com/?spell=55709

[VladimirMangos]

I think problem must solved lot more simple way: autocast work only in combat. So not autocasted or not spells. Its just don;t must be autocasted non in combat. This alt. way change appliend in [8291]

[hunuza]

I don't think that the problem that this patch addresses was fully solved in [8291].

There are some spells like Sacrifice where you should not be able to enable auto cast at all. Neither in combat nor out of combat.

I don't see how [8291] should fix that issue.

[VladimirMangos]

Ok, i agree, that my commit has been too fast... and move thread also... sorry...

I will partly revert referenced commit to allow some spells authocast out of combat. But this not related explicitly to not autocastable in generla spells mostly..

[pasdVn]

Hmm, I talked to an offi player just now. He said "Last Stand" is definitely not autocastable, but he also was the oppinion, that the most other pet spells with "long" cooldown (talent spells) are not autocastable such as http://www.wowhead.com/?spell=53476 wich also make sense, because you need to choose a spicific friendly target for that spell. But this spell has not got this flag.

If there was a specific flag for autocastable/not autocastable, the client would also check that itslef, I think.

[hunuza]

According to the comments on the page you linked Intervene is autocastable.

[hunuza]

Flag seems to be correct, as Huddle also has it set and should not be autocastable.

[pasdVn]

I had the possibility to check that on an offi server:

• * "Last Stand" is not autocastable
  * "Heard of the Phoenix" is not autocastable
  * nothing to do with this patch, but interesting^^: there are some other spells, that can be set on autocast, but that won't get autocasted. I think they did not define any logic/event when casting them or so (e.g. like "intervene")
  

It also seems, that they implemented a check for this bit in the client version 3.2.0. Those spellbuttons look different than the normal autocastable ones. Anyway I think server side check is a good idea!

[kerbe]

How's this patch holding these days? My experience say that it isn't applied to core, at least not backported to mangos-0.12. Everyone seems to be agreed this far patch is good and doing it's job. Also stated that if there rises new spells which shouldn't be autocastable, they are easily added (those potential hunter spells?)

So some dev have time to check this and see if it is valid for core?

[hunuza]

I am pretty sure that this flag is correct, but it should not only be checked for hunter+warlock pets, but also for e.g. ghouls pets.

I think this flag is also used when a NPC controls a player to decide whether it should use that spell or not.