[8011][Fix] Only send mana gain once

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

This fixes the bug that potions and other such energize effects make the client display twice as much of a gain, sometimes resulting in "not enough mana/energy/rage/etc" because the client thinks it has more than it does.

For which repository revision was the patch created?

7887

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

See posts #8 and 9 here.

Who has been writing this patch? Please include either forum user names or email addresses

Myself

ModifyPower has a call to SetPower, which tells the client to set its mana value to the value the server has after the amount energized is added. When it calls SendEnergizeSpellLog afterward, the client adds the amount energized a second time. Switching calls to ModifyPower and SendEnergizeSpellLog around fixes this problem.

Patch

[Lynx3d]

Just tested using mana potions and life tap with this patch applied to [7894].

No more strange jumping, mana goes up the correct amount and stays there.

No other problems found, but really only killed a few mobs to burn some mana.

Can't believe it was something that simple, i hope this function swapping has no unintended side-effects.

In any case, two thumbs up for finding the problem!

[Roberto Baggio]

yeah, it's looking good

keep the good work up!

[Safiya]

Well done.

[False.Genesis]

tested, works fine. thx a lot.

[hunuza]

Committed in [8011]. Thank you.