Playerbot (archive)

vladex · February 21, 2010

can you be more specific about those errors ??

belfedia · February 21, 2010

Hello

I have try this :

git clone git://github.com/blueboy/mangos.git                                                     // take mangos+playerbot
git checkout -b 8994 fe7a71ed73e7d5d61e5274b0e5334f2929f94c9c                                      // switch to 8994 branch with HASH
svn co [url]https://scriptdev2.svn.sourceforge.net/svnroot/scriptdev2/[/url]  src/bindings/ScriptDev2        // take scriptdev2 SVN
git am [url]https://scriptdev2.svn.sourceforge.net/svnroot/scriptdev2//patches/MaNGOS-*[/url]                // apply MaNGOS-8759-ScriptDev2.patch
autoreconf --install --force
../configure --prefix=/home/mangos/serverbot/ --sysconfdir=/home/mangos/serverbot//etc --enable-cli --enable-ra --datadir=/home/mangos/serverbot/
make -j 2
make install

Not good

In file included from ../../../../src/bindings/ScriptDev2/include/precompiled.h:8,
                from ../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:12:
../../../../src/bindings/ScriptDev2/include/../ScriptMgr.h:57: error: 'SpellEffectIndex' has not been declared
../../../../src/bindings/ScriptDev2/include/../ScriptMgr.h:58: error: 'SpellEffectIndex' has not been declared
../../../../src/bindings/ScriptDev2/include/../ScriptMgr.h:59: error: 'SpellEffectIndex' has not been declared
In file included from ../../../../src/bindings/ScriptDev2/include/precompiled.h:8,
                from ../../../../src/bindings/ScriptDev2/ScriptMgr.cpp:5:
../../../../src/bindings/ScriptDev2/include/../ScriptMgr.h:57: error: 'SpellEffectIndex' has not been declared
../../../../src/bindings/ScriptDev2/include/../ScriptMgr.h:58: error: 'SpellEffectIndex' has not been declared
../../../../src/bindings/ScriptDev2/include/../ScriptMgr.h:59: error: 'SpellEffectIndex' has not been declared
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp: In member function 'virtual void npc_escortAI::EnterEvadeMode()':
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:195: error: 'CHASE_MOTION_TYPE' was not declared in this scope
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:206: error: 'CHASE_MOTION_TYPE' was not declared in this scope
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp: In member function 'virtual void npc_escortAI::MovementInform(uint32, uint32)':
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:337: error: 'class Creature' has no member named 'HasSplineFlag'
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:337: error: 'SPLINEFLAG_WALKMODE' was not declared in this scope
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:338: error: 'class Creature' has no member named 'RemoveSplineFlag'
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:339: error: 'class Creature' has no member named 'HasSplineFlag'
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:340: error: 'class Creature' has no member named 'AddSplineFlag'
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp: In member function 'void npc_escortAI::SetRun(bool)':
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:402: error: 'class Creature' has no member named 'RemoveSplineFlag'
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:402: error: 'SPLINEFLAG_WALKMODE' was not declared in this scope
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:409: error: 'class Creature' has no member named 'AddSplineFlag'
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:409: error: 'SPLINEFLAG_WALKMODE' was not declared in this scope
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp: In member function 'void npc_escortAI::Start(bool, bool, uint64, const Quest*, bool, bool)':
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:471: error: 'class Creature' has no member named 'RemoveSplineFlag'
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:471: error: 'SPLINEFLAG_WALKMODE' was not declared in this scope
make[6]: *** [escort_ai.lo] Erreur 1

I will try next clue with your 8965 patch !

blueboy · February 21, 2010

Hello

I have try this :

git clone git://github.com/blueboy/mangos.git                                                     // take mangos+playerbot
git checkout -b 8994 fe7a71ed73e7d5d61e5274b0e5334f2929f94c9c                                      // switch to 8994 branch with HASH
svn co [url]https://scriptdev2.svn.sourceforge.net/svnroot/scriptdev2/[/url]  src/bindings/ScriptDev2        // take scriptdev2 SVN
git am [url]https://scriptdev2.svn.sourceforge.net/svnroot/scriptdev2//patches/MaNGOS-*[/url]                // apply MaNGOS-8759-ScriptDev2.patch
autoreconf --install --force
../configure --prefix=/home/mangos/serverbot/ --sysconfdir=/home/mangos/serverbot//etc --enable-cli --enable-ra --datadir=/home/mangos/serverbot/
make -j 2
make install

Not good

In file included from ../../../../src/bindings/ScriptDev2/include/precompiled.h:8,
                from ../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:12:
../../../../src/bindings/ScriptDev2/include/../ScriptMgr.h:57: error: 'SpellEffectIndex' has not been declared
../../../../src/bindings/ScriptDev2/include/../ScriptMgr.h:58: error: 'SpellEffectIndex' has not been declared
../../../../src/bindings/ScriptDev2/include/../ScriptMgr.h:59: error: 'SpellEffectIndex' has not been declared
In file included from ../../../../src/bindings/ScriptDev2/include/precompiled.h:8,
                from ../../../../src/bindings/ScriptDev2/ScriptMgr.cpp:5:
../../../../src/bindings/ScriptDev2/include/../ScriptMgr.h:57: error: 'SpellEffectIndex' has not been declared
../../../../src/bindings/ScriptDev2/include/../ScriptMgr.h:58: error: 'SpellEffectIndex' has not been declared
../../../../src/bindings/ScriptDev2/include/../ScriptMgr.h:59: error: 'SpellEffectIndex' has not been declared
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp: In member function 'virtual void npc_escortAI::EnterEvadeMode()':
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:195: error: 'CHASE_MOTION_TYPE' was not declared in this scope
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:206: error: 'CHASE_MOTION_TYPE' was not declared in this scope
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp: In member function 'virtual void npc_escortAI::MovementInform(uint32, uint32)':
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:337: error: 'class Creature' has no member named 'HasSplineFlag'
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:337: error: 'SPLINEFLAG_WALKMODE' was not declared in this scope
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:338: error: 'class Creature' has no member named 'RemoveSplineFlag'
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:339: error: 'class Creature' has no member named 'HasSplineFlag'
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:340: error: 'class Creature' has no member named 'AddSplineFlag'
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp: In member function 'void npc_escortAI::SetRun(bool)':
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:402: error: 'class Creature' has no member named 'RemoveSplineFlag'
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:402: error: 'SPLINEFLAG_WALKMODE' was not declared in this scope
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:409: error: 'class Creature' has no member named 'AddSplineFlag'
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:409: error: 'SPLINEFLAG_WALKMODE' was not declared in this scope
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp: In member function 'void npc_escortAI::Start(bool, bool, uint64, const Quest*, bool, bool)':
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:471: error: 'class Creature' has no member named 'RemoveSplineFlag'
../../../../src/bindings/ScriptDev2/base/escort_ai.cpp:471: error: 'SPLINEFLAG_WALKMODE' was not declared in this scope
make[6]: *** [escort_ai.lo] Erreur 1

I will try next clue with your 8965 patch !

The 'SpellEffectIndex' & SPLINEFLAG errors are caused only in recent changes made on the MaNGOS branch. Are you sure your using MaNGOS[8994] and an earlier version of ScriptDev2, say ~ [1513]. The latest Scriptdev2 will not work with MaNGOS

[8994].

Edit: use this bash script I created, and specify the version of scriptdev2, as a command line parameter

#!/bin/bash

unset VERSION
unset DEST

VERSION=$1
DEST="/home/mangos/compile/mangos/src/bindings/ScriptDev2"
if [ -z "${VERSION}" ]; then
echo "No ScriptDev2 VERSION specified, assume latest VERSION";
else
VERSION="-r "${VERSION};
fi

if [ -d "${DEST}" ]; then
rm -R ${DEST};
fi

mkdir ${DEST};
svn co [url]https://scriptdev2.svn.sourceforge.net/svnroot/scriptdev2/[/url] ${DEST} ${VERSION}

Hope this helps

belfedia · February 21, 2010

The 'SpellEffectIndex' & SPLINEFLAG errors are caused only in recent changes made on the MaNGOS branch. Are you sure your using MaNGOS[8994] and an earlier version of ScriptDev2, say ~ [1513]. The latest Scriptdev2 will not work with MaNGOS
[8994].

Hope this helps

My real script for compil Mangos [8994] without playerbot is

git clone git://github.com/mangos/mangos.git                                                      // take mangos
git reset --hard [8994]                                                                         // make 8994 master
svn co [url]https://scriptdev2.svn.sourceforge.net/svnroot/scriptdev2/[/url]  src/bindings/ScriptDev2        // take scriptdev2 SVN
git am [url]https://scriptdev2.svn.sourceforge.net/svnroot/scriptdev2//patches/MaNGOS-*[/url]                // apply MaNGOS-8759-ScriptDev2.patch
autoreconf --install --force
../configure --prefix=/home/mangos/serverbot/ --sysconfdir=/home/mangos/serverbot//etc --enable-cli --enable-ra --datadir=/home/mangos/serverbot/
make -j 2
make install

If i use git checkout -b 8994 fe7a71ed73e7d5d61e5274b0e5334f2929f94c9c

i'm on a new branch 8994 but scriptdev2 don't work !

I must use git reset --hard [8994] and i have a fully [8994] working

With playerbot:

git reset --hard [8994] don't work on git://github.com/blueboy/mangos.git, just working on git://github.com/mangos/mangos.git

Note: read my code , i use 8759-scriptdev2 patch

blueboy · February 21, 2010

My real script for compil Mangos [8994] without playerbot is
git clone git://github.com/mangos/mangos.git                                                      // take mangos
git reset --hard [8994]                                                                         // make 8994 master
svn co [url]https://scriptdev2.svn.sourceforge.net/svnroot/scriptdev2/[/url]  src/bindings/ScriptDev2        // take scriptdev2 SVN
git am [url]https://scriptdev2.svn.sourceforge.net/svnroot/scriptdev2//patches/MaNGOS-*[/url]                // apply MaNGOS-8759-ScriptDev2.patch
autoreconf --install --force
../configure --prefix=/home/mangos/serverbot/ --sysconfdir=/home/mangos/serverbot//etc --enable-cli --enable-ra --datadir=/home/mangos/serverbot/
make -j 2
make install
If i use git checkout -b 8994 fe7a71ed73e7d5d61e5274b0e5334f2929f94c9c

i'm on a new branch 8994 but scriptdev2 don't work !

I must use git reset --hard [8994] and i have a fully [8994] working

With playerbot:

git reset --hard [8994] don't work on git://github.com/blueboy/mangos.git, just working on git://github.com/mangos/mangos.git

Note: read my code , i use 8759-scriptdev2 patch

Are you sure your using Scriptdev2 [1513]. The patch '8759-scriptdev2 patch' is used to bind Scripdev2 code to MaNGOS code so they compile together.

Edit: '8759-scriptdev2 patch' has been used with every release of Scriptdev2 since MaNGOS [8759].

Sorry typo with Scriptdev version above, :rolleyes: Scriptdev2 is currently @ [1587]

Hope this helps

belfedia · February 21, 2010

You say last scriptdev2 patch don't work with mangos [8994]

My server is ok, mobs move on it, i supose i have correct scriptdev2 version

But if i use git checkout -b 8994 fe7a71ed73e7d5d61e5274b0e5334f2929f94c9c in place of git reset --hard [8994]

I don't have right scriptdev2 version and can't compil it !

Why i can't use git reset --hard [8994] in blueboy repository ?

blueboy · February 21, 2010

You say last scriptdev2 patch don' work with mangos [8994]
My server is ok, mobs move on it, i supose i have correct scriptdev2 version

But if i use git checkout -b 8994 fe7a71ed73e7d5d61e5274b0e5334f2929f94c9c in place of git reset --hard [8994]

I don't have right scriptdev2 version and can't compil it !

Why i can't use git reset --hard [8994] in blueboy repository ?

The reason it appears to work, is that you insist on using 'git reset --hard' As far as I know this will reset the repo to the HEAD. On blueboy this is currently [9422]. I have never used '[8994]'. The easiest way to check the current version or HEAD of your local repository, is by issuing this command,

I prefer to use 'git checkout' to switch branches than 'git reset --hard'

git log

Then observe the closest MaNGOS commit from the top.

Edit: I think you are confusing patches with commits. As I said, the patch that is provided with Scriptdev2 does not refer to the version of scripdev2 or mangos being used. The 8759 is given to tell that the patch works with all releases of Scriptdev2 after MaNGOS[8759]. It is used for binding, and has nothing to do with script or code versions. The patch I provided does refer to code versions i.e ManGOS [9865].

Hope this helps

belfedia · February 21, 2010

Only one error with your 8965 patch !!!

Hunk #3 FAILED at 321.
1 out of 3 hunks FAILED -- saving rejects to file src/game/NPCHandler.cpp.rej
patching file src/game/Player.cpp

We are close to clue !

blueboy · February 21, 2010

Only one error with your 8965 patch !!!
Hunk #3 FAILED at 321.
1 out of 3 hunks FAILED -- saving rejects to file src/game/NPCHandler.cpp.rej
patching file src/game/Player.cpp
We are close to clue !

O.K this is with MaNGOS[8994]. As I remember this is caused by conflicts with the 'bot giver' code in NPCHandler, and changes they carried out to MaNGOS. We have since removed the 'bot giver' code from playerbot. If you are patient, I'll try to sort it out. I'll get back to you.

belfedia · February 21, 2010

O.K this is with MaNGOS[8994]. As I remember this is caused by conflicts with the 'bot giver' code in NPCHandler, and changes they carried out to MaNGOS. We have since removed the 'bot giver' code from playerbot. If you are patient, I'll try to sort it out. I'll get back to you.

I'm very patient

But you too with newb like me

Many thanks !

Ps: I'm on lenny debian

blueboy · February 21, 2010

I'm very patient
But you too with newb like me

Many thanks !

I hope you don't mind editing code. Open the patch I sent you. Search for NPCHandler.cpp. The error occurs @ line 321

patching file src/game/NPCHandler.cpp                                   
Hunk #3 FAILED at 321.                                                  
1 out of 3 hunks FAILED -- saving rejects to file src/game/NPCHandler.cpp.rej
patching file src/game/Player.cpp

Every patch begins and ends with a three line pattern. If this pattern changes the patch can't be applied, causing the rejection.

If you compare the pattern for patch @ 321 with the code in NPCHandler.cpp you will see it has changed.

Remove the lower pattern

    if (!code.empty())
    {
        if (!Script->GossipSelectWithCode(_player, pCreature, _player->PlayerTalkClass->GossipOptionSender(gossipListId), _player->PlayerTalkClass->GossipOptionAction(gossipListId), code.c_str()))

replace with

     // TODO: determine if scriptCall is needed for GO and also if scriptCall can be same as current, with modified argument WorldObject*

    // can vehicle have gossip? If so, need check for this also.

save the file, and try it. It should work.

I suggest you do not try using the 'bot guy' as this caused alot of problems at the time, which prompted us to remove the code.

Edit: I know these look like four lines of code, but they are three long lines of code that have wrapped.

I hope this helps

blueboy · February 21, 2010

Hi belfedia,

I guess you will find that the compile will stop @

  CXX    NPCHandler.o                                                                                                                                        
../../../src/game/NPCHandler.cpp: In member function â€˜void WorldSession::HandleGossipSelectOptionOpcode(WorldPacket&)â€™:                                      
../../../src/game/NPCHandler.cpp:317: error: â€˜pCreatureâ€™ was not declared in this scope                                                                      
make[3]: *** [NPCHandler.o] Error 1

Oh boy, I thought this was history. The cause of this is simple, they optimized the MaNGOS code and moved the declarartion of 'pCreature' further down the function. This was part of the controversy, I mentioned earlier.

I kept the block of playerbot code (~321) at the top of the function, and added another declaration. Look at post #455, that shows all the 'bot guy' code in one patch. This worked for me, but didn't for other users.

They chose the move the block of playerbot code to a point below the new 'pCreature' declaration. I found that this caused my server to crash when selecting the summoned 'bot guy'.

If you do not use 'bot guy' it is fine. If you do then, you will have issues. We pulled the 'bot guy' code because there was no mutual resolution. Thus the patch, I included in #455 for those who wish to fix it. If we can find a mutaul fix, then maybe it can be re-introduced to the playerbot code. I personally prefer using macros to summon multiple bots.

Hope this helps

blueboy · February 21, 2010

hello guys ive been looking this for long time now the botsai go awesome and i have my server with playerbot and scriptdev2 i compiled as my brain could... works but when i load the mangos server the db get some errors and feel that such errors can be the caused of some problems that have if someone can show me some guide or some guy that compiles the last blue boy mangos playerbot realese and sd2 will be really helpfull thanks anyway and keep it on with the proyect this saves alots of servers and provide alot of fun without players

You need to use a database that is compatible with the MaNGOS/Scriptdev2 code. Many projects that develop databases for MaNGOS, will suggest the appropriate versions. I assume your maps/vmaps/dbc files are O.K, otherwise the database would not load at all. I personally use PSMDB database, and it works fine.

http://svn.assembla.com/svn/psmdb_wotlk/

Look @ 'Supported_Revisions_&_Silvermoon_Contact.txt' for info

Edit: Expect some SD2 Table & RegisterSelf warnings. These are normal, the database is being developed and they can't resolve all issues at once

Hope this helps

gundisalvus · February 21, 2010

Thank you very much blueboy im testing the revision and sorry for no post the errors i think that going to be annoying....the problem comes when i created a item in the wow-v item creator i did it and stats works fine but model and item icon doesnt work and i did alot of items for check what is it and the display id' in my db are the same and the spell in my servers like character spells and items like that works fine but not in the item that i created and i read after doing all this in the wow-v forums and they says that due to poor compilation that the items created by is why doesnt work so i cant say that my server not is the problem because there is this such errors anyway there we go... the errors:

2010-02-21 18:07:48 Item (Entry: 1500) not correct class 4, must be 15 (still using DB value).

2010-02-21 18:07:48 Item (Entry: 1500) not correct 6 material, must be 2 (still using DB value).

2010-02-21 18:07:48 Item (Entry: 1500) not correct 8 inventory type, must be 0 (still using DB value).

2010-02-21 18:07:48 Item (Entry: 1500) not correct 59150 display id, must be 37388 (using it).

2010-02-21 18:07:48 Item (Entry: 1500) has wrong BuyCount value (0), set to default(1).

2010-02-21 18:07:48 Item (Entry: 37314) not correct 49760 display id, must be 65930 (using it).

2010-02-21 18:07:48 Item (Entry: 43383) not correct class 4, must be 16 (still using DB value).

2010-02-21 18:07:48 Item (Entry: 43383) not correct -1 Unk0, must be 0 (still using DB value).

2010-02-21 18:07:48 Item (Entry: 43383) not correct 6 material, must be 4 (still using DB value).

2010-02-21 18:07:48 Item (Entry: 43383) not correct 8 inventory type, must be 0 (still using DB value).

2010-02-21 18:07:48 Item (Entry: 43383) not correct 59150 display id, must be 54596 (using it).

2010-02-21 18:07:48 Item (Entry: 43383) has wrong BuyCount value (0), set to default(1).

2010-02-21 18:07:48 Item (Entry: 50226) not correct class 12, must be 15 (still using DB value).

2010-02-21 18:07:48 Item (Entry: 50226) not correct -1 material, must be 4 (still using DB value).

2010-02-21 18:07:48 Item (Entry: 50231) not correct class 12, must be 15 (still using DB value).

2010-02-21 18:07:48 Item (Entry: 50231) not correct -1 material, must be 4 (still using DB value).

2010-02-21 18:07:48 Item (Entry: 51158) not correct 64894 display id, must be 65647 (using it).

2010-02-21 18:07:48 Item (Entry: 51289) not correct 64828 display id, must be 64840 (using it).

2010-02-21 18:07:50 Table `spell_script_target`: spellId 23359 listed for TargetEntry 5357 does not have any implicit target TARGET_SCRIPT(38) or TARGET_SCRIPT_COORDINATES (46) or TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT (40).

2010-02-21 18:07:50 Table `spell_script_target`: spellId 23359 listed for TargetEntry 5358 does not have any implicit target TARGET_SCRIPT(38) or TARGET_SCRIPT_COORDINATES (46) or TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT (40).

2010-02-21 18:07:50 Table `spell_script_target`: spellId 23359 listed for TargetEntry 5359 does not have any implicit target TARGET_SCRIPT(38) or TARGET_SCRIPT_COORDINATES (46) or TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT (40).

2010-02-21 18:07:50 Table `spell_script_target`: spellId 23359 listed for TargetEntry 5360 does not have any implicit target TARGET_SCRIPT(38) or TARGET_SCRIPT_COORDINATES (46) or TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT (40).

2010-02-21 18:07:50 Table `spell_script_target`: spellId 23359 listed for TargetEntry 5361 does not have any implicit target TARGET_SCRIPT(38) or TARGET_SCRIPT_COORDINATES (46) or TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT (40).

2010-02-21 18:07:50 Table `spell_script_target`: spellId 29364 listed for TargetEntry 16975 does not have any implicit target TARGET_SCRIPT(38) or TARGET_SCRIPT_COORDINATES (46) or TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT (40).

2010-02-21 18:07:50 Table `spell_script_target`: spellId 29435 listed for TargetEntry 17034 does not have any implicit target TARGET_SCRIPT(38) or TARGET_SCRIPT_COORDINATES (46) or TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT (40).

2010-02-21 18:07:50 Table `spell_script_target`: spellId 34665 listed for TargetEntry 16880 does not have any implicit target TARGET_SCRIPT(38) or TARGET_SCRIPT_COORDINATES (46) or TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT (40).

2010-02-21 18:07:50 Table `spell_script_target`: spellId 42411 listed for TargetEntry 4328 does not have any implicit target TARGET_SCRIPT(38) or TARGET_SCRIPT_COORDINATES (46) or TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT (40).

2010-02-21 18:07:50 Table `spell_script_target`: spellId 42411 listed for TargetEntry 4329 does not have any implicit target TARGET_SCRIPT(38) or TARGET_SCRIPT_COORDINATES (46) or TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT (40).

2010-02-21 18:07:50 Table `spell_script_target`: spellId 42411 listed for TargetEntry 4331 does not have any implicit target TARGET_SCRIPT(38) or TARGET_SCRIPT_COORDINATES (46) or TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT (40).

2010-02-21 18:07:50 Table `spell_script_target`: spellId 45115 listed for TargetEntry 25090 does not have any implicit target TARGET_SCRIPT(38) or TARGET_SCRIPT_COORDINATES (46) or TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT (40).

2010-02-21 18:07:50 Table `spell_script_target`: spellId 45115 listed for TargetEntry 25091 does not have any implicit target TARGET_SCRIPT(38) or TARGET_SCRIPT_COORDINATES (46) or TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT (40).

2010-02-21 18:07:50 Table `spell_script_target`: spellId 45115 listed for TargetEntry 25092 does not have any implicit target TARGET_SCRIPT(38) or TARGET_SCRIPT_COORDINATES (46) or TARGET_FOCUS_OR_SCRIPTED_GAMEOBJECT (40).

2010-02-21 18:08:14 Table `achievement_criteria_requirement`.`criteria_id` 12974 does not exist, ignoring.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13163 (type: 0) for achievement 4581.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13164 (type: 0) for achievement 4622.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13185 (type: 0) for achievement 4731.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13186 (type: 0) for achievement 4732.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13189 (type: 0) for achievement 4735.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13190 (type: 0) for achievement 4736.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13191 (type: 0) for achievement 4737.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13192 (type: 0) for achievement 4738.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13193 (type: 0) for achievement 4739.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13195 (type: 0) for achievement 4741.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13196 (type: 0) for achievement 4742.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13197 (type: 0) for achievement 4743.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13200 (type: 0) for achievement 4746.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13201 (type: 0) for achievement 4747.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13202 (type: 0) for achievement 4748.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13203 (type: 0) for achievement 4749.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13204 (type: 0) for achievement 4750.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13206 (type: 0) for achievement 4752.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13234 (type: 0) for achievement 2186.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13235 (type: 0) for achievement 2186.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13236 (type: 0) for achievement 2186.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13238 (type: 0) for achievement 2187.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13239 (type: 0) for achievement 2187.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13240 (type: 0) for achievement 2187.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13243 (type: 0) for achievement 4622.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13244 (type: 0) for achievement 4621.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13245 (type: 0) for achievement 4621.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13246 (type: 0) for achievement 4601.

2010-02-21 18:08:14 Table `achievement_criteria_requirement` is missing expected data for `criteria_id` 13247 (type: 0) for achievement 4601.

blueboy · February 21, 2010

Hi gundisalvus ,

Sorry to sound negative about your issue, but I think the support from the 'wow-v item forum' have given you the brush off. I have never used this item creator myself, I'm quite happy with the standard items. Have you tried running the server without your modified items. The errors suggest that this item creator has tried to modify data in the mangos database, unsuccessfully.

Try loading a clean database, to remove the corrupt data.

The database is probably using the values for other items, and thus the conflict (still using DB value). This is not a MaNGOS or playerbot issue, but is firmly in the lap of wow-v item creator support. It has nothing to do with poor code compilation. As I said in my last post you can expect some warnings as the database load, these are normal.

Hope this helps

gundisalvus · February 21, 2010

i used the silvermoon db and no errors so my compilations works fine so that means that wow-v is the problem thanks to help me with my problem bud if u know some another page like that to make items tell me... thanks anyway and for thats blueboy playerbot updates now i can have my playerbot and sd2 at day thanks if my compilation can be used for any else tell me i can tell u how compile it or mybe i can up my compilations

belfedia · February 22, 2010

Hi belfedia,
I guess you will find that the compile will stop @
  CXX    NPCHandler.o                                                                                                                                        
../../../src/game/NPCHandler.cpp: In member function â€˜void WorldSession::HandleGossipSelectOptionOpcode(WorldPacket&)â€™:                                      
../../../src/game/NPCHandler.cpp:317: error: â€˜pCreatureâ€™ was not declared in this scope                                                                      
make[3]: *** [NPCHandler.o] Error 1                                                                                                                          
Oh boy, I thought this was history. The cause of this is simple, they optimized the MaNGOS code and moved the declarartion of 'pCreature' further down the function. This was part of the controversy, I mentioned earlier.

I kept the block of playerbot code (~321) at the top of the function, and added another declaration. Look at post #455, that shows all the 'bot guy' code in one patch. This worked for me, but didn't for other users.

They chose the move the block of playerbot code to a point below the new 'pCreature' declaration. I found that this caused my server to crash when selecting the summoned 'bot guy'.

If you do not use 'bot guy' it is fine. If you do then, you will have issues. We pulled the 'bot guy' code because there was no mutual resolution. Thus the patch, I included in #455 for those who wish to fix it. If we can find a mutaul fix, then maybe it can be re-introduced to the playerbot code. I personally prefer using macros to summon multiple bots.

Hope this helps

Yes i have this error

I don't need any bot guy, just need Bot command !

I have try #455 fix, but don't working with me.

blueboy · February 22, 2010

Yes i have this error
I don't need any bot guy, just need Bot command !

I have try #455 fix, but don't working with me.

Hi

Have you managed to compile your server now.

Let me know

Edii: If the 'bot guy' code is not important, you could remove it like I did. Use the patch in post #455 as a guide to find the code.

nyko · February 22, 2010

Hi all,

I have installed enUS DBCs and tested playerbot with this results :

- server crash when you die in instance and want to enter again with your bot(s)

- fresh characters with fresh bot can't make bot equip mount, it seems that only oldest of my server can, maybe someting has changed in learn/cast mount

PS : mangos 9407 - SD2 1583 FR @ Mods : AHBot PlayerBot Teleguy Arena<>Honor @ Patchs : Boss oeil_acherus DruidFly DeathBug NewQuest utilisant la db: UDB 0.11.6 (387) for MaNGOS 9310 with SD2 SQL for rev. 1566 => ALL UPDATE OF COURSE

i've tested with PSMDB (but i hate it, too much far from blizzlike and very bugged) with same results

vladex · February 22, 2010

works fine with enGb so i think ill recomend it for everyone ... no other language fuzzines

nyko · February 22, 2010

i'll test with enGB but i'm sure it will be the same

belfedia · February 22, 2010

Hi
Have you managed to compile your server now.

Let me know]

yes i make

git clone git://github.com/mangos/mangos.git                                                      // take mangos
git reset --hard [8994]                                                                         // make 8994 master
svn co -r 1513 [url]https://scriptdev2.svn.sourceforge.net/svnroot/scriptdev2/[/url]  src/bindings/ScriptDev2        // take scriptdev2 SVN
git am [url]https://scriptdev2.svn.sourceforge.net/svnroot/scriptdev2//patches/MaNGOS-*[/url]                // apply MaNGOS-8759-ScriptDev2.patch
patch -p1 < /home/mangos/sources/playerbot.patch
autoreconf --install --force
../configure --prefix=/home/mangos/serverbot/ --sysconfdir=/home/mangos/serverbot//etc --enable-cli --enable-ra --datadir=/home/mangos/serverbot/
make -j 2
make install

and i have

  CXX    NPCHandler.o                                                                                                                                        
../../../src/game/NPCHandler.cpp: In member function â€˜void WorldSession::HandleGossipSelectOptionOpcode(WorldPacket&)â€™:                                      
../../../src/game/NPCHandler.cpp:317: error: â€˜pCreatureâ€™ was not declared in this scope                                                                      
make[3]: *** [NPCHandler.o] Error 1

Edii: If the 'bot guy' code is not important, you could remove it like I did. Use the patch in post #455 as a guide to find the code.

You want i remove all lines from #455 patch in 8965 patch ?

I'm lilttle lost on a patch files, because i don't know C or C++

blueboy · February 22, 2010

yes i make

git clone git://github.com/mangos/mangos.git                                                      // take mangos
git reset --hard [8994]                                                                         // make 8994 master
svn co -r 1513 [url]https://scriptdev2.svn.sourceforge.net/svnroot/scriptdev2/[/url]  src/bindings/ScriptDev2        // take scriptdev2 SVN
git am [url]https://scriptdev2.svn.sourceforge.net/svnroot/scriptdev2//patches/MaNGOS-*[/url]                // apply MaNGOS-8759-ScriptDev2.patch
patch -p1 < /home/mangos/sources/playerbot.patch
autoreconf --install --force
../configure --prefix=/home/mangos/serverbot/ --sysconfdir=/home/mangos/serverbot//etc --enable-cli --enable-ra --datadir=/home/mangos/serverbot/
make -j 2
make install

and i have

  CXX    NPCHandler.o                                                                                                                                        
../../../src/game/NPCHandler.cpp: In member function â€˜void WorldSession::HandleGossipSelectOptionOpcode(WorldPacket&)â€™:                                      
../../../src/game/NPCHandler.cpp:317: error: â€˜pCreatureâ€™ was not declared in this scope                                                                      
make[3]: *** [NPCHandler.o] Error 1

You want i remove all lines from #455 patch in 8965 patch ?

I'm lilttle lost on a patch files, because i don't know C or C++

Hi,

O.K there is just one line to add. The declaration of 'pCreature'

    // Playerbot mod
   Creature *pCreature = GetPlayer()->GetNPCIfCanInteractWith(guid, UNIT_NPC_FLAG_NONE);

If you go to function HandleGossipSelectOptionOpcode() in NPCHandler.cpp @ ~321, add the line just below //Playerbot mod.

* Check if there is a declartion further down. If it exists, it should be O.K to remove, to complete the compile.

The reason I suggested that you use the patch in post #455 as a guide to remove the 'bot guy', was that I found 'bot guy' caused other issues (i.e. If you select some other NPC's they also caused the server to crash. Once I removed the code, it was fine).

Print a copy of the patch from #455

1. Look for lines that begin 'diff --git', this will tell you the file being patched.

i.e diff --git a/bot_readme.txt b/bot_readme.txt

2. examine the blocks of code that start with a '+' symbol. Look in the corresponding file for this block of code. Then either delete it or comment it out.

As you do not use 'bot guy', I believe it is best if you remove it.

Edit:IMPORTANT Lines that begin with a '-' symbol will need to be restored.

* Oh one other thing. If you do decide to remove the 'bot guy' code do not delete the 'pCreature' declaration I mentioned above, or you will get the same error again.

Hope this helps

blueboy · February 23, 2010

Hi Guys

Problem:

I've been working on the bot height issue. Occassionally bots will disappear altogether below the ground level.

They also tend to hover just above the surface. As you are aware, MaNGOS utilizes two sets of maps to describe

the world's surface.

maps

Basically define the world. These are usable, but game play is abysmal. For instance, if you try to explore dungeons

with just maps, hostiles will come at you from all directions, passing through floors, walls, and ceiling.

vmaps

Facilitate Line-Of-Sight (LOS) calculations, that effectively make floors, ceiling and wall opaque to hostiles. These LOS calculations also go some way to stop bots & NPC's from passing through solid objects. You retort, not very well :rolleyes:

At present the calculation will either use the raw calculated (Z) height coordinate, based on maps, or the LOS (vmaps) coordinate, if activated in 'mangosd.conf'. I have found that the contours of 'maps' and 'vmaps' do not match (i.e. peaks and troughs in the landscape). The result is that occasionally bots will disappear into a trough below the visible surface, based on either of the calculated methods. I thought that it might be an improvement if the calculated height could be based on both methods.

This is where I need your help. I have created a patch to test, and would be grateful if you could try it out on your servers,

diff --git a/src/game/Object.cpp b/src/game/Object.cpp
index a0ccace..eab34f2 100644
--- a/src/game/Object.cpp
+++ b/src/game/Object.cpp
@@ -1428,9 +1428,20 @@ void WorldObject::GetRandomPoint( float x, float y, float z, float distance, flo

void WorldObject::UpdateGroundPositionZ(float x, float y, float &z) const
{
-    float new_z = GetBaseMap()->GetHeight(x,y,z,true);
-    if(new_z > INVALID_HEIGHT)
-        z = new_z+ 0.05f;                                   // just to be sure that we are not a few pixel under the surface
+    float map_z = GetBaseMap()->GetHeight(x,y,z,false);
+    float vmap_z = GetBaseMap()->GetHeight(x,y,z,true);
+ 
+    // sLog.outDebug("UpdateGroundPositionZ: x: %f, y: %f z: %f  vmap_z: %f   map_z:  %f" , x, y, z, vmap_z, map_z);
+    
+    if(vmap_z > INVALID_HEIGHT)
+      z = vmap_z;    // add or subtract say 0.05f, to adjust bot hover height
+
+    if((map_z > vmap_z) && (map_z > z))
+          z = map_z;
+
+    // sLog.outDebug("UpdateGroundPositionZ2: x: %f, y: %f z: %f  vmap_z: %f   map_z:  %f" , x, y, z, vmap_z, map_z);
+
+    MaNGOS::NormalizeMapCoord(z);
}

bool WorldObject::IsPositionValid() const

and give me some feedback.

Cheers

belfedia · February 23, 2010

Many many many many many many .... // .... many thanks blueboy !

That's work marvellous, is magic !!! Much players from my server thanks you also for long time !

Server is stable, i think i don't add sql for botguy and no problems

Perhaps it is possible to add the NPChandler.cpp mod in 8965 patch, but i have not enough skill for that.

Sign In

Playerbot (archive)

Recommended Posts

Link to comment

Share on other sites

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Recently Browsing 0 members

Contact Us

Repositories

Important Information