Jump to content

[patch][8510] improved flash heal


Auntie Mangos

Recommended Posts

This patch implements the dummy effect of the priest's talent "Improved Flash Heal" (http://www.wowhead.com/?spell=63504).

http://github.com/pasdVn/mangos/commit/689d077b6ff9e4a7bd25328416ef70164202130d

I'm don't know why healing spells are not loaded with a unit target currently in Spell::DoAllEffectOnTarget. I posted a simliar fix some month ago ( http://getmangos.eu/community/viewtopic.php?id=6040) and there wasn't this problem. So I don't know if anybody removed this intendedly or if this is a typo when recoding/apllying coding style, whatever (I don't see a reason for this). Anyway some other effects won't work without this change (Renewed Hope, Sacred Shield).

pasdVn

Link to comment
Share on other sites

I'm don't know why healing spells are not loaded with a unit target currently in Spell::DoAllEffectOnTarget. I posted a simliar fix some month ago ( http://getmangos.eu/community/viewtopic.php?id=6040) and there wasn't this problem. So I don't know if anybody removed this intendedly or if this is a typo when recoding/apllying coding style, whatever (I don't see a reason for this). Anyway some other effects won't work without this change (Renewed Hope, Sacred Shield).

Actually that line wasn't changed since the proc patch by DiSlord was applied.

Link to comment
Share on other sites

  • 39 years later...

Hmm, ok I see. I could swear that the other fix worked... seems as I am wrong :-/

But as I see before the proc flag patch it was also called with a unit target. Just wondered and was unsure, because it was explicitly coded there as a NULL pointer.

Link to comment
Share on other sites

  • 2 months later...
Guest
This topic is now closed to further replies.
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use