[9456] [Fix] Partial Blocks Not Triggering Procs

[nos4r2zod]

What bug does the patch fix? What features does the patch add?

Partially blocked attacks should still be allowed to trigger procs.

One example of this is Hodir's Frozen Blows. It would almost be a non-issue if partial blocks would completely prevent the proc effect.

For which repository revision was the patch created?

8232

Who has been writing this patch? Please include either forum user names or email addresses.

Myself

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 39ba617..56ccca8 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -1314,6 +1314,8 @@ void Unit::CalculateMeleeDamage(Unit *pVictim, uint32 damage, CalcDamageInfo *da
                damageInfo->TargetState = VICTIMSTATE_BLOCKS;
                damageInfo->blocked_amount = damageInfo->damage;
            }
+            else
+                damageInfo->procEx|=PROC_EX_NORMAL_HIT;     // Partial blocks can still cause attacker procs
            damageInfo->damage      -= damageInfo->blocked_amount;
            damageInfo->cleanDamage += damageInfo->blocked_amount;
            break;

Edit: update rev.

[imblizzspy]

Was this ever fixed?

[VladimirMangos]

nos4r2zod confirm that yes: [9456]