[patch][6174] Eye Remove Flag At End Of Bg

[balrok]

patch is from me

bugreport not found

fix: it removes the flag at end of game, as expected

Index: BattleGroundEY.cpp
===================================================================
--- BattleGroundEY.cpp        (revision 6166)
+++ BattleGroundEY.cpp        (working copy)
@@ -571,8 +571,6 @@

void BattleGroundEY::EventPlayerDroppedFlag(Player *Source)
{
-        if(GetStatus() != STATUS_IN_PROGRESS)
-                return;

        const char *message = "";
        uint8 type = 0;

cause this function gets called at end of bg, where "getstatus()" != status_in_progress, i removed this check..

[VladimirMangos]

Where it called at end of BG? Can you provided backtrace or just code line...

Remove in general can allow cheating...

[DreamerDDL]

void BattleGround::RemovePlayerAtLeave(uint64 guid, bool Transport, bool SendPacket)
{
       // Remove from lists/maps
....
       Player *plr = objmgr.GetPlayer(guid);

       if(plr && !plr->isAlive())                                                            // resurrect on exit
       {
               plr->ResurrectPlayer(1.0f);
               plr->SpawnCorpseBones();
       }

       RemovePlayer(plr, guid);                                                                // BG subclass specific code
    ^^^^^^^^^^^^^^^^^
....

void BattleGroundEY::RemovePlayer(Player *plr, uint64 guid)
{
       // sometimes flag aura not removed 
       for (int j = EY_POINTS_MAX; j >= 0; --j)
       {
               for(int i = 0; i < m_PlayersNearPoint[j].size(); ++i)
                       if(m_PlayersNearPoint[j][i] == guid)
                               m_PlayersNearPoint[j].erase(m_PlayersNearPoint[j].begin() + i);
       }
       if(IsFlagPickedup())
       {
               if(m_FlagKeeper == guid)
               {
                       if(plr)
                               this->EventPlayerDroppedFlag(plr);
                               ^^^^^^^^^^^^^^^^^^^^^^
                       else
                       {
                               SetFlagPicker(0);
                               RespawnFlag(true);
                       }
               }
       }
}

[VladimirMangos]

Hm, .. I see... I look in first time at wrong function.

[added]in [6174]. Thank you. I remove sma echeck and in WS case. In general drop flag must be allowed in any state in different from other events.