[patch][in 0.12] Druid tree of life bonusheal fix

[FragFrog]

What bug does the patch fix? A druid in tree-form should generate bonus healing equal to 25% of his spirit.

For which repository revision was the patch created? 0.12 (backport from 7819)

Is there a thread in the bug report section or at lighthouse? No, figured I'd fix this one myself.

Who has been writing this patch? Me, FragFrog

When a druid shapeshifts into tree of life form, effect 5420 is cast, triggering 34123 in turn with an additional modify for spirit/4 bonus healing. However, Aura::HandleShapeShiftBoosts also already casts that spell, resulting in the boost never actually aplying. This simply removes the redundant cast from Aura::HandleShapeShiftBoosts.

0.12 branch only - in 0.13 and beyond this spell is changed to a static spell granting 6% bonus healing instead, which makes the bug not occur there. However, I believe the redundant cast is present there as well (see patch 7164), so while not bugged, for later branches too it is neater to either remove the cast here, or in Spell::EffectDummy.

--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -5227,8 +5227,7 @@ void Aura::HandleShapeshiftBoosts(bool apply)
            break;
        case FORM_TREE:
            spellId1 = 5420;
-            spellId2 = 34123;
-            break;
+		 	 break;
        case FORM_TRAVEL:
            spellId1 = 5419;
            break;

[Sarjuuk]

confirmed working.

for both mangos-0.12 and master

Thank you

[VladimirMangos]

for both mangos-0.12 and master

It not work with this code change at master. So 0.12 only change.

Added in 0.12 sources. Thank you

[Sarjuuk]

does not.. hmm, strange.

i could have sworn healing was still increased correctly, when this spell was commented out.

[VladimirMangos]

I can clarify: when i close client in tree form at check and login i also see this buf with dropped line, but it not reapplied at tre foem next cast and never after. This just result auras save.

[FragFrog]

I expect the duplicate entry should be removed at Spell::EffectDummy for 0.13 and later - it is only there for the 0.12 branch because the aura requires a spirit calculation. Thanks for including this!

[VladimirMangos]

master is 0.15 in fact

I think about move to dummy but it work in current way. So i let it be in current state.