[patch][9504] Pyroclasm

[KAPATEJIb]

What bug does the patch fix? What features does the patch add?

fixes talent http://www.wowhead.com/?spell=18096 as it should work with 3.2.2 patch

For which repository revision was the patch created?

9061

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

no

Who has been writing this patch? Please include either forum user names or email addresses.

Me

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 15cbf8c..0d6a233 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -7047,32 +7047,14 @@ bool Unit::HandleProcTriggerSpell(Unit *pVictim, uint32 damage, Aura* triggeredB
            // Pyroclasm
            if (auraSpellInfo->SpellIconID == 1137)
            {
-                if(!pVictim || !pVictim->isAlive() || pVictim == this || procSpell == NULL)
-                    return false;
-                // Calculate spell tick count for spells
-                uint32 tick = 1; // Default tick = 1
-
-                // Hellfire have 15 tick
-                if (procSpell->SpellFamilyFlags & UI64LIT(0x0000000000000040))
-                    tick = 15;
-                // Rain of Fire have 4 tick
-                else if (procSpell->SpellFamilyFlags & UI64LIT(0x0000000000000020))
-                    tick = 4;
-                else
-                    return false;
-
-                // Calculate chance = baseChance / tick
-                float chance = 0;
                switch (auraSpellInfo->Id)
                {
-                    case 18096: chance = 13.0f / tick; break;
-                    case 18073: chance = 26.0f / tick; break;
+                    case 18096: trigger_spell_id = 18093; break; // Rank 1
+                    case 18073: trigger_spell_id = 63243; break; // Rank 2
+                    case 63245: trigger_spell_id = 63244; break; // Rank 3
+                    default:
+                        return false;
                }
-                // Roll chance
-                if (!roll_chance_f(chance))
-                    return false;
-
-                trigger_spell_id = 18093;
            }
            // Drain Soul
            else if (auraSpellInfo->SpellFamilyFlags & UI64LIT(0x0000000000004000))

i hope i make a correct SQL file

/* Pyroclasm */
DELETE FROM `spell_proc_event` WHERE entry IN(18073,18096,63245);
INSERT INTO `spell_proc_event` VALUES
(18073,0,5,256,8388608,0,0,2,0,0,0),
(18096,0,5,256,8388608,0,0,2,0,0,0),
(63245,0,5,256,8388608,0,0,2,0,0,0);

[cyrex]

Is this sitll valid for 3.3.2?

I ask since this is KapateJib work (And like always a good work)

[zergtmn]

Old code can be fully removed, but sql is needed.

[cyrex]

Dont remember if i applied code or only SQL but it works.

[ApoC]

Applied in [9504], proc flags looks to be already in

Thank You.