[9935] ACE Realmd Netcode

[Derex]

Hello,

I would like to present for preview a patch for making realmd use ACE framework instead of the old sockets library for networking.

[EDIT] The patch is already commited in mangos

[Infinity_return]

I tested this patch, works fine.

But there are comments:

If you connect more than 2000 people simultaneously realm server stops allowed connections, this is not freeze, and when the number connections to about 1000 people, realm server again begins to function normally.

Another problem, if you enter the game, and then go out and seek realm list, they will all be offline.

OS: Linux Debian 5.0 x64

ACE 5.7.6

[Derex]

Hello,

Thanks for reply

here is answer for the reports:

1) Are you sure you have ulimit -n properly set ? If ulimit -n is set to 2048 or something near, then the behavior is expected, try to increase it.

2) I believe the bug exists both in current mangos implementation in realmd and in the new realmd, here is quick fix for the new realmd (its a hack fix that works only on little endian machines, like yours), for old realmd fix is similar.

diff --git a/src/realmd/AuthSession.cpp b/src/realmd/AuthSession.cpp
index 965c528..c7f1fa5 100644
--- a/src/realmd/AuthSession.cpp
+++ b/src/realmd/AuthSession.cpp
@@ -749,6 +749,8 @@ bool AuthSession::_HandleReconnectChallenge()
    _safelogin = _login;
    loginDatabase.escape_string(_safelogin);

+    _build = ch->build;
+
    QueryResult *result = loginDatabase.PQuery ("SELECT sessionkey FROM account WHERE username = '%s'", _safelogin.c_str ());

    // Stop if the account is not found

[Infinity_return]

Yes, open files (-n) 4096

Clean mangos realm freeze and CPU use 100% after ~1000 ppl connections in one sec.

_build = ch->build; - works

[Derex]

I amended the commit at http://github.com/derex/mangos/tree/realmd with _build = ch->build; hack and also with diagnostics output of ulimit -n on server startup and enchantment that will ease debugging of the server.

[EDIT] I tested opening 10 000 connections to realmd, and then login, and there was no problem.

[EDIT 2] 20 000 connections were also no problem.

[Thyros]

Derex, is this compatible under unix?

[Homenixx]

Yes, open files (-n) 4096

Clean mangos realm freeze and CPU use 100% after ~1000 ppl connections in one sec.

Confirmed on actual realmd but with this works fine.

Tested with ~2000 conections at the same second and not freeze for now... appear to works as intended

[Skirnir]

Derex is a gnu/linux dude, maybe you could ask if it compiles under win ;-)

kind regards & thanks derex (again for all you did and do)

Skirnir

[Gotisch]

Why is this needed? is old network code not performant enough? or is it just to make everything use ace library?

[VladimirMangos]

1) old code have known freezes

2) use 2 socket lib in one project also not nice, additinal conflicts in code etc. Using only ACE let do more cleanups and improve portability

[kero99]

Yes, open files (-n) 4096

Clean mangos realm freeze and CPU use 100% after ~1000 ppl connections in one sec.

_build = ch->build; - works

Confirmed, still freeze on high population reconnect after crash =(

Debian Lenny and Realmd dedicated server.

[Derex]

Anybody tested it on freebsd and windows ?

[nanounico]

I can confirm, in linux when the server start, from a crash, or first start, CPU 100% = Freeze ~5minuts

[Thyros]

not works with ace 5.7.7

[Derex]

ACE version 5.7.7 is not officially supported by MaNGOS

[Skirnir]

So Mr. Derex, three weeks have passed, is it time to release? Or are you still waiting for Windows/FreeBSD tests?

Regards

Skirnir

[Thyros]

added this to master please!

[hunuza]

Derex told me that he has finished the patch support, but he would need to update it for 3.3.3a and he is currently very busy...

[Thyros]

can you post the realmd with patcher support?

[kero99]

Temp patch update to Rev 9799 until Derex release latest version

http://pastebin.com/ttvtBFR9

Best Regards

[heugabel]

[9935] ACE realmd, thanks to Zor and Vladimir for windows.

but how does work the patch system?

[Derex]

It works the same way as before

[Thyros]

and what was the old way?

[heugabel]

It works the same way as before

before this commit doesn´t exist a patchsystem.

[Derex]

I beleive patch system exists from 3-4 years ago. With new ACE realmd, the patch support is the same like before. In development versions of ace realmd, patch support has been temporary disabled, because I had to reimplement it ontop of ace networking.