Jump to content

[9693][fix for 3.3.3] Revenge calculation


Recommended Posts

Posted

diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
index e5014f4..542961d 100644
--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -403,9 +403,9 @@ void Spell::EffectSchoolDMG(SpellEffectIndex effect_idx)
                    damage = uint32(damage * m_caster->GetTotalAttackPowerValue(BASE_ATTACK) / 100);
                    m_caster->ModifyAuraState(AURA_STATE_WARRIOR_VICTORY_RUSH, false);
                }
-                // Revenge ${$m1+$AP*0.207} to ${$M1+$AP*0.207}
+                // Revenge ${$m1+$AP*0.310} to ${$M1+$AP*0.310}
                else if (m_spellInfo->SpellFamilyFlags & UI64LIT(0x0000000000000400))
-                    damage+= uint32(m_caster->GetTotalAttackPowerValue(BASE_ATTACK) * 0.207f);
+                    damage+= uint32(m_caster->GetTotalAttackPowerValue(BASE_ATTACK) * 0.310f);
                // Heroic Throw ${$m1+$AP*.50}
                else if (m_spellInfo->SpellFamilyFlags & UI64LIT(0x0000000100000000))
                    damage+= uint32(m_caster->GetTotalAttackPowerValue(BASE_ATTACK) * 0.5f);

What does it fix? It fix the calculation of the warrior revenge spell.

According to wowhead it should be 0.310 instead of 0.207 .

Link: http://www.wowhead.com/?spell=6572

Made? Me, my first, maybe it is wrong lol

Posted

wowhead is less isn't 100% correct info source. spell.dbc description + offcial comments that this not typo is.

Also wowhead show data for current client and mangos not suport it yet.

So it or wrong or for 3.3.3. Base at expection last i update title...

Posted
wowhead is less isn't 100% correct info source. spell.dbc description + offcial comments that this not typo is.

Also wowhead show data for current client and mangos not suport it yet.

So it or wrong or for 3.3.3. Base at expection last i update title...

Correct, it's for 3.3.3

WoW patch notes:

Warriors

* Revenge: Damage done by this ability (base and scaling) increased by 50%.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use