No Reconnect, its possible to implement?

[heugabel]

Hi Devs,

Its possible to implement a reconnect feature at realmd and mangosd for mysql?

When the Server runs and mysql have a restart, the realmd and mangosd process does not reconnect to mysql. only a restart solves this.

i hope you know what i mean

tested with debian 5 and centos 5.4 cpanel

[Toinan67]

Hi,

File src/shared/Database/DatabaseMysql.cpp

PExecute("SET NAMES `utf8`");
PExecute("SET CHARACTER SET `utf8`");

+ my_bool my_true = (my_bool)1;
+ mysql_options(mMysql, MYSQL_OPT_RECONNECT, &my_true));

It should work

[xeross155]

Why hasn't this been implemented in the core yet, is there some kind of problem that it would cause ?

[Toinan67]

No idea, maybe mangos devs don't find it useful? Except for SD2 scripts that have access to the DB, I don't think it is really useful.

And at runtime, if the Mysql server stop...the MaNGOS server cannot work, with or without auto reconnect ^^

[heugabel]

if the Mysql server stop...the MaNGOS server cannot work, with or without auto reconnect ^^

but a restart of mysql is what i mean :-)

[Toinan67]

but a restart of mysql is what i mean :-)

A restart of Mysql = Mysql server stop for a few seconds (then starts again).

During those few seconds, MaNGOS has absolutely no access to the DB. Big problem!

Anyway, Mysql server shouldn't be restarted while MaNGOS is running. Does Mysql restart randomly?

[VladimirMangos]

Why hasn't this been implemented in the core yet, is there some kind of problem that it would cause ?

This is same as suggest not restart mangosd at crash. Always better restart mangosd if current in memory data possible corrupted or desync with Db data or you have chance corrupt Db data also.

[ilija]

the Insider42's branch has that implented i thought

[xeross155]

Perhaps when this happens restart the server after a while, because the way it is now all looks fine except you'll get an error on login because it doesn't have the mysql connection.