[10295] [patch] Hallow's End Treat Fix

[Auntie Mangos]

* What bug does the patch fix? What features does the patch add?

-In previous revs the item Hallow's End Pumpkin Treat was not working at all; the item would be consumed with no effect. This patch adds the effect.

* For which repository revision was the patch created?

-This patch is for rev 10197

* Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

- http://getmangos.eu/community/viewtopic.php?id=14606&p=119577#post119577

* Who has been writing this patch? Please include either forum user names or email addresses.

-I have, [email protected]

diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
index bff584f..099187f 100644
--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -1013,6 +1013,20 @@ void Spell::EffectDummy(SpellEffectIndex eff_idx)
                    m_caster->CastSpell(m_caster, 23782, true);
                    m_caster->CastSpell(m_caster, 23783, true);
                    return;
+                case 24930:                                 //Hallow's End Treat
+                {
+                    uint32 spell_id = 0;
+                    switch(irand(1,4))
+                    {
+                        case 1: spell_id = 24924; break;   //Larger and Orange
+                        case 2: spell_id = 24925; break;  //Skeleton          
+                        case 3: spell_id = 24926; break;  //Pirate        
+                        case 4: spell_id = 24927; break;  //Ghost                         
+                    }
+                    m_caster->CastSpell(m_caster,spell_id,true);
+                }
                case 25860:                                 // Reindeer Transformation
                {
                    if (!m_caster->HasAuraType(SPELL_AURA_MOUNTED))

[dpedroia15]

I know it's not a hugely important fix, but is there any reason for this to not be implemented?

[Unkle Nuke]

It's not that anything has to be wrong with your code. Some patches have a higher priority for review than others.

Please be more patient. It can sometimes take weeks for the core devs to review your work. There's few of them and a large number of patches to sort through.

Thank you for your work. I'll definitely be adding this one to my server for testing. I like to have a "Week of Holidays" during the summer doldrums, where all the seasonal events get at least one day to run.

[dpedroia15]

Ahhhh I see now. I was umder the impression that something might be wrong. Thanks for the clarification.

[dpedroia15]

Ummm, I hate to bump this, but I don't want it to fall to the bottom of the forums when its a working patch, not a work in progress.

[zergtmn]

Isn't this check useless?

if(m_caster->GetTypeId() != TYPEID_PLAYER)
   return;

[NoFantasy]

Useless, in terms of that the spells used won't do/can't do any real harm if caster is Unit. I wold not have noticed though, if it wasn't for the comment

+1, will commit when I get time tomorrow

[zergtmn]

I think it is useless to check here because aura and effect handlers already have all required checks. I'd rather allow such funny spells to work on npcs too.

[NoFantasy]

[10295], after removing some whitespace