[10281][Fix] Display guild accounts number in HandleGuildInfoOpcode

[Toinan67]

• * What bug does the patch fix? What features does the patch add?
  Send the guild accounts numbers instead of the members number in HandleGuildInfoOpcode
  * For which repository revision was the patch created?
  10277
  * Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.
  Didn't found any
  * Who has been writing this patch? Please include either forum user names or email addresses.
  porteyoplait (=me)
  

Here is the patch : http://paste2.org/p/929774

[Unkle Nuke]

I'll add this one to my core, but testing won't be easy since I'm the sole user of my server.

Thank you very much for another great fix, Toinan!

[Patman128]

There are a few mistakes, trailing whitespace at 13, 22, 25, and extra spaces at 19.

[Toinan67]

Without whitespace/extra spaces : http://paste2.org/p/929561

Edit : btw, I don't know how often the HandleGuildInfoOpcode is called, maybe it would be better to add something like m_accountsNumber in Guild.h to avoid too much calculation?

[Patman128]

Without whitespace/extra spaces : http://paste2.org/p/929561

Edit : btw, I don't know how often the HandleGuildInfoOpcode is called, maybe it would be better to add something like m_accountsNumber in Guild.h to avoid too much calculation?

Yes, but remember to updated m_accountsNumber everytime someone joins or leaves, etc.

[Toinan67]

First post updated with the new patch.

I added m_accountsNumber which is updated when someone joins or leave the guild, and I added players who are not logged in in the calculation of it.

[Mylifesuxito]

plz forgive me for this noob question but what this fix? i dont understud

[Toinan67]

plz forgive me for this noob question but what this fix? i dont understud

I just noticed a "todo" in the source code :

data << uint32(guild->GetMemberSize());                 // amount of accounts (TODO: implement)

The number sent was the number of members, not the number of accounts. This patch sends the number of accounts.

I don't even know if this number is still used in the client, but well at least I tried ^^

[VladimirMangos]

GetPlayerAccountIdByGUID do always DB query for offline player. So N quearies at each member add/remove. Very bad way update.

[added]I test patch with modification that let avoid this query. If all ok i will commit soon.

[VladimirMangos]

In [10281] with described changes. Thank you

/guildinfo can be used for check work.

[added]Hmm, i use forum nick as author name

[Toinan67]

No problem with your changes, I'm just here to watch and learn ^^

And for the author name, don't care at all

Edit : and btw, never forget the TODO and FIXME marks in the source code, that's really useful!