Jump to content

Remove trailing whitespaces in dep/include/mysql


Recommended Posts

Posted

This is _bad_ idea in reality. Any not real important reason changes (as hot fixes) very not recommended in 3rd party library headers.

Mostly because this make later update (and compare changes at update) lot more hard.

So batter not touch its without important reason.

Posted

Some seem to be fixed as of 5.1.50 just downloaded the source package and checked it. Some are not.

I just thought they were MaNGOS whitespaces. Didn't know Oracle made 'em. I wont commit the fix to their board. If you want to feel free. I'm switching to Postgresql and just fixed these since they bother me at git add * and git commit -am "<text>". Yeah lazy I know ... :-)

Yours

Skirnir

Posted

I didn't do anything special

 cd mangos
git pull
git checkout <mybranch>
git merge master
nano <conflict file>
git add *
git commit -am "<commit message>"

there I got the whitespace warnings and git commit didn't work untill I fixed them.

Edit: Hm for now I can't reproduce the warning. Maybe I got them because of the initial file in conflict message. Guess it's nothing to get a headache about :-)

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use