Jump to content

[fix] Correct format parameter for a printf call.


Recommended Posts

Posted

I was browsing through mangos sources today and I found that one printf() is incorrect. The printf() itself is not in mangos sources, but in contrib/AD (map & dbc extractor sources), in system.cpp. Line 403, there's:

printf("File: filename\\nCan't find area flag for areaid %u [%d, %d].\\n", filename, areaid, cell->ix, cell->iy);

which should be:

printf("File: %s\\nCan't find area flag for areaid %u [%d, %d].\\n", filename, areaid, cell->ix, cell->iy);

Small fix, but pretty important since on some OS'es a runtime error may be thrown.

No threads related to this bug where found.

Bug existent on MaNGOS rev. 10459

Posted

created a patch out of it: http://gist.github.com/572267

i also remarked, that files from visual studio don't get excluded, so the .opensdf (VC100) file was also shown in my git-diff. maybe move those VS-specific .gitignore from /win/.gitignore to /.gitignore so that it also counts for all the projects in /contrib/ and /dep/ ?

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use