Jump to content

[fix]CONDITION_NOITEM


Recommended Posts

Posted

Condition should consider an item in the bank, otherwise you may get some an item, for example, tabard.

diff --git a/src/game/ObjectMgr.cpp b/src/game/ObjectMgr.cpp
index 42570d6..6e84d2c 100644
--- a/src/game/ObjectMgr.cpp
+++ b/src/game/ObjectMgr.cpp
@@ -8095,7 +8095,7 @@ bool PlayerCondition::Meets(Player const * player) const
            return false;
        }
        case CONDITION_NOITEM:
-            return !player->HasItemCount(value1, value2);
+            return !player->HasItemCount(value1, value2, true);
        case CONDITION_SPELL:
        {
            switch(value2) 

  • 2 weeks later...
Posted

this is unclear case. Sometime can be need check without bank, sometime with bank...

Also ITEM/NOITEM conditions created as pair and do its have diff meaning can create problems with its correct using.

I prefer add new conditions for bank case... (in [10668]).

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use