Span1sh

Patch really reducing CPU usage ~40% and it is perfect! But we got redundant core freezes = crashes on online ~400 players with patch for 9750+ in mangos 9771 core. There is no useful crash dump because of freezes (((

Any suggestions?

Is there any CPU usage reducing effect from this patch? Or it is made only 4 better functionality?

lock for spell update with ACE multithread map : http://paste2.org/p/688715

Thx. I'll try that and report...

Uptime ? ~3 hours, online players ? ~3000.

But you need include OMP, and i don't know if it's work with ACE mtmaps, but i can create a little patch for ACE if you want.

I have just add that :

   #pragma omp critical(spellLock)
   {
       m_Events.Update( p_time );
       _UpdateSpells( p_time );
   }

Yes pls create that patch. And I am very interested why you have chosen OpenMP against ACE? Is it much more stable?

P/S What core rev do you use? Is there any custom patches except MTMAPS?

Best Regards

Thx a lot

With the patch of infinity, yeah i haven't crash like "if(!spell->target)", but a lot of crash appear with the patch (with delete pointer i think).

Some crashlog :

- http://paste2.org/p/688254

- http://paste2.org/p/688257

- http://paste2.org/p/688258

So, for the moment i add a #omp pragma critial(blk) and no crash, but performance is better without lock.

Can you post your rev. , avg. online, avg. uptime and locked code points please.

I asked this because of that i have lots of crashes with online ~ 500

Best Regards

Got almost same crash dump, as mns. I also can confirm crash still exist after rev 9288

I think i got same crash, but with ACE-mtmaps it looks like that:

#0 Group::EndRoll (this=0x8c7a88500) at stl_list.h:223
#1 0x000000000050c4dc in Creature::Update (this=0x8ce703000, diff=Variable "diff" is not available.
)

at ../../../src/game/Creature.cpp:407

#2 0x00000000005c9eb8 in VisitorHelper<MaNGOS::ObjectUpdater, Creature> (

v=@0x7ffffeff8e90) at GridNotifiersImpl.h:47

#3 0x00000000005dbab2 in Map::Update (this=0x8c9c80000, t_diff=Variable "t_diff" is not available.
)

at TypeContainerVisitor.h:70

#4 0x00000000005dd039 in InstanceMap::Update (this=0x8c9c80000,

t_diff=@0x8c7ca2210) at ../../../src/game/Map.cpp:2503

#5 0x00000000007c5a68 in MapInstanced::Update (this=0x839f90000,

t=@0x8c7ca2210) at ../../../src/game/MapInstanced.cpp:63

#6 0x00000000005ec082 in MapUpdateRequest::call (this=0x8c7ca21f0)

at ../../../src/game/MapUpdater.cpp:47

#7 0x000000000081fefb in DelayExecutor::svc (this=0x813c64e18)

at ../../../src/shared/DelayExecutor.cpp:60

#8 0x0000000800c52117 in ACE_Task_Base::svc_run ()
from /usr/local/lib/libACE-5.7.5.so #9 0x0000000800c52431 in ACE_Thread_Adapter::invoke ()
from /usr/local/lib/libACE-5.7.5.so #10 0x000000080194f4d1 in pthread_getprio () from /lib/libthr.so.3 . 

Mb somebody knows how to fix current code without any revertion?

Got crash:

#0 Group::EndRoll (this=0x8c7a88500) at stl_list.h:223

#1 0x000000000050c4dc in Creature::Update (this=0x8ce703000, diff=Variable "diff" is not available.

)

at ../../../src/game/Creature.cpp:407

#2 0x00000000005c9eb8 in VisitorHelper<MaNGOS::ObjectUpdater, Creature> (

v=@0x7ffffeff8e90) at GridNotifiersImpl.h:47

#3 0x00000000005dbab2 in Map::Update (this=0x8c9c80000, t_diff=Variable "t_diff" is not available.

)

at TypeContainerVisitor.h:70

#4 0x00000000005dd039 in InstanceMap::Update (this=0x8c9c80000,

t_diff=@0x8c7ca2210) at ../../../src/game/Map.cpp:2503

#5 0x00000000007c5a68 in MapInstanced::Update (this=0x839f90000,

t=@0x8c7ca2210) at ../../../src/game/MapInstanced.cpp:63

#6 0x00000000005ec082 in MapUpdateRequest::call (this=0x8c7ca21f0)

at ../../../src/game/MapUpdater.cpp:47

#7 0x000000000081fefb in DelayExecutor::svc (this=0x813c64e18)

at ../../../src/shared/DelayExecutor.cpp:60

#8 0x0000000800c52117 in ACE_Task_Base::svc_run ()

from /usr/local/lib/libACE-5.7.5.so #9 0x0000000800c52431 in ACE_Thread_Adapter::invoke ()

from /usr/local/lib/libACE-5.7.5.so #10 0x000000080194f4d1 in pthread_getprio () from /lib/libthr.so.3

Is there any news with this patch? Can anybody help?

O_o Core version?

8869 (using FreeBSD 7.2 x64, but no matter)

Got another crash:

#1  0x00000000008d9cea in WorldSession::HandleQuestgiverStatusMultipleQuery (
   this=0x81ad80880) at stl_tree.h:258
258             _M_node = _Rb_tree_increment(_M_node);
(gdb) frame 2
#2  0x000000000084b91b in WorldSession::Update (this=0x81ad80880)
   at ../../../src/game/WorldSession.cpp:230
230                         (this->*opHandle.handler)(*packet);
(gdb) frame 3
#3  0x00000000008416dd in World::UpdateSessions (this=0x802349000, diff=22)
   at ../../../src/game/World.cpp:2100
2100            if(!itr->second->Update(diff))                      // As interval = 0
(gdb) frame 4
#4  0x0000000000842d22 in World::Update (this=0x802349000, diff=22)
   at ../../../src/game/World.cpp:1644
1644            UpdateSessions(diff);
(gdb) frame 5
#5  0x00000000004fac92 in WorldRunnable::run (this=Variable "this" is not available.
)
   at ../../../src/mangosd/WorldRunnable.cpp:60
60              sWorld.Update( diff );
#6  0x0000000000922d5c in ACE_Based::Thread::ThreadTask (param=Variable "param" is not available.
)
   at ../../../src/shared/Threading.cpp:183
183         _task->run();

mtmaps ACE (8799+):

http://paste2.org/p/508050

After installation of a patch the server got сrash.

Also got сrashes in different places at various times without any sequences.

For example:

 #14 0x000000000069ab1d in VisitorHelper<ObjectGridUnloader, Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > (v=@0xb9ef18, c=@0x7fffffffe7d6)
   at TypeContainerVisitor.h:68
68      TypeContainerVisitor.h: No such file or directory.
       in TypeContainerVisitor.h

Please, help...=(

I'm used ace mtmaps on last rev, very stable in MapUpdate.Threads = 2

Can you give me some link to the patch that you are using please?

Dear, kero99 , excuse me please for my poor English, but could you post your comments for these two moments:

- 1) MySQL with INNODB Tunning Configuration: Without very very good config and tunnig... mangos =lag. 950+ needed

- 2) HDD IO: Without good rate IO in HDD of MySQL witn 1800+... mangos=lag

I'm interested in:

1) Your MySQL config.

2) What HDD are you using?

3) Any other tunning that you made in the core.

4) And if you are using MTMAPS patch with your own modifications, could you share it please or put a reference?