Jump to content

lfxgroove

getMaNGOS Staff
  • Posts

    250
  • Joined

  • Last visited

  • Donations

    0.00 GBP 

Bug Comments posted by lfxgroove

  1. As it currently stands i can not reproduce this bug on linux. Running the latest code from github branch Rel20 with no SD2, no Eluna, no tools built and debug mode enabled. eg:

    [code]cmake .. -DCMAKE_INSTALL_PREFIX=~/src/c++/mangoszero/bin/rel20/ -DSCRIPT_LIB_ELUNA=0 -DSCRIPT_LIB_SD2=0 -DBUILD_TOOLS=0 -DDEBUG=1[/code]

    I've tried with .server restart 0, .server shutdown 0 and CTRL-c, all to no avail. Do players need to be on the server for this to happen? Has anyone else managed to get it happening on linux?

  2. Would you like to test the attached patch and see if it helps you? This solved the problem for me.

    You can apply it using git am or the like, see [url]https://ariejan.net/2009/10/26/how-to-create-and-apply-a-patch-with-git/[/url] for some more info or ask here if you have trouble applying it.

    Forgot to mention, it's intended for Rel20 as it seems i forgot the option() part in Rel19, sorry about that. But if you've got both the option() and the patch it should work as expected.

  3. Just noticed that this seems to be related to another bug mentioned in [url]https://www.getmangos.eu/help-amp-support/9957-zero-rel19-top-5-major-bugs.html[/url].

    Would you like to try with the following patch?
    [code]
    From 36a585caeca6c4f3080ea2f5bd6776a0e3170e0e Mon Sep 17 00:00:00 2001
    From: lfxgroove
    Date: Tue, 29 Jul 2014 12:47:06 +0000
    Subject: [PATCH 1/2] [Core/Realmd] Fix crash when database version doesn't
    match.

    The general gut feeling is that the Runnable shouldn't ref-count itself, but rather eg.
    ACE_Strong_Bound_Ptr should be used for that purpose to ensure deletion at the correct
    time. Comments?

    Also remove #define MANGOS as that's defined on the command line when building
    ---
    src/game/SharedDefines.h | 1 -
    src/shared/Threading.cpp | 4 +++-
    2 files changed, 3 insertions(+), 2 deletions(-)

    diff --git a/src/game/SharedDefines.h b/src/game/SharedDefines.h
    index 7261229..b58cafc 100644
    --- a/src/game/SharedDefines.h
    +++ b/src/game/SharedDefines.h
    @@ -28,7 +28,6 @@
    #include "Platform/Define.h"
    #include

    -#define MANGOS
    #define CLASSIC

    enum Gender
    diff --git a/src/shared/Threading.cpp b/src/shared/Threading.cpp
    index 668aa43..bb7e21d 100644
    --- a/src/shared/Threading.cpp
    +++ b/src/shared/Threading.cpp
    @@ -191,7 +191,9 @@ void Thread::resume()

    ACE_THR_FUNC_RETURN Thread::ThreadTask(void* param)
    {
    - Runnable* _task = (Runnable*)param;
    + Runnable* _task = static_cast(param);
    + _task->incReference();
    +
    _task->run();

    // task execution complete, free referecne added at
    --
    2.0.1


    From 6d8d16c7b375708770949065c0f0d37d57196da4 Mon Sep 17 00:00:00 2001
    From: lfxgroove
    Date: Tue, 29 Jul 2014 12:58:48 +0000
    Subject: [PATCH 2/2] [Core] Revert part of last commit

    ---
    src/game/SharedDefines.h | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/src/game/SharedDefines.h b/src/game/SharedDefines.h
    index b58cafc..17fae55 100644
    --- a/src/game/SharedDefines.h
    +++ b/src/game/SharedDefines.h
    @@ -28,6 +28,9 @@
    #include "Platform/Define.h"
    #include

    +#ifndef MANGOS
    +#define MANGOS
    +#endif /* MANGOS */
    #define CLASSIC

    enum Gender
    --
    2.0.1
    [/code]

    You can apply it with git apply or git am. See [url]https://ariejan.net/2009/10/26/how-to-create-and-apply-a-patch-with-git/[/url] for some more info. Please reply back if it works.

  4. Hi there, would you be able to recompile with debugging info turned on and give it a go with valgrind as well please? To compile with debug info you would do something like:
    [code]
    cmake .. -DCMAKE_INSTALL_PREFIX=/la/la/bin -DDEBUG=1
    [/code]

    And to run it with valgrind you would do something like:
    [code]
    valgrind /path/to/mangosd
    [/code]

    Please copy the output that valgrind gives you as well as a normal run with debugging enabled to this thread and i should have something more to go on. Thanks!

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use