Cupcake

You didn't mention what rev. are you using and if you're using custom patches or not. Afaik HM works fine both on master and One, I didn't notice anything wrong with it, especially the problem you mentioned.

Make sure you compile the project as Release version and not Debug.

Is the same as in master, i'm sure it will get ported when someone has the time to do it.

Just wanted to mention that this bug is not present in One, maybe it will be easier to pinpoint the problem.

There are problems with some single mobs also, when you agro them they go through you and position themself behind you, so you constantly have to turn 180 degrees after they reach you in order to be able to attack them.And they are not rogues or w.e, just plain elementals or humanoids.

Well i looked at the Spell::CheckCast code but couldn't find any place that handles the removal of triggered auras, so maybe anyone with more experience can look into this. This is a major bug atm in One, i've seen players doing 2800 dps because of this bug ,which shouldn't be possible in 2.4.3. Anyway, until this gets fixed by MaNGOS standards, the patch i linked works with no problems.Btw seems svn didn't include the name of the function, all those custom cases are in void Aura::HandleAuraDummy(bool apply, bool Real) , in the // AT REMOVE else {...} block .

Problem solved, seems the .dbc files were corrupted, re-extracted them from a different source. Weird thing is that i didn't get any errors neither at extraction neither at server startup/runtime while having those corrupted dbc files. Was very hard to track down the problem. Second issue still remains valid.

MaNGOS One s1434 SD2 One s2353 TBCDB 1.2.0 -------------------------------- Just 2 of the Shattrath Flasks can be used and are displaying the tooltip correctly, the rest of them are displaying just the name of the item and no spell effects tooltip. Checked DB and all of them have the correct spellId assigned, so it's weird why some of them work and some don't. Flasks that are working: Shattrath Flask of Relentless Assault Shattrath Flask of Pure Death Flasks that don't display spell effect tooltip and can't be used: Shattrath Flask of Blinding Light Shattrath Flask of Fortification Shattrath Flask of Supreme Power Shattrath Flask of Mighty Restoration Also the error string for item use on wrong location is bugged, atm it's "You should be in %s.". Correct value should be "You should be in Tempest Keep, Serpentshrine Cavern, Caverns of Time: Mount Hyjal, Black Temple or the Sunwell Plateau." or something like that. Checked the code and the DB and didn't find any place where this string is handled.

Is not just a problem with stacking, the auras don't get removed if you remove the buff with right-click. IF you right-click to remove the buff from you, only the visual gets removed, stats are still buffed. And they are supposed to work just in end game instances, so if you leave the instance, the buff should get removed, but atm just the visual aura gets removed properly. So players can go inside SWP for example, use flask, get outside and still have the stats buffed.This patch solves both problems. Hope you get what i'm saying. PS: This problem was present in the last 2 years btw, since the aura system got changed, weird how no one reported it.

MaNGOS One s1434 SD2 One s2353 TBCDB 1.2.0 -------------------------------- Note: May apply to master also. -------------------------------- What bug does the patch fix? What features does the patch add? Fixes correct removal of auras applied by all the Shattrath Flasks. Atm when these flasks get removed, only the visual auras get removed, the auras responsible for the stats are still applied to the player. This can let players to stack multple flasks/elixirs at once. Also the Bloodberry Elixir has the same issue so it was included in the patch also. Patch here: http://pastebin.com/8st7Zv0L PS: I'm using svn, so maybe someone can convert it to git.

This is working fine in current rev. but the 45044 should be applied only if the player stays in range of the dynobj that is spawned. So if the player goes further than 5yds away, 45044 should be removed, if he comes back in the 5yds range then 45044 should be applied again. Idd, that's why i asked if the PersistentAura code can be customised with custom cases, something like: if (PersistentAura->GetID() == 45043) player->CastSpell(player,45044,true); I've looked around in the code and there's no functions to handle PersistentAura Dummy effects, like the simple Aura class has for example, just an Update() and a destructor i think.

Atm when you use the trinket 45042 and 45043 get casted, but not the final 45044 that is responsible with modifying player's stats. So you get just a fancy visual with nothing happening. I tried to add the 45044 to the Dummy Aura of 45042, and it works, but the buff isn't dependant on the location of the player.So in order for this to work correctly this must be done in the PersistentAura of 45043.

The spell from Shattrath Flask of Supreme Power : http://www.wowhead.com/spell=41611 So bassicaly players use that flask, and then drink another elixir and they get the bonus from both. And the bug appears just on all the Shattrath flasks, the normal ones work fine.

Don't know tbh, i'll look into it, but can it handle the in and out of range movement issue? Basically the spell should apply a small area buff that is available just for the player that casted the spell.

Bump for this since the Shattrath flasks are heavily abused atm on One.

Is there any way of handling the dummy effects for PersistentAreaAura? I'm asking because after all this time Shitfting Naaru Sliver trinket is still bugged. So basically on use the item should cast http://www.wowhead.com/spell=45042 and in turn that will trigger http://www.wowhead.com/spell=45043 wich has a Persistent Area Aura: Dummy effect that should cast http://www.wowhead.com/spell=45044 on player if he stays in a 5yd radius around the dynamic object that is spawned. I've seen that PersistentAreaAura is present in SpellAuras.cpp but didn't see any way of handling dummy effects on custom cases. Anyone has any idea for a workaround or this feature can't be implemented in the current core?

Not sure where to add it tbh, but here is where all the checks are done: http://pastebin.com/1uxK4ydv Check for the proc flag starts at line 8 and the check for the spell is handled starting with line 26. Now i know the last check works because if i add that hacky db fix the spell works fine so it has something to do with that if..else... statement after // Get EventProcFlag.

Confirmed.Just tested, works like a charm in One also. Btw why wasn't the aura removal part included?

Would it work on One as it is? Or would need extra modifications?

I'm asking because from my past experience the cpu load increase was nowhere near 0.3%, with vmaps enabled for azeroth the server would lag massively (dual-core with 4gb ram). But that was during the v1 of the vmaps so that's what i want to know: was the option removed because the new version is drastically optimised and has a way better performance or was it because another reason? The notes on the commit aren't very clear. Thanks.

Was thinking of disabling them on world for better performance, or is that not an issue anymore with v3?

Shattrath Flasks have the same issues. Even if you remove the buff or drink another flask/elixir after it , the bonuses from the Shattrath Flasks are still there.Same for the Blueberry Elixir from the IQD daily quest btw.

Seems vmap.ignoreMapIds is gone from the config files. Has the option been moved somewhere else or removed for good? If so, is there any other way to disable vmaps for certain maps? LE: Found that it was disabled in https://github.com/mangos-one/server/commit/0b5173da081655f30a1ac107a719158d05c59a88. Can someone explain why the option was removed? And if it's a good idea if i revert that patch for the latest One rev.

Backlash - http://old.wowhead.com/spell=34939 Nightfall - http://old.wowhead.com/spell=18095 The chance on proc part works well and maybe for an average player it would seem that the talents aren't bugged, but they are. The part that's bugged is obvious when for example you get the Nighfall buff when you allready casting Shadow Bolt and similar for Backlash when your casting Incinerate: when you finish casting the spells the buff is removed , and it shouldn't. You should get the instant cast and the buff removed on the next spell you cast not the current one you are casting, which has the full cast time. Hope you get what im saying

Idd , works like a charm on rev.11810 for me.