braindisconnect

@ike3 Ran into this on the recent commits on Linux and I am struggling a little with it: /mangos/src/game/playerbot/strategy/actions/TellReputationAction.cpp: In member function ‘virtual bool ai::TellReputationAction::Execute(ai::Event)’: /mangos/src/game/playerbot/strategy/actions/TellReputationAction.cpp:28: error: no matching function for call to ‘ReputationMgr::GetRank(const FactionEntry*&, bool)’ /mangos/src/game/ReputationMgr.h:128: note: candidates are: ReputationRank ReputationMgr::GetRank(const FactionEntry*) const

@Locario3 I cannot duplicate the issue. I can add toons from the same account and different accounts by toon name and by account name. You seeing anything in the logs?

@ike3 Hi Ike3, found a compile issue on Linux with your recent commits. In file included from src/game/playerbot/strategy/values/PositionValue.cpp:3: src/game/playerbot/strategy/values/PositionValue.h:9:33: error: macro "isset" requires 2 arguments, but only 1 given I suspect that isset is being used by an include for Linux somewhere in the build. I added the following to src/game/playerbot/strategy/values/PositionValue.h under the includes. #undef isset It compiled, but has been not tested yet. I have tested the previous fixes for Linux and they are good.

@ike3 I recompiled with the jan03 changes and ran into this: src/game/playerbot/strategy/actions/BankAction.h:18: error: extra qualification ‘ai::BankAction::’ on member ‘FindItemInBank’ I think this is the fix for Linux, I am just starting to learn C++, so not 100% sure. // Item* BankAction::FindItemInBank(uint32 ItemId); Item* FindItemInBank(uint32 ItemId); The code compiled, but I have not yet tested.

@ike3 Can't wait to test the new commits! Just a heads up, you have case typo in src/game/playerbot/strategy/generic/RunawayStrategy.cpp causing the build to fail on Linux. --- #include "RunAwayStrategy.h" +++ #include "RunawayStrategy.h"

Hi, Awesome mod, but there is one slight issue with the git merge. Looks like the repo has WoW Armory mod tied to it. It reflects the merge of WoW Armory into Mangos Core and then if you do not install the WoW Armory databases it prevents character deletion. Log Output: 2011-12-26 03:04:59 SQL: DELETE FROM armory_character_stats WHERE guid = 9 2011-12-26 03:04:59 SQL ERROR: Table 'characters.armory_character_stats' doesn't exist 2011-12-26 03:04:59 SQL: INSERT INTO armory_character_stats (guid, data, save_date) VALUES (9, '9 0 25 0... ~ 2011-12-26 03:04:59 SQL ERROR: Table 'characters.armory_character_stats' doesn't exist Other than that.. sweet mod! Tried backing out the patch after git'ing wow armory, but it fails. So it's either a create a new patch, a manual remove, or apply the characters.sql from wow armory to the characters db. I opted for the easier route and applied the characters.sql.