Casso

anyone can get guid with wpe pro. simply target and untarget a player...

Mangos Version: Mangos one: rev 1294 and rev 859 Custom Patches: - SD2 Version: - Database Name and Version : udb 0.10.5 How it SHOULD work: When i join rated arena, client will show skirmich icon and after battle i can't see rating changes, only damage and healing data. How it DOES work: When i join rated arena, client will show rated arena icon and after battle i can see rating changes, damage and healing data. Sorry for my english, i am from slovakia....

My solution. It works fine on mangos-one. Probably works on master too. --------------------------- src/game/ItemHandler.cpp --------------------------- index 402bdee..bef509c 100644 @@ -26,6 +26,7 @@ #include "Item.h" #include "UpdateData.h" #include "Chat.h" +#include "World.h" void WorldSession::HandleSplitItemOpcode( WorldPacket & recv_data ) { @@ -927,6 +928,11 @@ void WorldSession::HandleAutoBankItemOpcode(WorldPacket& recvPacket) if( !pItem ) return; + // WPE dupe protection + if(pItem->IsBag()) + if(!((Bag *)pItem)->IsEmpty()) + sWorld.BanAccount(BAN_CHARACTER, GetPlayerName(),0 ,"WPE Duplication Item","Casso's WPE Protection"); + ItemPosCountVec dest; uint8 msg = _player->CanBankItem( NULL_BAG, NULL_SLOT, dest, pItem, false ); if( msg != EQUIP_ERR_OK )

After learning rank 1, rank 2 is removed what add 2 TP. no idea why ... Learn Rank 1: -1 TP Remove Rank 2: +2 TP ------------------------------ Sum +1 TP

I have fixed problem with this talent (very hacky..): @@ -3507,11 +3507,14 @@ bool Player::resetTalents(bool no_cost) uint32 itrFirstId = sSpellMgr.GetFirstSpellInChain(itr->first); // unlearn if first rank is talent or learned by talent if (itrFirstId == talentInfo->RankID[j] || sSpellMgr.IsSpellLearnToSpell(talentInfo->RankID[j],itrFirstId)) { - removeSpell(itr->first,!IsPassiveSpell(itr->first)); + if(itr->first==37116 || itr->first==37117) // Primal Fury talent problem fix + removeSpell(itr->first,false); + else + removeSpell(itr->first,!IsPassiveSpell(itr->first)); itr = GetSpellMap().begin(); continue; } else ++itr;

I found original Improved Blizzard code in Unit::HandleOverrideClassScriptAuraProc case 836: // Improved Blizzard (Rank 1) { if (!procSpell || procSpell->SpellVisual!=9487) return false; triggered_spell_id = 12484; break; } case 988: // Improved Blizzard (Rank 2) { if (!procSpell || procSpell->SpellVisual!=9487) return false; triggered_spell_id = 12485; break; } case 989: // Improved Blizzard (Rank 3) { if (!procSpell || procSpell->SpellVisual!=9487) return false; triggered_spell_id = 12486; break; } This code has two problems: 1. SpellVisual is not 9487 (it is visual effect of area spell blizzard, not one tick) real SpellVisual of 1 tick is 9490 2. After change SpellVisual code talent procs, but debuff was casted to caster, not to victim, because area spell has no real target (pVictim = Caster)

What bug does the patch fix? What features does the patch add? This patch fixes two talents of mage class, Improved Blizzard and Improved Scorch For which repository revision was the patch created? most mangos-0.12 revs (probably master branch too, not tested) Who has been writing this patch? Casso Improved Blizzard: -------------------------- src/game/SpellEffects.cpp -------------------------- index 6f6f3d2..750ec71 100644 @@ -352,10 +352,21 @@ void Spell::EffectSchoolDMG(SpellEffectIndex effect_idx) // Arcane Blast if (m_spellInfo->SpellFamilyFlags & UI64LIT(0x20000000)) { m_caster->CastSpell(m_caster, 36032, true); } + + // Improved Blizzard talent + if (m_spellInfo->SpellFamilyFlags == UI64LIT(0x00080080) && m_spellInfo->SpellVisual == 9487 && m_caster->GetTypeId() == TYPEID_PLAYER) + { + if(m_caster->HasSpell(12488)) // Rank 3 + m_caster->CastSpell(unitTarget,12486,true); + else if(m_caster->HasSpell(12487)) // Rank 2 + m_caster->CastSpell(unitTarget,12485,true); + else if(m_caster->HasSpell(11185)) // Rank 1 + m_caster->CastSpell(unitTarget,12484,true); + } break; } case SPELLFAMILY_WARRIOR: { // Bloodthirst Improved scorch: -------------------------- src/game/SpellEffects.cpp -------------------------- index 750ec71..a730d77 100644 @@ -363,10 +363,25 @@ void Spell::EffectSchoolDMG(SpellEffectIndex effect_idx) else if(m_caster->HasSpell(12487)) m_caster->CastSpell(unitTarget,12485,true); else if(m_caster->HasSpell(11185)) m_caster->CastSpell(unitTarget,12484,true); } + + // Improved Scorch talent + if (m_spellInfo->SpellFamilyFlags == UI64LIT(0x00000010) && m_spellInfo->SpellIconID == 816 && m_caster->GetTypeId() == TYPEID_PLAYER) + { + if(m_caster->HasSpell(12873)) // Rank 3 - 100% + m_caster->CastSpell(unitTarget,22959,true); + else if(m_caster->HasSpell(12872)) // Rank 2 - 66% + { + if(urand(1,3) > 1) + m_caster->CastSpell(unitTarget,22959,true); + } + else if(m_caster->HasSpell(11095)) // Rank 1 - 33% + if(urand(1,3) > 2) + m_caster->CastSpell(unitTarget,22959,true); + } break; } case SPELLFAMILY_WARRIOR: { // Bloodthirst

What bug does the patch fix? What features does the patch add? This fix removes problem with delaying time of auto pointsdistribution. Every week the time of distribution is delayed by 0-10 minutes. Servers with 1 day distribution period has serious problem (1 week makes about 30-40 min. delay). For which repository revision was the patch created? Most master & 0.12 rev. Who has been writing this patch? Casso src/game/BattleGroundMgr.cpp @@ -1201,11 +1201,11 @@ void BattleGroundMgr::Update(uint32 diff) if (m_AutoDistributionTimeChecker < diff) { if (sWorld.GetGameTime() > m_NextAutoDistributionTime) { DistributeArenaPoints(); - m_NextAutoDistributionTime = time_t(sWorld.GetGameTime() + BATTLEGROUND_ARENA_POINT_DISTRIBUTION_DAY * sWorld.getConfig(CONFIG_UINT32_ARENA_AUTO_DISTRIBUTE_INTERVAL_DAYS)); + m_NextAutoDistributionTime += time_t(BATTLEGROUND_ARENA_POINT_DISTRIBUTION_DAY * sWorld.getConfig(CONFIG_UINT32_ARENA_AUTO_DISTRIBUTE_INTERVAL_DAYS)); CharacterDatabase.PExecute("UPDATE saved_variables SET NextArenaPointDistributionTime = '"UI64FMTD"'", uint64(m_NextAutoDistributionTime)); } m_AutoDistributionTimeChecker = 600000; // check 10 minutes } else (Sorry for my english, I am from slovakia)

Mangos Version: 0.12 s0108 (15.8.2010) Custom Patches: - SD2 Version: no SD2 Database Name and Version : Only default (empty) database How it DOES work: After learning this talent, and learning rank 2 of this spell, talent looks like not learned, and commonly, the talents with f.f.f. will be reseted after server restart or relog. for better imagine: P.S.: I have same problem with 8569 rev of 0.12 with SD2 and UDB database (Sorry my english, I'm from Slovakia)

I used your "first idea" but i get similar crashlog (Crashed at Object::BuildValuesUpdateBlockForPlayer+11C, but in call tree is Map::SendObjectUpdates+129 ...) I used hacky method with try/catch blocks in while loop of SendObjectUpdates, and it looks fine. Your idea replaced by my method: http://github.com/casso/Mysteria6928/commit/dd6e67a8b9b7e59d2a0007d9d8dfdb69fa53e6c1 My server: windows server 2003R2 x64 and mangos-0.12 rev 8569 Sorry my english, I'm from slovakia

I have same problem on my server (mangos-0.12 rev 8569). Solution: http://code.google.com/p/trinitycore/source/detail?r=9d4df97557036404db7516b4b3e0723d5fb816c9&path=/src/server/game/Entities/Player/Player.cpp

sorry my english, i'm from slovakia. I have downloaded newest 400 branch (http://github.com/mangos/mangos/commit/5ce8ab34aadf6c2c41e2191cd387b7fe07380913) but i can't compile it in vc90. I get hundreds errors from linker like this: 2>game.lib(ChatHandler.obj) : error LNK2001: unresolved external symbol "public: unsigned int const * __thiscall SpellEntry::GetEffectSpellClassMask(enum SpellEffectIndex)const " (?GetEffectSpellClassMask@SpellEntry@@QBEPBIW4SpellEffectIndex@@@Z) All errors are about SpellEntry methods. Is some file missing in rep or in vcproject? EDIT: Problem solved. "DBCStructure.cpp" was missing in vc90