Corfen

i think it ins´t working properly.

the spell does 710 damage over 15 seconds, 142 damage every 3 seconds.

the spell takes 42,9% os spell damage.

with 2011 of spell damage:

999 normal damage

1600-1800 at 25% (that is not 999x4)

it´s only me?

Damage is 4x tick (4x 999)

Some research...

http://wowmb.net/forums/f9/35729-maximizing_drain_soul/#post273407

http://www.wowhead.com/?spell=47855#comments:id=560606

( http://elitistjerks.com/f80/t38995-drain_soul_attempted_math/ )

http://elitistjerks.com/f80/t37900-dots_you_affliction_warlock_thread/#Drain_Soul

any news about the patch?

anyway, thaks for your work!

I do not have much free time for rewrite =/ (I have lots of school projects that I have to do )

What bug does the patch fix? What features does the patch add?

This patch would allow Warlock Shadowflame dot stacking with other Affliction dots.

For which repository revision was the patch created?

8272

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

I didn't find thread with this problem.

Who has been writing this patch? Please include either forum user names or email addresses.

Me (Corfen)

core patch:

diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp
index 7596e1a..1e5a9ad 100644
--- a/src/game/SpellMgr.cpp
+++ b/src/game/SpellMgr.cpp
@@ -1180,6 +1180,11 @@ bool SpellMgr::IsNoStackSpellDueToSpell(uint32 spellId_1, uint32 spellId_2) cons
                // Metamorphosis, diff effects
                if (spellInfo_1->SpellIconID == 3314 && spellInfo_2->SpellIconID == 3314)
                    return false;
+
+                // (Corruption or Unstable Affliction or Curse of Agony or Curse of Doom) and Shadowflame
+                if( (spellInfo_1->SpellIconID == 313 || spellInfo_1->SpellIconID == 2039 || spellInfo_1->SpellIconID == 544 || spellInfo_1->SpellIconID == 91) && (spellInfo_2->SpellIconID == 3317) ||
+                    (spellInfo_2->SpellIconID == 313 || spellInfo_2->SpellIconID == 2039 || spellInfo_2->SpellIconID == 544 || spellInfo_1->SpellIconID == 91) && (spellInfo_1->SpellIconID == 3317) )
+                    return false;
            }
            // Detect Invisibility and Mana Shield (multi-family check)
            if( spellInfo_1->Id == 132 && spellInfo_2->SpellIconID == 209 && spellInfo_2->SpellVisual[0] == 968 )

patch file

Tested and works. thx

What bug does the patch fix? What features does the patch add?

This patch would fix Acclimation arcane trigger.

(There was warlock's trigger 54373)

For which repository revision was the patch created?

8158

Who has been writing this patch? Please include either forum user names or email addresses.

Me (Corfen)

patch:

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index aa389f8..bcf5a59 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -6613,7 +6613,7 @@ bool Unit::HandleProcTriggerSpell(Unit *pVictim, uint32 damage, Aura* triggeredB
                        case SPELL_SCHOOL_NATURE: trigger_spell_id = 50488; break;
                        case SPELL_SCHOOL_FROST:  trigger_spell_id = 50485; break;
                        case SPELL_SCHOOL_SHADOW: trigger_spell_id = 50489; break;
-                        case SPELL_SCHOOL_ARCANE: trigger_spell_id = 54373; break;
+                        case SPELL_SCHOOL_ARCANE: trigger_spell_id = 50486; break;
                        default:
                            return false;
                    }

patch file

It works or not ?

Yes, it works.

Tested with rev8086, with 19354 health.

Without talent Demonic Aegis: Fel Armor hp regen is 387 (2% max hp).

With fixed Demonic Aegis is 503 (2,6% max hp).

Updated git diff for core 8082:

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index 7ccc4eb..db423ba 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -5997,16 +5997,30 @@ void Aura::PeriodicTick()
                return;

            // ignore non positive values (can be result apply spellmods to aura damage
-            uint32 amount = m_modifier.m_amount > 0 ? m_modifier.m_amount : 0;
+            float amount = m_modifier.m_amount > 0 ? m_modifier.m_amount : 0;
+            if (pCaster->getClass() == CLASS_WARLOCK)
+            {
+                switch (GetId())
+                {
+                case 28176:
+                case 28189:
+                case 47892:
+                case 47893: //Fel Armor bonus from Demonic Aegis
+                    if (m_target->HasAura(30145)) amount = 2.6;
+                    else if (m_target->HasAura(30144)) amount = 2.4;
+                    else if (m_target->HasAura(30143)) amount = 2.2;
+                    break;
+                default:
+                    break;
+                }
+            }

            uint32 pdamage;

            if(m_modifier.m_auraname==SPELL_AURA_OBS_MOD_HEALTH)
                pdamage = uint32(m_target->GetMaxHealth() * amount / 100);
            else
-                pdamage = amount;
-
-            pdamage = pCaster->SpellHealingBonus(m_target, GetSpellProto(), pdamage, DOT, GetStackAmount());
+                pdamage = pCaster->SpellHealingBonus(m_target, GetSpellProto(), amount, DOT, GetStackAmount());

            sLog.outDetail("PeriodicTick: %u (TypeId: %u) heal of %u (TypeId: %u) for %u health inflicted by %u",
                GUID_LOPART(GetCasterGUID()), GuidHigh2TypeId(GUID_HIPART(GetCasterGUID())), m_target->GetGUIDLow(), m_target->GetTypeId(), pdamage, GetId());

What bug does the patch fix? What features does the patch add?

This patch would fix Glyph of Life Tap.

For which repository revision was the patch created?

8052

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

No thread with this problem.

Who has been writing this patch? Please include either forum user names or email addresses.

Corfen.

Core patch:

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 4c1f8bd..04c17be 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -5147,6 +5147,12 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu
                    triggered_spell_id = 63106;
                    break;
                }
+                // Glyph of Life Tap
+                case 63320:
+                {
+                    triggered_spell_id = 63321;
+                    break;
+                }
            }
            break;
        }

and procflag:

INSERT INTO `spell_proc_event` VALUES
(63320, 0x00000000,  5, 0x00040000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0.000000, 0.000000,  0);

Patch Files

but what branch?

Master branch.

yes. so does this patch work? for me at the moment no...

I have rev8016 now and works.

[color=#000000][color=#007700]+                    if([/color][color=#0000bb]procSpell[/color][color=#007700]->[/color][color=#0000bb]SpellFamilyFlags [/color][color=#007700]& [/color][color=#0000bb]UI64LIT[/color][color=#007700]([/color][color=#0000bb]0x0000000000000002[/color][color=#007700]))[/color][/color]

spell_proc_event ?

[color=#000000][color=#007700]+                        [/color][color=#0000bb]target [/color][color=#007700]= [/color][color=#0000bb]this[/color][color=#007700];[/color][/color]

63106 has TARGET_SELF

Oh, thx, I forgot about it. Firts post updated.

What bug does the patch fix? What features does the patch add?

This patch fixes fear effects to stunned target.

Stunned target shouldn't be immune to fear effects.

For which repository revision was the patch created?

7936

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

I didn't find thread with this problem.

Who has been writing this patch? Please include either forum user names or email addresses.

Me (Corfen)

core patch:

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index e1a46f1..de733fe 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -8415,13 +8415,6 @@ bool Unit::IsImmunedToSpell(SpellEntry const* spellInfo)
    if (!spellInfo)
        return false;

-    //FIX ME this hack: don't get feared if stunned
-    if (spellInfo->Mechanic == MECHANIC_FEAR )
-    {
-        if ( hasUnitState(UNIT_STAT_STUNNED) )
-            return true;
-    }
-
    //TODO add spellEffect immunity checks!, player with flag in bg is imune to imunity buffs from other friendly players!
    //SpellImmuneList const& dispelList = m_spellImmune[iMMUNITY_EFFECT];

Patch file

What bug does the patch fix? What features does the patch add?

This patch would fix Pygmy Oil use effects.

For which repository revision was the patch created?

8052

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

No thread with this problem.

Who has been writing this patch? Please include either forum user names or email addresses.

Me (Corfen)

core patch:

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index b8fe5b4..6191a6f 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -2844,6 +2844,8 @@ void Aura::HandleAuraTransform(bool apply, bool Real)
                }
                // Murloc costume
                case 42365: m_target->SetDisplayId(21723); break;
+                // Pygmy Oil
+                case 53806: m_target->SetDisplayId(14973); break;
                default: break;
            }
        }
diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
index 6f49c82..8553d68 100644
--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -755,6 +755,21 @@ void Spell::EffectDummy(uint32 i)
                    m_caster->CastSpell(m_caster, spell_id, true, NULL);
                    return;
                }
+                case 53808:                                 // Pygmy Oil
+                {
+                    if(m_caster->GetTypeId() != TYPEID_PLAYER)
+                        return;
+                    uint32 spell_id = 0;
+                    uint32 roll = urand(0, 99);
+
+                    if(roll < 20)
+                        spell_id = 53806;                    // 20% for 10min Pygmified buff. (off-like chance unknown)
+                    else
+                        spell_id = 53805;                    // You feel a little smaller buff.
+
+                    m_caster->CastSpell(unitTarget,spell_id,true,NULL);
+                    return;
+                }
                case 17251:                                 // Spirit Healer Res
                {
                    if(!unitTarget || !m_originalCaster)
diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp
index 99e9806..e615faa 100644
--- a/src/game/SpellMgr.cpp
+++ b/src/game/SpellMgr.cpp
@@ -1190,6 +1190,11 @@ bool SpellMgr::IsNoStackSpellDueToSpell(uint32 spellId_1, uint32 spellId_2) cons
                        (spellInfo_2->Id == 8326 && spellInfo_1->Id == 20584) )
                         return false;

+                    // Pygmy Oil Smaller and Pygmified effect can't be stacked
+                    if( (spellInfo_1->Id == 53806 && spellInfo_2->Id == 53805) ||
+                        (spellInfo_2->Id == 53806 && spellInfo_1->Id == 53805) )
+                         return true;
+
                    break;
                }
                case SPELLFAMILY_WARRIOR:

Patch file

// edit: updated for rev 8052

What bug does the patch fix? What features does the patch add?

This patch would fix warlock Nether Protection effect stacking.

(Arcane proc stacks with shadow proc and fire and... etc)

For which repository revision was the patch created?

7791

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

No thread with this problem.

Who has been writing this patch? Please include either forum user names or email addresses.

Me (Corfen)

core patch:

diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp
index 7c72d2e..32b5b17 100644
--- a/src/game/SpellMgr.cpp
+++ b/src/game/SpellMgr.cpp
@@ -1287,6 +1287,9 @@ bool SpellMgr::IsNoStackSpellDueToSpell(uint32 spellId_1, uint32 spellId_2) cons
                if( (spellInfo_1->SpellIconID == 313 || spellInfo_1->SpellIconID == 2039) && (spellInfo_2->SpellIconID == 544  || spellInfo_2->SpellIconID == 91) ||
                    (spellInfo_2->SpellIconID == 313 || spellInfo_2->SpellIconID == 2039) && (spellInfo_1->SpellIconID == 544  || spellInfo_1->SpellIconID == 91) )
                    return false;
+                // Nether Protection effects
+                if( spellInfo_2->SpellIconID==1985 && spellInfo_1->SpellIconID==1985 && spellInfo_1->SpellVisual[0]==9750 )
+                    return false;
            }
            // Detect Invisibility and Mana Shield (multi-family check)
            if( spellInfo_1->Id == 132 && spellInfo_2->SpellIconID == 209 && spellInfo_2->SpellVisual[0] == 968 )

patch file

Keep in mind this change of 3.1

I know, it is only temporarily fix, until 3.1.0 comes out