Danstahr

It's my own research from offi servers.

I don't think the scale is linear... I found the behaviour of this spell quite logarithmic, starting somewhere about 600-700 damage. Check this graph : http://img180.imageshack.us/i/123pm.gif/

To make the boss a bit more challenging than shown upper, I used this formula :

Starting with aura trigger, 100 or 150 damage (normal/HC)

• * get distance between Loken and target
  * if the distance is lower than 1/3 y, modifier will be 3,(5) periode
  * calculate modifier as 1 + log1.16 (distance-1/3)
  * if the modifier is < 3.(5), set it to that value
  * final damage = input damage * modifier * 3 / 2
  

Yeah, this looks the way better. Thanks for your help with this, it's definitely smarter than my version. And back to your sorry - why? I don't see any wrong thing at your comment - you know the better solution, so you let me know - as I said, I'm open to new knowledge about spell system - and you definitely give me a big one. So I should (and I do) say thanks to you, not you "Sorry" to me .

I'll make a diff with our new version tomorow.

It's not working anyway, even with the DB edit. The only aura that triggers after casting PoH is Glyph of PoH. Serendipity still on 3 stacks...

I'm quite new to spell repairing, so I might not fix the bugs the best way. However, if I won't publish it, it won't be checked. And, as mentioned on the front page, "MaNGOS is an educational project". I found the Swiftmend spell quite similar (since it's also consuming another buff) and it's implemented this way, so I did the same with Serendipity.

Back to the topic, I did not find any dummy aura able to proc. Wowhead doesn't show any.

//Edit :

I've made it the way you've suggested, but the case event is never triggered (or at least not at the situation we're talking about)

What bug does the patch fix? What features does the patch add?

Nowdays, Serendipity isn't consumed by Prayer of Healing or Greater Heal. This patch fixes this.

For which repository revision was the patch created?

10179

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

No

Who has been writing this patch? Please include either forum user names or email addresses.

Maxxie and me

diff --git a/src/game/UnitAuraProcHandler.cpp b/src/game/UnitAuraProcHandler.cpp
index 8b6d563..6c7b9e6 100644
--- a/src/game/UnitAuraProcHandler.cpp
+++ b/src/game/UnitAuraProcHandler.cpp
@@ -3634,6 +3639,16 @@ bool Unit::HandleAddPctModifierAuraProc(Unit* /*pVictim*/, uint32 /*damage*/, Au
            }
            break;
        }
+        case SPELLFAMILY_PRIEST:
+        {
+            
+            if (spellInfo->SpellIconID == 2900) //Serendipity removal
+                {
+                    RemoveAurasDueToSpell(triggeredByAura->GetId());
+                    return true;
+                }
+        }
+
    }
    return true;
}

And the DB part

insert into `spell_proc_event` (`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMaskA0`, `SpellFamilyMaskA1`, `SpellFamilyMaskA2`, `SpellFamilyMaskB0`, `SpellFamilyMaskB1`, `SpellFamilyMaskB2`, `SpellFamilyMaskC0`, `SpellFamilyMaskC1`, `SpellFamilyMaskC2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `Cooldown`) values('63735','0','6','4608','0','0','0','0','0','0','0','0','0','0','0','100','0');

Well, I don't think so... With the newest revision of Mangos, I still don't recieve any mana for this glyph's ticks without the patch I've posted. The trigger appears in the combat log, but you gain no mana.

This is much more complicated then it could be.

Much smarter solution is to add the code below to EffectEnergize in SpellEffects.cpp

case 71132:                                         //Glyph of Shadow Word : Pain
    damage = m_caster->GetCreateMana() / 100;
    break;

What bug does the patch fix? What features does the patch add?

Added support for Glyph of Guardian Spirit (reset CD of GS if the target survives without consuming the GS)

For which repository revision was the patch created?

10148

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

No

Who has been writing this patch? Please include either forum user names or email addresses.

Me, Danstahr

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index bdef8e4..97ee619 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -7147,6 +7148,28 @@ void Aura::HandleSchoolAbsorb(bool apply, bool Real)
                }
            }
        }
+        //Glyph of Guardian Spirit
+        if (spellProto->Id == 47788)
+        {
+            if (!(m_removeMode == AURA_REMOVE_BY_EXPIRE))
+                return;
+            if (target->IsInWorld() && GetStackAmount()>0)
+            {
+                if (caster)
+                    if (caster->HasAura(63231))
+                    {
+                        ((Player*)caster)->RemoveSpellCooldown(47788,true); //server CD set
+                        ((Player*)caster)->AddSpellCooldown(47788,0,time(NULL)+60);
+                        WorldPacket data(SMSG_SPELL_COOLDOWN,8+1+4+4); //client CD set
+                        data << caster->GetGUID();
+                        data << uint8(0x0);
+                        data << spellProto->Id;
+                        data << uint32(60000);
+                        ((Player*)caster)->GetSession()->SendPacket(&data);
+                    }
+                        
+            }
+        }
    }
}

yeah, sure... I was just about to post this version here, my brain was off last night

first post updated

Uz muzes PM.

Flagy by mely byt nacteny z toho dumpu, me to funguje v pohode. Kdyztak mu nastav faction 35...

Cauves Kdyztak PM nebo mail, at tu nespamujem...

I'm from the Czech Republic.

Did you apply the SQL patches?

http://github.com/Tasssadar/Valhalla-Project-ScriptDev2/tree/master/sql/project_updates/

vsd153 - Mangos for your Mangos DB, ScriptDev2 for SD2 database

There is one of the trash mobs spawned by default, and it needs to recieve ID of the portal, or there's an undeclared variable and it crashes there.

Yes, replace yours (both cpp and h) and try to compile.

strange... I see no difference in these files. However, it fails to compile with yours and it works fine with my files.

Try to use my files - http://github.com/Danstahr/ScriptDev2/tree/master/include/

and let me know if it works.

Could you please upload your sc_grid_searchers.cpp and sc_grid_searchers.h somewhere? I'll take a look at that.

Hi,

you can find it in sc_grid_searchers.

http://github.com/Tasssadar/Valhalla-Project-ScriptDev2/commit/f3ae7aa37f8bfceb4dd50162fc4f97e81b5342e8#diff-0

The scripts use some additional commits in core and other SD2 files, so check all of my commits to prevent more errors.

I'll be very happy if you report me any bug you can find that I can improve the scripts.