Dashu_

Simple, does it's job, but I notced there is a nester query in there:

UPDATE npc_vendor SET sortOrder = sortOrder - 1 WHERE sortOrder > (SELECT sortOrder FROM npc_vendor WHERE entry='%u' AND item='%u' LIMIT 1) AND entry = '%u'

I'm not sure if mangos allows these. I could be wrong.

This is perfectly handled. Why shouldn't it be ? It's just advanced SQL, good and advanced SQL.

Useless post ?

So, no everything isn't runs on a single thread, socket (WorldSocket::Update()) is in other thread.

But, yes AchievementMgr::UpdateAchievementCriteria is in main thread and it's not difficult to create a thread to handle the achievement.

Thats it. There shouldn't be so muuch sync issues from making this function running on his own thread ? Looks like a good and easy speed up to me.

Does AchievementMgr::UpdateAchievementCriteria(AchievementCriteriaTypes, unsigned int, unsigned int, Unit*, unsigned int) runs on main thread ?

hmm reduce the numbers?