dreaming.moon

Hmm, to fix this, we have to understand why blizz assigned SPELL_DAMAGE_CLASS_NONE to the damage class of Lifebloom's and Haunt's healing parts rather than SPELL_DAMAGE_CLASS_MAGIC. Or why developers of mangos have chosen to skip the calculation of spell healing bonus and spell critical chance for this damage class. For now i see just two solutions: to add checks for these spells into Unit::isSpellCrit() and Unit::SpellHealingBonus() or to add calculation of spell critical chance and spell healing bonus into the part of Aura::HandleAuraDummy(). Both of them i see as quite hacky. I hope that any of you have any ideas, 'cause i have none left. :unsure:

Great, now we also know why the blooming part doesn't crit! Here's a code snippet that should provide a hint. (Unit.cpp, Unit::isSpellCrit function) bool Unit::isSpellCrit(Unit *pVictim, SpellEntry const *spellProto, SpellSchoolMask schoolMask, WeaponAttackType attackType) { // not critting spell if((spellProto->AttributesEx2 & SPELL_ATTR_EX2_CANT_CRIT)) return false; float crit_chance = 0.0f; switch(spellProto->DmgClass) { case SPELL_DAMAGE_CLASS_NONE: return false; case SPELL_DAMAGE_CLASS_MAGIC: ... Can you tell me how you've obtained the information about 33778's damage class? In other words where damage classes for spells are stored?

So here is the code that is risponsible for the "blooming" part of the spell. (SpellAuras.cpp, dummy auras handler) ... // final heal if(m_target->IsInWorld() && m_stackAmount > 0) { int32 amount = m_modifier.m_amount / m_stackAmount; m_target->CastCustomSpell(m_target, 33778, &amount, NULL, NULL, true, NULL, this, GetCasterGUID()); if (caster) { int32 returnmana = (GetSpellProto()->ManaCostPercentage * caster->GetCreateMana() / 100) * m_stackAmount / 2; caster->CastCustomSpell(caster, 64372, &returnmana, NULL, NULL, true, NULL, this, GetCasterGUID()); } } ... Is it just me or the amout should be multiplied rather than divided by the stack amount? :huh: (assuming that the blooming effect stacks)

That's true, i do agree, but that doesn't mean that that part of spell functionality has changed since then. I would highly appreciate if someone who can test it on offy will tell us how it works with current or any other recent patches. Ty. ^^ (Still, assuming that blizzard nerfed it couple of times, i don't think they will amplify it this way. It would be too overpowered in my opinion, but that's just my humble presumtion. )

Correct me if i'm wrong, but according to the wowwiki's patch notes and to wowhead's comments it works as intended.