Furt

Im getting conflicts with rev5949 in the spellffects.cpp

@@ -4370,6 +4375,9 @@
        if(pTarget->isInFlight())
                return;

+        if(pTarget->InBattleGround())
+                pTarget->LeaveBattleground();
+
        //homebind location is loaded always
        pTarget->TeleportTo(pTarget->m_homebindMapId,pTarget->m_homebindX,pTarget->m_homebindY,pTarget->m_homebindZ,pTarget->GetOrientation());

Ive tried to manually fix but with no luck.

Any advise on this would be much appreciated.

Edit: NVM it was something stupid on my part works fine

        if(pTarget->isInFlight())
               return;

       if(pTarget->InBattleGround())
               pTarget->LeaveBattleground();

       // homebind location is loaded always
       pTarget->TeleportTo(pTarget->m_homebindMapId,pTarget->m_homebindX,pTarget->m_homebindY,pTarget->m_homebindZ,pTarget->GetOrientation());

Love the patch its something me and my friend have been trying to figure out. IMO opvp patch and ahbot patch does not work together it crashes the server.

Crash log.

Revision: 5748
Date 5:5:2008. Time 6:17 
//=====================================================
*** Hardware ***
Processor: Intel(R) Pentium(R) D CPU 2.80GHz
Number Of Processors: 2
Physical Memory: 1046620 KB (Available: 182936 KB)
Commit Charge Limit: 2517164 KB

*** Operation System ***
Microsoft Windows XP Professional Service Pack 2 (Version 5.1, Build 2600)

//=====================================================
Exception code: C0000005 ACCESS_VIOLATION
Fault address:    004F0B6C 01:000EFB6C C:/mangos/mangosd.exe

Registers:
EAX:00000000
EBX:00000000
ECX:007C87F0
EDX:00150000
ESI:007C87F0
EDI:00000000
CS:EIP:001B:004F0B6C
SS:ESP:0023:0C82FDF8    EBP:0C82FEBC
DS:0023    ES:0023    FS:003B    GS:0000
Flags:00010202

Call stack:
Address     Frame         Function                SourceFile
004F0B6C    00000000    stdext::_Hash<stdext::_Hmap_traits<unsigned __int64,Player *,stdext::hash_compare<unsigned __int64,std::less<unsigned __int64> >,std::allocator<std::Pair<unsigned __int64 const ,Player *> >,0> >::lower_bound+C
004F8A28    00000000    stdext::hash_map<unsigned __int64,Player *,stdext::hash_compare<unsigned __int64,std::less<unsigned __int64> >,std::allocator<std::Pair<unsigned __int64 const ,Player *> > >::operator[]+18
00627B9D    00000000    AuctionHouseBot+7D
0050EC4D    00000000    World::Update+9D
00427AC2    00000000    WorldRunnable::run+52
00442EF5    00000000    ZThread::ThreadImpl::Dispatch+195
004432F2    00000000    ZThread::`anonymous namespace'::Launcher::run+32
004446DB    00000000    ZThread::ThreadOps::_dispatch+B
006C7D5E    00000000    _callthreadstartex+1B
006C7E03    00000000    _threadstartex+7F
7C80B683    00000000    GetModuleFileNameA+1B4
========================
Local Variables And Parameters

Call stack:
Address     Frame         Function                SourceFile
004F0B6C    00000000    stdext::_Hash<stdext::_Hmap_traits<unsigned __int64,Player *,stdext::hash_compare<unsigned __int64,std::less<unsigned __int64> >,std::allocator<std::Pair<unsigned __int64 const ,Player *> >,0> >::lower_bound+C
       Local    <user defined> '_Keyval'
       Local    <user defined> '_Where'

004F8A28    00000000    stdext::hash_map<unsigned __int64,Player *,stdext::hash_compare<unsigned __int64,std::less<unsigned __int64> >,std::allocator<std::Pair<unsigned __int64 const ,Player *> > >::operator[]+18
       Local    <user defined> '_Keyval'
       Local    <user defined> '_Where'

00627B9D    00000000    AuctionHouseBot+7D

0050EC4D    00000000    World::Update+9D
punting on symbol diff
       Local    <user defined> 'AuctionMap'
punting on symbol i
       Local    <user defined> 'next'
       Local    <user defined> 'next'
punting on symbol maxClientsNum

00427AC2    00000000    WorldRunnable::run+52

00442EF5    00000000    ZThread::ThreadImpl::Dispatch+195
       Local    <user defined> 'parent'
       Local    <user defined> 'impl'
       Local    <user defined> 'task'
       Local    <user defined> 'i'
       Local    <user defined> 'g'
       Local    <user defined> 'i'

004432F2    00000000    ZThread::`anonymous namespace'::Launcher::run+32

004446DB    00000000    ZThread::ThreadOps::_dispatch+B
punting on symbol arg

006C7D5E    00000000    _callthreadstartex+1B

006C7E03    00000000    _threadstartex+7F
punting on symbol ptd

7C80B683    00000000    GetModuleFileNameA+1B4

========================
Global Variables

Few things ive noticed is when say horde has captured halaa he can still click on the roost and fly over. This shouldnt happen he should only be able to destroy the roost. also the guard dont agro opposite faction.

Compiled with mangos rev5748