goldberg002

Mangos Version: 10003.

Custom Patches: No.

SD2 Version: 1703.

Database Name and Version : YTDB 549

Link: Deathbringer's Will.

How it SHOULD work:

Equip: Your attacks have a chance to awaken the powers of the races of Northrend, temporarily transforming you and increasing your combat capabilities for 30 sec.

How it DOES work:

Doesn't work.:mad:

Thank you.

Crash

Mangos: 9190

YTDB: 529

Revision: * * 9190 *
Date 16:1:2010. Time 12:41 
//=====================================================
*** Hardware ***
Processor: Intel(R) Core(TM) i7 CPU         920  @ 2.67GHz
Number Of Processors: 8
Physical Memory: 3135808 KB (Available: 1595588 KB)
Commit Charge Limit: 4194303 KB

*** Operation System ***
Windows Vista or Windows Server 2008 Professional (Version 6.0, Build 6000)

//=====================================================
Exception code: C0000005 ACCESS_VIOLATION
Fault address:  004716CC 01:000706CC E:\\I Need YOu\\SeRvEr\\mangosd.exe

Registers:
EAX:00000000
EBX:7F45DCD8
ECX:00000000
EDX:00000000
ESI:42008403
EDI:F1300014
CS:EIP:001B:004716CC
SS:ESP:0023:07DD22E0  EBP:07DD32F4
DS:0023  ES:0023  FS:003B  GS:0000
Flags:00010206

Call stack:
Address   Frame     Function      SourceFile
004716CC  00000000  Unit::GetTotem+4C
00471674  00000000  Unit::_GetTotem+14
0048A6E2  00000000  Unit::CallForAllControlledUnits<SetPvPHelper>+F2
004811F7  00000000  Unit::SetPvP+47
0069D2ED  00000000  Creature::UpdateEntry+51D
006A00EE  00000000  Creature::CreateFromProto+6E
0069E135  00000000  Creature::Create+A5
006A01F2  00000000  Creature::LoadFromDB+E2
0075BD67  00000000  LoadHelper<Creature>+147
0075B531  00000000  ObjectGridLoader::Visit+101
0075C45F  00000000  VisitorHelper<ObjectGridLoader,Creature>+F
0075C310  00000000  VisitorHelper<ObjectGridLoader,Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > >+10
0075C203  00000000  VisitorHelper<ObjectGridLoader,GameObject,TypeList<Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > > >+23
0075C140  00000000  VisitorHelper<ObjectGridLoader,TypeList<GameObject,TypeList<Creature,TypeList<DynamicObject,TypeList<Corpse,TypeNull> > > > >+10
0075B65C  00000000  ObjectGridLoader::Load+1C
0075B7A5  00000000  ObjectGridLoader::LoadN+F5
0049DFA9  00000000  Map::EnsureGridLoaded+109
0049DD62  00000000  Map::EnsureGridLoadedAtEnter+22
0049E1AF  00000000  Map::Add+8F
00877D99  00000000  WorldSession::HandlePlayerLogin+AD9
008772B0  00000000  CharacterHandler::HandlePlayerLoginCallback+80
0087B70D  00000000  MaNGOS::_IQueryCallback<MaNGOS::_Callback<CharacterHandler,QueryResult *,SqlQueryHolder *,void,void> >::Execute+2D
00891AF8  00000000  SqlResultQueue::Update+28
005FE655  00000000  World::UpdateResultQueue+15
005FD066  00000000  World::Update+796
004306BE  00000000  WorldRunnable::run+8E
0088F519  00000000  ACE_Based::Thread::ThreadTask+19
6E9A1B84  00000000  __WSAFDIsSet+FFFFFFFFFFFCCB4C
72953433  00000000  _endthreadex+44
729534C7  00000000  _endthreadex+D8
761C3833  00000000  BaseThreadInitThunk+12
778FA9BD  00000000  LdrInitializeThunk+4D

Call stack:
Address   Frame     Function      SourceFile
77920F34  00000000  KiFastSystemCallRet+0
761C7742  00000000  WaitForSingleObject+12
6E959C04  00000000  __WSAFDIsSet+FFFFFFFFFFF84BCC
6E9C64AA  00000000  __WSAFDIsSet+FFFFFFFFFFFF1472
6E9C266F  00000000  __WSAFDIsSet+FFFFFFFFFFFED637
00615C7A  00000000  WorldSocketMgr::Wait+4A
7370F9C4  00000000  0000:00000000 
7370F9C4  00000000  0000:00000000 
6C696146  00000000  

Not working still on 9183.

this is wrong, better is: Player's pet have 100% resilience from owner

return ((Player*)owner)->GetRatingBonusValue(cr) * 1.0f;

It's same effect. :rolleyes:

Thank you very much! :D

"Poison should proc only Mutilate" ???...

again to get your things right:

atm, SPELLS like Mutilate/Sinister Strike and some others DOESNT proc Poisons i.e. Wound/Instant..

Noo, I mean Posion must proc only for Mutilate not others spells... go check http://www.wowhead.com/?spell=48666

It say

Damage is increased by 20% against Poisoned targets.

This proc only for Mutilate... Is that true? :confused:

Poison should proc only Mutilate, isn't it? :confused:

The Problem is POISON doesnt proc on abilities...

I tested, and works!

Maybe your AttackPower is low...I had 3855 AttackPower on my Rogue.

Without POISON, I did 2635 Crit for Mainhand and 1974 Crit for OffHand by using Mutilate.

With POISON, I did 3529 Crit for MainHand and 2512 Crit for OffHand by using Mutilate.

My Talent is 43/5/23.

Well, the problem is ColdBlood doesn't make BOTH MainHand and OffHand Crit.

If you don't believe me, go test it with 3855 AttackPower.

So... I think these talents doesn't work Lethality and Dirty Deeds

It would get more damage for Mutilate. :rolleyes:

What is problem with this spell ?...

-check if "20% bonus damage against posioned targets"

tested and works fine.

Very good!!

aaarg..!

thats not what i meant

This Talent got intentionally changed, to prevent Powershifting:

For example, you depleted your energy and instead of waiting for it to regenerate, you could shift out and in Cat Form again, to have a chance of (20*rank)% to set your energy to 40. Simple trading of Mana for Energy.

How it works now (r9040):

You powershift and have a chance of 100% to set your energy to 20*rank. (effectively 100)

So, it just got worse...

How it should work:

Think of it, like Mana. You cant see it, but its still there and regenerating after the usual rules (5sec-Spirit-regen. ect)

Lets asume, you have 3/5 points in this talent ("[..]you keep up to 60 Energy[..]") and shift out of Cat Form to cast a spell with 2sec casttime, to shift into Cat Form immediately after.

with 60 Energy out:

- regenerates 20 Energy while casting

- now 80 Energy > 60 allowed by Talent => Energy is set to 60

with 40 Energy out:

- still 20 energy silently regenerated while casting the spell.

- now 60 Energy = 60 allowed by Talent => Final outcome is 60

with 20 Energy out:

- regenerates 20 Energy while out of Form

- now 40 Energy < 60 Allowed by Talent => Energy is left at 40

I hope, that made it clearer

Yes, I can confirm.

Hex = Fear, same effect :confused:

:lol::lol::lol:

Yeah, Hammer of Wrath gets double damage from code and again DB..

That is why I did remove these code..

* What bug does the patch fix? What features does the patch add?

This is my first patch :lol: , this patch will fix damage of this spell Hammer of Wrath.

* For which repository revision was the patch created?

8582

* Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

nope.

* Who has been writing this patch? Please include either forum user names or email addresses.

Me (Goldberg002)

Tested, and works fine.

Index: SpellEffects.cpp at void Spell::EffectSchoolDMG(uint32 effect_idx)

// Avenger's Shield ($m1+0.07*$SPH+0.07*$AP) - ranged sdb for future
else if (m_spellInfo->SpellFamilyFlags & UI64LIT(0x0000000000004000))
{
   float ap = m_caster->GetTotalAttackPowerValue(BASE_ATTACK);
   int32 holy = m_caster->SpellBaseDamageBonus(GetSpellSchoolMask(m_spellInfo)) +
                           m_caster->SpellBaseDamageBonusForVictim(GetSpellSchoolMask(m_spellInfo), unitTarget);
   damage += int32(ap * 0.07f) + int32(holy * 7 / 100);
}
-// Hammer of Wrath ($m1+0.15*$SPH+0.15*$AP) - ranged type sdb future fix
-else if (m_spellInfo->SpellFamilyFlags & UI64LIT(0x0000008000000000))
-{
-    float ap = m_caster->GetTotalAttackPowerValue(BASE_ATTACK);
-       int32 holy = m_caster->SpellBaseDamageBonus(GetSpellSchoolMask(m_spellInfo)) +
-                           m_caster->SpellBaseDamageBonusForVictim(GetSpellSchoolMask(m_spellInfo), unitTarget);
-    damage += int32(ap * 0.15f) + int32(holy * 15 / 100);
-}

Thank you. :cool:

If this patch is not good, delete this Thread.

oh really, I didnot know about that..sorry

When you freezes the target, your pet still attack the target when target freezing, it willl break the ice ... it should your pet stop attacking when you freezes the target.

Work for me

Thank you !

Thank you very much!!

Very Nice

MANGOS is The Best !!

Thank you very much !!!!

You Genius.

Good job!!

Thank You Very Much!