Grandres

MaNGOS rev. 11258

TARGET_RANDOM_NEARBY_DEST had stopped working since this commit https://github.com/mangos/mangos/commit/3008d0f92906aae05482041711f71f0592ca886c

For example function GetClosestCreatureWithEntry and spells like:

http://wowhead.com/spell=51441

http://wowhead.com/spell=51397l

http://wowhead.com/spell=51398

http://wowhead.com/spell=51400

http://wowhead.com/spell=51401

http://wowhead.com/spell=51402

http://wowhead.com/spell=51443

Dunno, that it is proper way.

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index c3f9389..bfb9de1 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -518,7 +518,6 @@ void Spell::FillTargetMap()
                    case TARGET_ALL_ENEMY_IN_AREA_CHANNELED:
                    case TARGET_ALL_FRIENDLY_UNITS_IN_AREA:
                    case TARGET_AREAEFFECT_GO_AROUND_DEST:
-                    case TARGET_RANDOM_NEARBY_DEST:
                        // triggered spells get dest point from default target set, ignore it
                        if (!(m_targets.m_targetMask & TARGET_FLAG_DEST_LOCATION) || m_IsTriggeredSpell)
                            if (WorldObject* castObject = GetAffectiveCasterObject())
@@ -541,6 +540,7 @@ void Spell::FillTargetMap()
                    case TARGET_POINT_AT_NW:
                    case TARGET_POINT_AT_SE:
                    case TARGET_POINT_AT_SW:
+                    case TARGET_RANDOM_NEARBY_DEST:
                        // need some target for processing
                        SetTargetMap(SpellEffectIndex(i), m_spellInfo->EffectImplicitTargetA[i], tmpUnitMap);
                        SetTargetMap(SpellEffectIndex(i), m_spellInfo->EffectImplicitTargetB[i], tmpUnitMap);

You have problem with SQLStorages.cpp. In my case it looks like:

const char CreatureInfosrcfmt[]="iiiiiiiiiisssiiiiiiiiiiifffiffiifiiiiiiiiiiffiiiiiiiiiiiiiiiiiiiisiiffliiiiiiiliiiiis";
const char CreatureInfodstfmt[]="iiiiiiiiiisssiiiiiiiiiiifffiffiifiiiiiiiiiiffiiiiiiiiiiiiiiiiiiiisiiffliiiiiiiliiiiii";
const char CreatureDataAddonInfofmt[]="iiibbiiiss";
const char CreatureModelfmt[]="iffbii";
const char CreatureInfoAddonInfofmt[]="iiibbiiiss";

UDB 0.12.0 (391) for MaNGOS 9999 with SD2 SQL for rev. 1702.

There is strange situation, when we train spells like: http://www.wowhead.com/spell=34768 , http://www.wowhead.com/spell=13820 , http://www.wowhead.com/spell=5785 after buying riding skill.

After training riding skill, we could'nt train our class mount, beacouse they are "Already known".

I think, that effects of spell has wrong sequence.

UDB 0.12.0 (390) for MaNGOS 9763 with SD2 SQL for rev. 1677.

I couldn't apply this patch:

$ git apply npc_transport.diff

error: patch failed: src/game/Level12.cpp:42

error: src/game/Level12.cpp: patch does not apply

error: patch failed: src/game/ObjectAccessor.h:94

error: src/game/ObjectAccessor.h: patch does not apply

error: patch failed: src/game/Transports.cpp:559

error: src/game/Transports.cpp: patch does not apply

error: patch failed src/game/Unit.cpp:48

error: src/game/Unit.cpp: patch does not apply

-- Heroic Training Dummy (31146)

UPDATE creature_template SET
AIName='EventAI'
WHERE entry=31146;

-- No movement and attack
DELETE FROM creature_ai_scripts WHERE id=3114601;
INSERT INTO creature_ai_scripts VALUES
(3114601,31146,4,0,100,0,0,0,0,0,21,0,0,0,20,0,0,0,0,0,0,0,'Heroic Training Dummy - No movement and attack');

Makes training dummy no attack, no movement.

Thank you for this patch. Works perfectly!

Here you've got some sql for:

- Nexus

- Drak'Tharon Keep.

- Ahn'kahet: The Old Kingdom

- Ingvar the Plunderer

http://pastebin.com/B3dieJP6

Is it possible to change faction/flag of creature after spellclick spells? For example quest http://www.wowhead.com/?quest=12629 after spellclik spell npc http://www.wowhead.com/?npc=29856 should attack us. I was trying with EventAI, but I didn't find out solution.

Yep, but I was suggested Mind Flay in my dbc, so as well it could be 0.286, thank for your advice

UDB 0.11.6 (387) for MaNGOS 9310 with SD2 SQL for rev. 1566.

Mind Sear has too low bonus from spellpower

Source:

http://wowhead.com/?spell=53023

http://www.wowwiki.com/Spell_power_coefficient

My results with spell power =1488

Before fix dmg:

400-624 (crit)

After fix dmg:

625-960 (crit)

 -- Mind Sear improve bonus from spellpower
UPDATE spell_bonus_data SET direct_bonus= 0.285678 WHERE entry =49821;

UDB 0.11.6 (387) for MaNGOS 9310 with SD2 SQL for rev. 1566.

http://www.wowhead.com/?item=23836

Goblin Rocket Launcher has bonus from spell power.

For example: (spellpower/dmg)

86 / ~1.3k

1235/ ~2.1k

1488/ ~2.5k

-- Goblin Rocket Launcher add missing record in spell bonus data
DELETE FROM spell_bonus_data WHERE entry=46567;
INSERT INTO spell_bonus_data VALUES
(46567,0,0,0,'Item - Goblin Rocket Launcher');

UDB 0.11.6 (387) for MaNGOS 9310 with SD2 SQL for rev. 1566.

Nitro Boosts doesn't work correct.

How it's working: We can use Nitro Boosts when we hold wsg's flag and we don't drop it.

How it should work: We drop wsg's flag when we use Nitro Boosts.

Nitro Boosts now make you drop PVP flags when used, as well as preventing you from picking them up while the effect is active.

source: http://www.worldofwarcraft.com/patchnotes/patch3p10.html