Janu

June 10, 2011

What bug does the patch fix? What features does the patch add?

Corrected typo which caused huge problems with item saving.

For which repository revision was the patch created?

Compatible with newest revision

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

Haven't seen any

Who has been writing this patch? Please include either forum user names or email addresses.

Me

Problem caused in:

https://github.com/mangos/mangos/commit/846f6943ec5c7b50a07aa244c85c4b34ad1f8344

Fix:

https://github.com/Iov/mangos/commit/e154d7067e532d64e5ed3bd944f2e5b5a2744d95

diff --git a/src/game/Item.cpp b/src/game/Item.cpp
index b5a3307..ca3ea19 100644
--- a/src/game/Item.cpp
+++ b/src/game/Item.cpp
@@ -516,7 +516,7 @@ bool Item::LoadFromDB(uint32 guidLow, Field* fields, ObjectGuid ownerGuid)

        std::ostringstream ss;
        for (uint16 i = 0; i < m_valuesCount; ++i)
-            ss << GetUInt32Value(i) << "";
+            ss << GetUInt32Value(i) << " ";

        stmt.addString(ss);
        stmt.addUInt32(GetOwnerGuid().GetCounter());

May 28, 2011

Hey,

everytime I try to start mangos as deamon I get following crash. Can anyone help or has an idea?

Program received signal SIGTERM, Terminated.
0x00007ffff5e1a42d in pause () at ../sysdeps/unix/syscall-template.S:82
82      ../sysdeps/unix/syscall-template.S: No such file or directory.
       in ../sysdeps/unix/syscall-template.S
(gdb) bt full
#0  0x00007ffff5e1a42d in pause () at ../sysdeps/unix/syscall-template.S:82
No locals.
#1  0x0000000000a87ccf in startDaemon (timeout=10) at /opt/mangos/source/mangos/src/shared/PosixDaemon.cpp:66
No locals.
#2  0x0000000000512897 in main (argc=<value optimised out>, argv=0x7fffffffe768) at /opt/mangos/source/mangos/src/mangosd/Main.cpp:182
       cfg_file = 0xb3f730 "/opt/mangos/server/test/etc/mangosd.conf"
       mc_cfg_file = 0xb3f700 "/opt/mangos/server/test/etc/mangchat.conf"
       cmd_opts = {argc_ = 3, argv_ = 0x7fffffffe768, optind = 3, opterr = 0, optarg = 0x0, optstring_ = 0x7ffff7fdbf88, long_only_ = 0, has_colon_ = 1, last_option_ = 0x7ffff7fdbf60, 
         nextchar_ = 0x0, optopt_ = 115, ordering_ = 2, nonopt_start_ = 3, nonopt_end_ = 3, long_option_ = 0x0, long_opts_ = {<ACE_Array_Base<ACE_Get_Opt::ACE_Get_Opt_Long_Option*>> = {
             max_size_ = 1, cur_size_ = 1, array_ = 0x7ffff7fafff0, allocator_ = 0x7ffff7ddb030}, <No data fields>}}
       serviceDaemonMode = 114 'r'
       option = <value optimised out>

Main.cpp:182 is startDemon();

PosixDaemon.cpp:66 is pause();

PS: We have custom use of MangChat with additional config file. You can see here:

mc_cfg_file = 0xb3f700 "/opt/mangos/server/test/etc/mangchat.conf"

May 27, 2011

Spell http://www.wowhead.com/spell=70728 is also working wrong (used by Hunter T10 http://old.wowhead.com/spell=70727)

SpellInfo:

Targets (20, 0) (TARGET_ALL_PARTY_AROUND_CASTER, NO_TARGET)

Fix:

https://github.com/Iov/mangos/commit/618b11d3a7b5ecc2c671c6ac8f8b883ac0e67751

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index b47049f..c0ca3ea 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -2482,8 +2482,9 @@ void Spell::SetTargetMap(SpellEffectIndex effIndex, uint32 targetMode, UnitList&
            switch(m_spellInfo->Id)
            {
                case 24604:                                 // Furious Howl
+                case 70728:                                 // Exploit Weakness
                {
-                    // from 3.1.0 only affect pet and owner
+                    // only affect pet and owner
                    targetUnitMap.push_back(m_caster);
                    if (Unit *owner = m_caster->GetOwner())
                        targetUnitMap.push_back(owner);

May 18, 2011

Hi again

There is a bug with VMaps concerning height calculation of Players.

How to reproduce:

1. log off while sitting on a mount

2. login again and unmount

3. try to walk through a door

You will see that you are not able to enter buildings.

Regards

Janu

May 18, 2011

We have a problem with this commit

70849 ist triggered and you have 2 charges, so everything seems fine.

_But_ if you cast one of the effected spells both charges are consumend

Anyone can confirm?

May 17, 2011

Hey all,

is it possible that all cooldowns start on beginning of the proc and not at the end?

As far as I know on official servers the cooldown is: spell duration + cooldown

Maybe someone has more detailed information concerning this or can confirm it?

Thanks and Regards

Janu

April 20, 2011

Any news here? No chance for recheck or revert?

April 19, 2011

No, I have no custom patches concerning this.

But in your last posted code the only thing affected is:

mechanic_immune = IMMUNE_TO_MOVEMENT_IMPAIRMENT_AND_LOSS_CONTROL_MASK;

Isn't this only to prevent stunning a player who already has aura of this spell?

And not for getting out of stun with using this spell?

April 18, 2011

This does not help in this case, because you cannot even cast spell 42292 if stunning spell has other mechanic then SPELL_AURA_MOD_STUN.

April 14, 2011

* What bug does the patch fix? What features does the patch add?

Prevents abilities that are "usable while stunned" being usable while in non-stun effects like Cyclone or Sap. With this patch the usability while stunned is restricted only to stun auras with mechanic stun.

Ah, I see And you are right, patch is wrong and needs revert.

April 14, 2011

I think this just special spell case:

"The warrior shouts, causing up to 5 enemies within 8 yards to cower in fear. The targeted enemy will be unable to move while cowering. Lasts 8 sec."

It is fear effect, but applies stun aura

April 14, 2011

Hm, I think this commit is wrong in some cases

spell http://www.wowhead.com/spell=51209 has:

Mechanic = 13 (MECHANIC_FREEZE)
Aura Id 12 (SPELL_AURA_MOD_STUN)

spell http://www.wowhead.com/spell=33786 has:

Mechanic = 18 (MECHANIC_BANISH)
Aura Id 12 (SPELL_AURA_MOD_STUN)

spell http://www.wowhead.com/spell=20066 has:

Mechanic = 14 (MECHANIC_KNOCKOUT)
Aura Id 12 (SPELL_AURA_MOD_STUN)

spell http://www.wowhead.com/spell=20511 has:

Mechanic = 5 (MECHANIC_FEAR)
Aura Id 12 (SPELL_AURA_MOD_STUN)

So in code "is_stun_mechanic = false;" will be set and using spells like http://www.wowhead.com/spell=59752 will be prevented

I do not know all special cases, but maybe we should only exclude spells 59752 and 42292 here.

if (!(*itr)->HasMechanic(MECHANIC_STUN) && spellInfo->Id != 59752 && spellInfo->Id != 42292)

or we should check more mechanics here (probably better):

rewritten code part of code in first post:

    if (unitflag & UNIT_FLAG_STUNNED)
   {
       // spell is usable while stunned
       if (m_spellInfo->AttributesEx5 & SPELL_ATTR_EX5_USABLE_WHILE_STUNNED)
       {
           bool is_stun_mechanic = true;
           Unit::AuraList const& stunAuras = m_caster->GetAurasByType(SPELL_AURA_MOD_STUN);
           for (Unit::AuraList::const_iterator itr = stunAuras.begin(); itr != stunAuras.end(); ++itr)
           // check spell mechanics
           if (!((*itr)->HasMechanic(MECHANIC_STUN)
              || (*itr)->HasMechanic(MECHANIC_FREEZE) 
              || (*itr)->HasMechanic(MECHANIC_BANISH)
              || (*itr)->HasMechanic(MECHANIC_KNOCKOUT)
              || (*itr)->HasMechanic(MECHANIC_FEAR)))
               {
                   is_stun_mechanic = false;
                   break;
               }
           if (!is_stun_mechanic)
               prevented_reason = SPELL_FAILED_STUNNED;
       }
       else
           prevented_reason = SPELL_FAILED_STUNNED;
   }

April 4, 2011

Got only one freeze in the last days: http://pastebin.com/raw.php?i=whEJKiqU (just ignore above table errors, was a fail of mine )

But as you can see, there is no error with fishing bobbers in log. Besides server does not freeze if you exactly try to reproduze it.

So this freeze seems to be fixed

Maybe somebody else has feedback regardings this?

March 30, 2011

Tried to reproduce freezes on our Test-Server, but everything seems fine If it occurs again on our Live-Server, I will contact you. But as I said it seems fine for now

March 30, 2011

I had no chance to test this yet, but I am sure to have some test-results at the evening

I will post feedback then

March 30, 2011

Hopefully fixed in [11298] by Ambal, thank you for this

Unconfirmed © Ambal

March 29, 2011

Hey guys,

I have noticed in our logs that in some case server freezes with vmaps. This seems to happen if player is fishing and disconnects from the server.

Crash-/Freeze-Log:

http://pastebin.com/raw.php?i=igTxekHr

You can notice these lines:

2011-03-28 18:05:20 ERROR:Delete Gameobject (Entry: 35591 Guid: 2502431) with SpellId 7731 LinkedGO 0 that lost references to owner Player Xearo (Guid: 54725) GO list. Crash possible later.

2011-03-28 18:07:38 ERROR:World Thread hangs, kicking out server!

And in Char.log:

2011-03-28 18:05:20 Account: 32121 (IP: 217.88.161.167) Logout Character:[Xearo] (guid: 54725)

Yes I have custom patches, but nothing concerning this or especially fishing/vmaps.

Because of this I will post the targeting line in Crash-Log:

  7 Thread 0x7fffc2ca3910 (LWP 32197)  MaNGOS::NearUsedPosDo::add (v=..., 
   c=<value optimised out>)
   at /home/mangos/source/mangos/src/game/Object.cpp:1888

void WorldObject::GetNearPoint(WorldObject const* searcher, float &x, float &y, float &z, float searcher_bounding_radius, float distance2d, float absAngle) const
{
   GetNearPoint2D(x, y, distance2d+searcher_bounding_radius, absAngle);
   z = GetPositionZ();

   // if detection disabled, return first point
   if(!sWorld.getConfig(CONFIG_BOOL_DETECT_POS_COLLISION))
   {
       if (searcher)
           searcher->UpdateAllowedPositionZ(x,y,z);        // update to LOS height if available
       else
           UpdateGroundPositionZ(x,y,z);  <<<<<<<<<<<<<<< FREEZE
       return;
   }

   // or remember first point
   float first_x = x;
   float first_y = y;
   bool first_los_conflict = false;                        // first point LOS problems

PS: Hm.. In my case DetectPosCollision = 1.. So i do not really understand how server can crash here. Maybe this codeblock above does not show the correct line where the freeze occurs

I hope this helps

Thanks and Regards

Janu

March 1, 2011

Okay, thank you

I think this can be closed then. If the problem should persist, I will do some more research.

February 28, 2011

First, thank you for reply.

I think we made a mistake and set deleteDate to "0" instead of really "NULL".. Could this cause the problem?

February 21, 2011

Hey guys..

I have a problem with the restore of chars which where deleted. The restore works fine, but after some time, I cannot give an exact time, the char dissapears out of the database. Maybe after server restart or relog. We do not use the newest revision, but maybe someone can confirm this or can give me a hint?

Thanks and Regards

Janu

February 16, 2011

Maybe this helps some people to build mangos on Ubuntu 9.10 karmic

PS: This is only the "standard" way with no modifications or something else, so ofc this can vary

Install CMake 2.8.0:
$ wget [url]https://launchpad.net/ubuntu/+archive/primary/+files/cmake_2.8.0.orig.tar.gz[/url]
$ gzip -d cmake_2.8.0.orig.tar.gz
$ tar -xvf cmake_2.8.0.orig.tar
$ cd cmake-2.8.0
$ ./configure
$ make
$ sudo make install
$ sudo ln -s /usr/local/bin/cmake /usr/bin
$ sudo ln -s /usr/local/bin/ctest /usr/bin
$ sudo ln -s /usr/local/bin/cpack /usr/bin

Compile Mangos:
$ git clone git://github.com/mangos/mangos.git
$ cd mangos
$ mkdir objdir
$ cd objdir
$ cmake ..
$ make
$ make install

December 8, 2010

Maybe any news here?

November 4, 2010

What's about your harddisks? Do you have SSDs?

As far as I know lags are mostly caused by low read-write speed of the SQL Server due to the harddisks

September 17, 2010

sry, browser sent this twice..

September 17, 2010

I think we all agree with the thing, that the main problem is not visual.

But in my opinion this visual bug also has to be fixed, cause the displaying is simply wrong in master now. Correct me if I am wrong

Sign In

Profiles

Bug Tracker

Wiki

Release Notes

Forums

Downloads

Blogs

Events

Posts posted by Janu

Contact Us

Repositories

Important Information