jorooo

All bugs still persist. Would be nice if this gets accepted

If only thread renaming was working would be great

Please mangos dev review or write coment thx

Yes, at least add the stacking part

Because in most cases is doesn't work for melee based spells, also we need to check only HOLY school spell damage, in db we can check only normal spell damage.

Maybe http://github.com/mangos/mangos/commit/e6e7363c7bc82abed91d7638b092e8b9d83c6fac messed something up?

Take you time ;]

Thanks for clarifying. Hopefully something can be done about it ;]

Rend and tear still does not work on rev. 8799.

Gladius? What is that?

Anyone has any idea why this feature does not work? Maybe the core does not send some opcodes in arena?

You are my hero

P.S. Why did you hardcode the coeficients? Why not use spell_bonus_data?

Yup, I have also seen 20k crits by 1900 SP player.

Here is some more info about the whole matchmaking stuff: http://blue.mmo-champion.com/11/14910422788-arena-matchmaking-system-faq.html

It's kinda sad that this is not yet implemented

Much needed patch, good job!

BUMP for devs?

This is now obsolete. Thanks ApoC!

The +heal bugs need spell_bonus_data set to 0. Others need procflags and cooldowns probably.

Even if I look into those, mangos devs are not interested in SQL updates, it won't get any attention anyway.

Hm, Im not sure.

I think most of the procs capable of critical hits are using player melee/spell crit chance :?

It was never added. Obviously, it is not worthy of dev's attention any more...

Thank you!

Enjoy!

We should really expand the table to cover all spells that benefit from SP/AP. Great patch!

It is forgotten/ignored QQ

Spell power coeficent should not be hardcoded! Must be from spell_bonus_data DB field.

Cheers! I'm very excited to see this implemented

I haven't tested it but, note that procs stack with buffs.

For example the 1000AP proc from the lvl80 epic trinket stacks with Blessing of Might, but most procs with same stat buff does not stack together, excluding 1H Weapon enchant procs, e.g. Berserking and Moongose.

Congratulation on the patch, this is important to work blizzlike so we can compare mangos and blizz expiriences more apropriately and eventually get closer to the original.