kamillys

Actually, aura 262 allows to igore some conditions, like combat, stance(warrior's Warbringer&Juggernaut and Sudden Death) or other states. Currently this aura is ignored, but IMO it's bad idea to implement it as "Finger of Frost aura", because it's more universal aura. I thought this aura is only for warrior, but mage's FoF also uses it.

Client side sees execute as usable, but server doesn't allow to cast it because enemy has more than 20% hp. IMO clients gets info from server in case of charge spell. I don't know what about FoF.

for CoH maybe should be done in different part, but at least Poison Bolt Volley and Curse of the Plaguebringer should be done here, because targets are random.

Glyph for CoH is also supported, because there is

Unit::AuraList const& mod = m_caster->GetAurasByType(SPELL_AURA_MOD_MAX_AFFECTED_TARGETS);

and other part for it.

==EDIT==

Yes, CoH shall be done like Wild Growth, because my patch forces to affect only nearest targets. In case of damaging spells it should be done like my patch. As of http://www.wowhead.com/?npc=15953 says: "Faerlina will launch a Poison Bolt Volley, hitting the 3 closest to her players" and some things cannot be done in SD2. It is possible to manually remove but this makes no sense. Although description of spell 28796 is bad

What bug does the patch fix? What features does the patch add?

Patch fixes number of targets for 4 spells: Curse of the Plaguebringer, Poison Bolt Volley and their heroic versions. It limits to 3 targets(as Wowhead says).

For which repository revision was the patch created?

damnit... 8280 as my DB says? Don't Remember

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

No/I didn't search.

Who has been writing this patch? Please include either forum user names or email addresses.

My idea how to fix and I wrote it.

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index 2d894fb..f97a6dd 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -1426,6 +1426,16 @@ void Spell::SetTargetMap(uint32 i,uint32 cur,UnitList& TagUnitMap)
        default:
            break;
    }
+    switch(m_spellInfo->Id)
+    {
+        case 29213: // Curse of the Plaguebringer
+        case 54835: // Curse of the Plaguebringer (H)
+        case 28796: // Poison Bolt Volley
+        case 54098: // Poison Bolt Volley (H)
+                unMaxTargets = 3;
+        default:
+            break;
+    }

    Unit::AuraList const& mod = m_caster->GetAurasByType(SPELL_AURA_MOD_MAX_AFFECTED_TARGETS);
    for(Unit::AuraList::const_iterator m = mod.begin(); m != mod.end(); ++m)

It can be done for every "custom" spell, including Circle of Healing etc.... I'm working on CoH, soon will be posted in new thread if not here.

==EDIT==

Addition for CoH(I don't have players for test it, but should work)

        //Circle of Healing + ranks
       case 34861: //1
       case 34863: //2
       case 34864: //3
       case 34865: //4
       case 34866: //5
       case 34868: //6
       case 34869: //7
               unMaxTargets = 5;

Anybody knows how cooldown on Raise Dead works on official servers?

mrelfire: it's not my patch and IMO RD isn't ready enough to submit in that section.

Hi!

I'd like to find some info about stacking spells, like Rend from 2 warriors or stacking 2 different spells from 1 caster and other cases... Where is it handled in MaNGOS?

http://wiki.udbforums.org/index.php/Spell.dbc

26 RecoveryTime

for Raise Dead = 0. For warrior's Shield Wall is 300000 = 5 mins. Maybe "trick" with overwriting with 3min for this value will work?

I don't have 3.2 DBC files, because my HD is too small. If you can check value in this value I'd be glad. Optionally if someone has older than 3.1 also could check For 3.0.9 it's the same cell.

void Spell::TakePower() should send to client state of current Runic Power instead of modyfing RP by 1, or there is other function that should send it?

I've checked 3.1.3 Spell.dbc file and there is NO COOLDOWN in DBC file. Holy Cow, hack required

I'm waiting for 3.2, maybe with new DBC files cooldown will be fixed...

There is bug in calculating damage: if some magic damage reductions (like spell 50267) is GREATER than normally damage done by spell, this spell causes a lots of damage. Propably it's declaration problem: if result is smaller than 0 it incerases by 216xxxxxxx(don't remember exacly dmg ) damage.

Example: Necrosis causes 100 dmg. Spell 50267 reduces by 146. Result should be 0, but is smaller than 0, but UINT is UNSIGNED! See wikipedia.org.

Not only ranks are doubled, but even players recived officer even nobody set it.

Some seals have coeffs in C++ code. Keep on mind that.

Judgements are spells in MaNGOS, at least IMO. Spells have bigger chance to miss.

"Although a Judgement cannot be dodged, parried, blocked, or "deflected", it has the same chance to miss its target as a melee attack." From wowwiki.com

SoV/SoC 5-stack effect: Furthermore, in patch 3.2, if the target already has a 5-stack of Seal of Vengeance debuffs, each subsequent melee swing made while this seal is in effect will inflict 33% of the attacker's Weapon Damage as Holy damage to the target (twice this amount if the melee swing crits). This extra holy damage cannot miss, be dodged, or be parried.

So it's added in 3.2. In 3.1.3 there is no that effect.

I've tested my pally, after some calculations(2081-770=base mana=1311, /4 it's 328). Thanks for info, i've suggested patches in this topic. In current Unit.cpp it's OK.

I've told that my brain was disabled

it's bug and very simple to fix, only to correct 0.15 to 0.25. In next revs it should be fixed. If somebody really needs a patch, because he/she can't find in Unit.cpp //Judgements of the wise and correct, I'll make it tommorow. It's 1 am in Poland and my brain is disabled

This talent works, but should be 0.25 instead of 0.15 in basepoints0 = GetCreateMana() * 0.15; because in 3.1.0 or newer it regen 25% mana instead of 15%.

DJNefast: Did you used any custom patches or just built from 320 git branch?

I'm talking about Vehicle Support patch, not fix for CHECK_PACKET_SIZE(). How to patch my MaNGOS source for supporting Vehicles?

I can't find any patch for current MaNGOS versions. Is there any more complete than from first post in this thread? In this thread I can't find anything usable.

Cooldown at 3.0.9(I don't remember rev) was OK, maybe something was messed up?

Any more details? Like what you try to disenchant?

Check CD in DB, probably there are some mistakes(5 min instead of 3?). My server is currently compiling(what-a-nice Gentoo ), it will take too long if I would check it.

Ghoul's stamina is scaling with owner's stamina, but i'm not sure is it correct because ghoul w/o Master of Ghouls has more hp than ghoul with talent. Please also check int and spirit. Armor is scaling as I remember.

http://github.com/guillaumederval/mangos_diff/blob/a46e7efad81e74cdb600517a3dfd92b15bfb9a93/mangos/patch_divers.diff

PROPABLY need update to current MaNGOS rev.(code is OK, but may be some lines down or up)

Found on github, including Death Pact.

In my opinion cooldown on Raise Dead in DB is invaild.

Stats for ghoul are missing, 22 str on any level, but ghoul's stamina scales with gear.

There are patches for Raise Dead, but cooldown is not working. Loading screen resets cooldown (on clear fresh-builded MaNGOS+UDB with no custom patches). Earlier(on 3.0.9) cooldown was OK. Any ideas how to fix CD on Raise Dead? It's only thing missing, except that DK's strength and agility(stamina is working, but needs to be checked) doesn't aeffect Ghoul, propably should be fixed in DB.

You can use scripts from this thread with little changes, they are working. Ghoul with Master of Ghouls is summoning by typing .cast 52150 in game, for 2min Ghoul there is simple fix in this thread.

Sorry if my English was bad