Oniryck

Okay, thanks for the info, and most important, thanks for commiting on One again

I have a question, what is the difference between InitWorldPvPArea() (witch is always true and not overridden) and InitOutdoorPvPArea() (which do not seem to be used in your patch, even if you create it) ? Edit: As I suspected, those two functions should have the same name, just an error in the patch. Again, great work, congratulations!

First, thanks for the great work on this. I'll try it. But, to start with a few thing : typo error in 006_mangos_language_worldPvP.sql line 24, should be a "," at the end. My post seems useless but I'll post if I notice anything else.

Wonderful job, you can be proud for sure, that is a great step in my opinion. I tested it on One without problem (not tested in deep but the main fonctionnalities work)

Great work, bravo!

This looks very nice work, but the links are dead Could you re-upload it Schmoozerd, for I can take a look at it ?

Yep, that's what I used. Thanks for notifying!

Hmm okay, I did it anyway my way and it works for me. More easier to manage creature that should not use pathfinding from the DB.

Exactly, and I guess, if he reconnects, get his characters in the state it was left in during that time (killed, for example)

npc_flag then ? or whatever is possible to set up from the database... Unit state can't be applied outside of a C++ script if I'm correct, that's what bothering me.

I have a question : why working with UNIT_STAT_IGNORE_PATHFINDING, instead of a unit flag ? A unit flag would allow us to choose from the database unit flag if we like or not a specific creature to avoid using MMAPS ? Is there a particular reason for using a "state" instead of a "flag" ?

S1233 might fix this ? Vladimir could confirm, but I'll se it anyway Many thanks to him and you Schmoozerd for your answer.

Yes that's the line. I'll test with updated SD2, and report if the problem continues.

Looks like it comes from an outdated SD2. I tried to update it before but GetScriptIdsCount() was not there yet I'll update SD2 and see if it's good now.

Hi, with one [s1232] I've got this crash : [New Thread 18195] [New Thread 18196] [New Thread 18197] [New Thread 18198] [New Thread 18185] [New Thread 18182] [New Thread 18186] [New Thread 18184] [New Thread 18199] Core was generated by `./mangosd'. Program terminated with signal 11, Segmentation fault. #0 0x00007f4df2c2bec2 in ItemQuestAccept (pPlayer=0xb108000, pItem=0x7f4de14d9440, pQuest=0x7f4df89cd300) at /mg/src/bindings/ScriptDev2/ScriptMgr.cpp:379 in /mg/src/bindings/ScriptDev2/ScriptMgr.cpp #0 0x00007f4df2c2bec2 in ItemQuestAccept (pPlayer=0xb108000, pItem=0x7f4de14d9440, pQuest=0x7f4df89cd300) at /mg/src/bindings/ScriptDev2/ScriptMgr.cpp:379 tmpscript = 0x40faae8 #1 0x00000000009b55f0 in ScriptMgr::OnQuestAccept (this=0x7f4e069efa00, pPlayer=0xb108000, pItem=0x7f4de14d9440, pQuest=0x7f4df89cd300) at /mg/src/game/ScriptMgr.cpp:1032 No locals. #2 0x0000000000b67d2a in WorldSession::HandleQuestgiverAcceptQuestOpcode (this=0x7f4df1271a80, recv_data=...) at /mg/src/game/QuestHandler.cpp:189 guid = {m_guid = 4611686018470399291} quest = 136 pObject = 0x7f4de14d9440 qInfo = 0x7f4df89cd300 #3 0x00000000008c110e in WorldSession::ExecuteOpcode (this=0x7f4df1271a80, opHandle=..., packet=0x7f4de0160bb0) at /mg/src/game/WorldSession.cpp:693 No locals. #4 0x00000000008bf38e in WorldSession::Update (this=0x7f4df1271a80, updater=...) at /mg/src/game/WorldSession.cpp:225 opHandle = @0x10e1940 packet = 0x7f4de0160bb0 #5 0x00000000007c8b5c in World::UpdateSessions (this=0x7f4e069f7900, diff=27) at /mg/src/game/World.cpp:2310 pSession = 0x7f4df1271a80 updater = {<PacketFilter> = {_vptr.PacketFilter = 0xcda230, m_pSession = 0x7f4df1271a80}, <No data fields>} itr = {<std::tr1::__detail::_Hashtable_iterator_base<std::pair<unsigned int const, WorldSession*>, false>> = {_M_cur_node = 0x7f4de7da2620, _M_cur_bucket = 0x7f4deaa41330}, <No data fields>} next = {<std::tr1::__detail::_Hashtable_iterator_base<std::pair<unsigned int const, WorldSession*>, false>> = {_M_cur_node = 0x7f4de3188d00, _M_cur_bucket = 0x7f4deaa41330}, <No data fields>} sess = 0x7f4e069f7900 #6 0x00000000007c7481 in World::Update (this=0x7f4e069f7900, diff=27) at /mg/src/game/World.cpp:1860 No locals. #7 0x00000000007b7518 in WorldRunnable::run (this=0x7f4df30ed000) at /mg/src/mangosd/WorldRunnable.cpp:60 diff = 27 realCurrTime = 5158827 realPrevTime = 5158800 prevSleepTime = 26 #8 0x0000000000c190fd in ACE_Based::Thread::ThreadTask (param=0x7f4df30ed000) at /mg/src/shared/Threading.cpp:187 _task = 0x7f4df30ed000 #9 0x00007f4e04874971 in start_thread () from /lib/libpthread.so.0 No symbol table info available. #10 0x00007f4e045d092d in clone () from /lib/libc.so.6 No symbol table info available. #11 0x0000000000000000 in ?? () No symbol table info available. the line in scriptmgr.cpp being: MANGOS_DLL_EXPORT bool ItemQuestAccept(Player* pPlayer, Item* pItem, Quest const* pQuest) { Script *tmpscript = m_scripts[pItem->GetProto()->ScriptId]; if (!tmpscript || !tmpscript->pQuestAcceptItem) return false; pPlayer->PlayerTalkClass->ClearMenus(); return tmpscript->pQuestAcceptItem(pPlayer, pItem, pQuest); } This code is from SD2 bug since only my core was modified since I have this crash, I think it's a core issue, so I posted here for help. I've seen there was some problem with quest start, so I guess this is a problem from backporting ? Anyway I'm probably wrong so if it's a SD2 compatibility with mangos One issue, sorry ^^'