redcore

I'm not sure but it seems to replace GameObject* flag = HashMapHolder<GameObject>::Find(m_CapturePoint); to GameObject* flag = GetGameObject(m_CapturePoint); in every line it appears to. Am I correct?

I have success with this patch on latest mangos build. But one issue I got with triggers which are hostile and decrease player by 1 hp. Does someone know which flags are incorrect for trigger creatures?

As SVN assigns revision numbers sequentially (starting from 1) even very old projects such as Mozilla have short unique revision numbers (Mozilla is only up to 6 digits in length). Many users find this convenient when entering revisions for historical research purposes. They also find this number easy to embed into their product, supposedly making it easy to determine which sources were used to create a particular executable. However since the revision number is global to the entire repository, including all branches, there is still a question of which branch the revision number corresponds to. Unless the last committed revision is recorded. Since revisions are global for a repository, the last committed revision makes it possible to determine which branch was used. As Git uses a SHA1 to uniquely identify a commit each specific revision can only be described by a 40 character hexadecimal string, however this string not only identifies the revision but also the branch it came from. In practice the first 8 characters tends to be unique for a project, however most users try to not rely on this over the long term. Rather than embedding long commit SHA1s into executables we have to generate a uniquely named tag. This is an additional step, but a simple one. But may inacceptable by devs and others.

Thank you for such a great work! Just wonder if there is SVN at assembla like one for your arena patch?

+1 for SVN My console spamed due to this bug.

Hello, I want to run second realm. I have to run second worldd process but what DB shoul I run. I thought I need only characters db newly created. Is it true? Does it work if I run second process connecting to the same mangos and realmd db? Is there any perfomance caveats?

Doh! My fault, I'm sorry. I forgot -R before reapply.

5992 still conflicting. Here is update: Index: src/game/SpellAuras.cpp =================================================================== --- src/game/SpellAuras.cpp (revision 5992) +++ src/game/SpellAuras.cpp (working copy) @@ -42,6 +42,8 @@ #include "TargetedMovementGenerator.h" #include "Formulas.h" #include "BattleGround.h" +#include "OutdoorPvP.h" +#include "OutdoorPvPMgr.h" #include "CreatureAI.h" #define NULL_AURA_SLOT 0xFF @@ -3175,10 +3177,18 @@ { if(apply) { - // drop flag at stealth in bg - if(Real && m_target->GetTypeId()==TYPEID_PLAYER && ((Player*)m_target)->InBattleGround()) - if(BattleGround *bg = ((Player*)m_target)->GetBattleGround()) - bg->EventPlayerDroppedFlag((Player*)m_target); + if(Real && m_target->GetTypeId()==TYPEID_PLAYER) + { + // drop flag at stealth in bg + if(((Player*)m_target)->InBattleGround()) + { + if(BattleGround *bg = ((Player*)m_target)->GetBattleGround()) + bg->EventPlayerDroppedFlag((Player*)m_target); + } + // remove player from the objective's active player count at stealth + if(OutdoorPvP * pvp = ((Player*)m_target)->GetOutdoorPvP()) + pvp->HandlePlayerActivityChanged((Player*)m_target); + } // only at real aura add if(Real) @@ -3219,7 +3229,11 @@ m_target->SetVisibility(VISIBILITY_ON); if(m_target->GetTypeId() == TYPEID_PLAYER) + { + if(OutdoorPvP * pvp = ((Player*)m_target)->GetOutdoorPvP()) + pvp->HandlePlayerActivityChanged((Player*)m_target); m_target->SendUpdateToPlayer((Player*)m_target); + } } } } @@ -3252,6 +3266,9 @@ { // apply glow vision m_target->SetFlag(PLAYER_FIELD_BYTES2,PLAYER_FIELD_BYTE2_INVISIBILITY_GLOW); + // remove player from the objective's active player count at invisibility + if(OutdoorPvP * pvp = ((Player*)m_target)->GetOutdoorPvP()) + pvp->HandlePlayerActivityChanged((Player*)m_target); // drop flag at invisible in bg if(((Player*)m_target)->InBattleGround()) @@ -3289,7 +3306,12 @@ { m_target->SetVisibility(VISIBILITY_ON); if(m_target->GetTypeId() == TYPEID_PLAYER) + { + if(OutdoorPvP * pvp = ((Player*)m_target)->GetOutdoorPvP()) + pvp->HandlePlayerActivityChanged((Player*)m_target); + m_target->SendUpdateToPlayer((Player*)m_target); + } } } } @@ -3631,6 +3653,8 @@ } } } + else + sOutdoorPvPMgr.HandleDropFlag((Player*)m_target,GetSpellProto()->Id); } }

Solved by deleting conflicting records. Thank you. Any updates for 5990+ (got some conflicts while merging)? Merge conflicts caused recent updates in BattleGround.cpp: http://www.mangosproject.org/forum/index.php?showtopic=24286

Patched revision 5979. Not sure if this issue OPvP related but any advice please. After patching with this patch I have the following SQL errors. Anyway how to safely clean it up? SQL: INSERT INTO gameobject VALUES ( 60839, 182106, 0, 1, 2569.6, -4772.93, 115.399, 2.72271, 0, 0, 0.978148, 0.207912, 0, 100, 1, 0) SQL ERROR: Duplicate entry '182106-0-2569.6--4772.93-115.399' for key 2 SQL: INSERT INTO gameobject VALUES ( 60841, 182106, 0, 1, 2992.63, -3022.95, 125.593, 3.03687, 0, 0, 0.99863, 0.052336, 0, 100, 1, 0) SQL ERROR: Duplicate entry '182106-0-2992.63--3022.95-125.593' for key 2 SQL: INSERT INTO gameobject VALUES ( 60843, 182106, 0, 1, 1838.42, -3703.56, 167.713, 0.890118, 0, 0, 0.430511, 0.902585, 0, 100, 1, 0) SQL ERROR: Duplicate entry '182106-0-1838.42--3703.56-167.713' for key 2 SQL: INSERT INTO gameobject VALUES ( 60845, 182106, 0, 1, 3148.17, -4365.51, 145.029, 1.53589, 0, 0, 0.694658, 0.71934, 0, 100, 1, 0) SQL ERROR: Duplicate entry '182106-0-3148.17--4365.51-145.029' for key 2

This patch fixes small typo in build environment on linux. This makes possible to pass --sysconfdir=DIR option to configure script to set system config directory. Index: src/shared/SystemConfig.h.in =================================================================== --- src/shared/SystemConfig.h.in (revision 5961) +++ src/shared/SystemConfig.h.in (working copy) @@ -49,8 +49,8 @@ # define _REALMD_CONFIG "realmd.conf" #else # define _FULLVERSION "/" _VERSION " (Unix)" -# define _MANGOSD_CONFIG "@prefix@/etc/mangosd.conf" -# define _REALMD_CONFIG "@prefix@/etc/realmd.conf" +# define _MANGOSD_CONFIG "@sysconfdir@/mangosd.conf" +# define _REALMD_CONFIG "@sysconfdir@/realmd.conf" #endif #define DEFAULT_PLAYER_LIMIT 100