sinaka

*bump* is it complete wrong done? or did just no one read it ^^

i think this one can not be managed in DB because, as you also said, there is just a proc flag for health drop below 20%, so i think it has to be done in core

anyone reviewed this patch?

because in 9773 the spell http://www.wowhead.com/spell=51915 is still bugged, though it doesn't revive the player

Mangos Version: 9773

Custom Patches: none

SD2 Version: 1677

Database Name and Version : UDB 0.12.0 + Updatepacks 389,390

How it SHOULD work: The spell should only trigger if players health is below 35%.

How it DOES work: Sometimes it also triggers if player has health over 35%, sometimes 70% or more.

Spell: http://www.wowhead.com/spell=52420

Item: http://www.wowhead.com/item=38674

with this patch (maybe hack) it gets fixed i'll post it in patch-section

diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
index 43c1ccd..86b6cf5 100644
--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -6704,6 +6704,16 @@ void Spell::EffectReputation(SpellEffectIndex eff_idx)
    int32  rep_change = m_currentBasePoints[eff_idx];

    uint32 faction_id = m_spellInfo->EffectMiscValue[eff_idx];
+    switch(m_spellInfo->Id)
+    {
+        case 69757:
+        case 61311:
+        case 61308:
+        case 61306: 
+        case 61312:
+            rep_change *= 1.3;
+            break;
+    }

    FactionEntry const* factionEntry = sFactionStore.LookupEntry(faction_id);

Mangos Version: 9737

Custom Patches: none

SD2 Version: 1675

Database Name and Version : UDB 0.12.0 + Updatepack 389

How it SHOULD work: Wenn you skill the talents "Will of the Necropolis" or "Blood Gorged" you sometimes get additional talent points. When you click the first rank of "Will of the Necropolis" you get 2 additional talent points and none is removed. The same with Blood Gorged. You get 4 additional talent points when skilling the first rank.

How it DOES work: You shouldn't get additional talent points when skilling these talents.

The problem occures not everytime, but sometimes. We do further research and as soon as we know a way when it occures on 100% chance, i'll post it here.

Spells:

// Will of the Necropolis

49189

50149

50150

// Blood Gorged

61154

61155

61156

61157

61158

this is a DB issue i think and you should ask at your db-developers forum

i think here: http://github.com/mangos/mangos/blob/803356e63d04e19c679680cb95cd246a65ab3b33/sql/updates/8549_03_mangos_battleground_events.sql is the fix for it... there IS an entry for that... so you might have forgotten to apply the sqls from git?

no problem had this on my server and wanted to mention it here

there also needs to be a check for stats.rating... if the rating is 0 and a teams looses, there is a problem...

stats.rating is uint32 if you subtract some number "x" bigger than 0 from 0 you dont get -x you get 4294967296 - x

so there has to be a check that nothing more than the amount of stats.rating itself gets substracted from stats.rating otherwise the teams gets a pretty nice rating ^^