[Patch][9030] Arcane damaging spells remove Arcane Blast debuff

[Maxxie]

What bug does the patch fix? What features does the patch add?

It removes the Arcane Blast debuff from the caster when he casts another arcane damaging spell.

For which repository revision was the patch created?

7499

Git: http://github.com/dragonshard/mangos/commit/8dbbc7b780a100aa699874de7ecdbab01468b706

[benemorius]

A most welcome improvement, though not quite official. The debuff should be removed upon casting any damage arcane spell. As it is, the patch removes the debuff when an arcane spell does damage rather than when the arcane spell is actually cast.

This also brings to my attention that the debuff doesn't appear to be stacking properly. I'm new to the project and haven't yet delved in to the code that brings spells and buffs to life, so I don't know whether there's a fundamental reason for that to remain unimplemented.

[benemorius]

As I said I don't know my way around this code yet, but this seems more appropriate.

---
src/game/Spell.cpp |    4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index 4eb296c..9ade160 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -2415,6 +2415,10 @@ void Spell::cast(bool skipCheck)
        {
            if (m_spellInfo->SpellFamilyFlags&0x0000008000000000LL)    // Ice Block
                m_preCastSpell = 41425;                                // Hypothermia
+            else if(m_spellInfo->SchoolMask & SPELL_SCHOOL_MASK_ARCANE)
+            {
+                m_caster->RemoveAurasDueToSpell(36032);
+            }
            break;
        }
        case SPELLFAMILY_PRIEST:
--

[Maxxie]

Well, if it's on spellcast then your're right... Just be sure to exclude Arcane blast from the spells that should remove the debuff

EDIT: you should check if it's an harmful spell too

[Tassader2]

Trouble is that mangos (incorrectly) calculates spell damage (including bonuses) when damage is dealt. Therefore of you remove arcane blast aura on spellcast, spells with travel time (a.barrage, a.missiles) will not benefit from it at all. If you remove aura on when spell deals damage, only first missile of arcane missiles spell will get the bonus.

I think first damage calculation of spells need to be changed so all modifiers from caster are taken at spell cast.

[Edoz]

nope because some triggers trigger at spell hit or resist...

[Tassader2]

nope because some triggers trigger at spell hit or resist...

I don't understand, can you give an example?

[VladimirMangos]

In [9030]. Thank you

[KAPATEJIb]

there is a bug, arcane blast debuff (36032) not removed after spell http://www.wowhead.com/?spell=5143 and ranks cast, i think it's because this spell have SPELL_AURA_PERIODIC_TRIGGER_SPELL, but we do check in EffectSchoolDMG (for some reasons this check won't affect on triggered spells), maybe need to add same check in his function?

[pasdVn]

There is a general problem with this implemetation: The Buff is removed before the damage calculation. Normally it should be removed afterwards (like spellmods). I wrote a hacky fix some days ago^^: http://github.com/pasdVn/mangos/commit/e4ff2c347c1b47388b3e4fd4a8bb963f17af96fd

[Revils]

why not something like this?

@@ -6022,10 +6022,22 @@ void Aura::HandleSpellSpecificBoosts(bool apply)
                    }
                }
                else
                    return;
            }
+            else if (m_spellProto->SpellFamilyFlags & UI64LIT(0x0000000000000800)) // Arcane Missile
+            {
+                if (!apply && (m_removeMode == AURA_REMOVE_BY_DEFAULT))
+                {            
+                    if (Unit* caster = GetCaster())
+                        caster->RemoveAurasDueToSpell(36032); // Arcane Blast debuff
+                    else
+                        return;
+                }
+                else
+                    return;
+            }

            switch(GetId())
            {
                case 11129:                                 // Combustion (remove triggered aura stack)
                {