[7777] Warlock - Nether Protection

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

This patch would fix warlock Nether Protection, now it proc from all magic schools (include holy)

http://www.wowhead.com/?spell=30302

For which repository revision was the patch created?

7694

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/viewtopic.php?id=7099

Who has been writing this patch? Please include either forum user names or email addresses.

Me (Corfen)

core patch:

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 7b38fde..149be10 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -6208,8 +6208,8 @@ bool Unit::HandleProcTriggerSpell(Unit *pVictim, uint32 damage, Aura* triggeredB
                    switch(GetFirstSchoolInMask(GetSpellSchoolMask(procSpell)))
                    {
                        case SPELL_SCHOOL_NORMAL:
-                        case SPELL_SCHOOL_HOLY:
                            return false;                   // ignore
+                        case SPELL_SCHOOL_HOLY:   trigger_spell_id = 54370; break;
                        case SPELL_SCHOOL_FIRE:   trigger_spell_id = 54371; break;
                        case SPELL_SCHOOL_NATURE: trigger_spell_id = 54375; break;
                        case SPELL_SCHOOL_FROST:  trigger_spell_id = 54372; break;

SQL Spell proc event, SchoolMask fix:

DELETE FROM `spell_proc_event` WHERE entry IN (30299,30301,30302);
INSERT INTO `spell_proc_event` VALUES
(30299, 0x0000007E,  0, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0.000000, 0.000000,  0);
INSERT INTO `spell_proc_event` VALUES
(30301, 0x0000007E,  0, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0.000000, 0.000000,  0);
INSERT INTO `spell_proc_event` VALUES
(30302, 0x0000007E,  0, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0.000000, 0.000000,  0);

patch + sql file

[Adalbert]

bump

This stuff is realy needed by destruction warlocks

[morderek]

wow this patch is very important for my warlock:lol:

[ApoC]

Applied in [7777]

Thank You.

[most wanted]

Pardon me for asking, but does this work for arcane spells also, because one guy at my server keeps telling that this fix was only for holy spells...

[Seizer]

Pardon me for asking, but does this work for arcane spells also, because one guy at my server keeps telling that this fix was only for holy spells...

Line 6282 Unit.cpp : case SPELL_SCHOOL_ARCANE: trigger_spell_id = 54373; break;

[insane1]

there also missing Nether Protection for the shadow school

case SPELL_SCHOOL_SHADOW: trigger_spell_id = 54374; break;

[Seizer]

Cmon, look throught the file before saying something is missing and atleast update your mangos rev. Shadow is not missing, arcane is not missing..

[alexluana]

no really look at

http://github.com/mangos/mangos/commit/1db6577964d62a66c2510b44fa0e6870e2511539

there is no shadow and arcane specified...

With respect,

Axel

[Seizer]

Look in _the source_ not the git commit.

They are all there, just don't show up in git commit since it only shows a few lines of unmodified code.

[Kotake]

I've noticed that Nether protection doesn't proc from physical attacks that have a magical effect like Seal of command, Frost strike, etc.

[Morphau]

Up please

Have a good way for fix it ?

[VladimirMangos]

I not see anyway any referecnes that it must triggred at weapon hits with additional magic effect.

[Kotake]

It proces from Rogues when they use venoms in their arms or that's a bug?