[Feature][7701-7703] support ACHIEVEMENT_CRITERIA_TYPE_HEALING_DONE and _DAMAGE_DONE

[Trazom]

What features does the patch add?

support ACHIEVEMENT_CRITERIA_TYPE_HEALING_DONE, ACHIEVEMENT_CRITERIA_TYPE_DAMAGE_DONE

and related criteria : ACHIEVEMENT_CRITERIA_TYPE_HIGHEST_HEAL_CASTED, ACHIEVEMENT_CRITERIA_TYPE_HIGHEST_HEALING_RECEIVED, ACHIEVEMENT_CRITERIA_TYPE_TOTAL_HEALING_RECEIVED, ACHIEVEMENT_CRITERIA_TYPE_HIGHEST_HIT_DEALT, ACHIEVEMENT_CRITERIA_TYPE_HIGHEST_HIT_RECEIVED, ACHIEVEMENT_CRITERIA_TYPE_TOTAL_DAMAGE_RECEIVED

For which repository revision was the patch created?

master [7701]

Is there a thread in the bug report section or at lighthouse?

None I know

Who has been writing this patch?

Myself

I have also made some refactoring to gather all healing done in one function (just like DealDamage for damage)

http://paste2.org/p/189103

Revision 2: rebase on 7701 with new DealHeal function

http://paste2.org/p/189923

[VladimirMangos]

DealHeal function added in [7701]. Thank you Other code will be reviewed later. If you update patch this will be helpful.

[Trazom]

gee! I thought this refactoring part of the patch would be hardly accepted :lol:

Patch updated to [7701].

[VladimirMangos]

Second part of criteria list in [7702]. Thank you

Note: i move ACHIEVEMENT_CRITERIA_TYPE_TOTAL_DAMAGE_RECEIVED under if (health <= damage) cases to avoid in death case accumulate overdamage

Update not req. I will review last part.

[added]

ACHIEVEMENT_CRITERIA_TYPE_DAMAGE_DONE (and heal case also) called incorrectly.

As i understand statistic case _must_ counted in any cases including for non-player damage/heal at BG

In your version non-player damage/heal in BG ignored. Player/non-player must be checked in to criteria, not at call.

I will update patch in described way.

[VladimirMangos]

Last part with described changes in [7703]. Thank you