[latest] More or less correct Sacrifice, Consume Shadows (maybe other) autocast fix

[Alex]

What does this patch do:

1. Fixes spells that must not be autocastable for pets, like Sacrifice. Maybe some others, do not know.

2. Also may fix the same for tamed/charmed creatures, but not sure because I do not know any spells that must be fixed.

3. Not autocastable spells are properly displayed in the client action bar: without yellow corner triangles. Autocast toggle is disabled by client too.

4. Does not allow load or otherwise add passive/not autocastable spells with ACT_DISABLED/ACT_ENABLED states, replaces by ACT_PASSIVE

List of pet spells that are undergoing autocastable check (warlock pet spells selected by flags): http://pastebin.ca/1429765

List of pet spells that will not be autocastable is here (selected by new flag found): http://pastebin.ca/1429767

These lists are auto-generated based on flag used.

What revision is it for: tested on [7940]

Some background information:

There is two warlock pet spells known to me that are not autocastable: Sacrifice and Consume Shadows (both are Voidwalker spells). Analyzing a set of spells from spell.dbc I have found a flag that is common for these spells and absent from another warlock pet spells. It is flag 17 (20000h) in AttributesEx. Combined with spell family and family flags, it yields excellent results.

The check function IsPetAutoCastableSpell may be easily extended to disable autocast for more pet spells in the same way.

Short about chages:

1. Constant SPELL_ATTR_EX_UNK17 is renamed SPELL_ATTR_EX_PET_NOT_AUTOCASTABLE

2. Function IsPetAutoCastableSpell(uint32 spellId) is added to SpellMgr.cpp

3. Added family selection masks SPELLFAMILYFLAG_WARLOCK_PET_SPELLS and SPELLFAMILYFLAG_WARLOCK_PET_SPELLS2 to SpellMgr.h

4. Checks in Pet.cpp are fixed to set not autocastable spells type to ACT_PASSIVE, it is the correct value to send to client to disable these 'corners' and autocast toggle feature

5. The same is done in Unit.cpp

Patch (version 4):

Get the patch code here: http://pastebin.ca/1444524

[Alex]

Update:

4. Does not allow load or otherwise add passive/not autocastable spells with ACT_DISABLED/ACT_ENABLED states, replaces by ACT_PASSIVE

Get it from http://pastebin.ca/1428750

First post updated, too.

[Alex]

It is running on LAN server and have no complaints by now.

I am working at narrowing spell list, though I don't know if it is really needed.

[cyrex]

got this problem:

/home/cyrex/warlock.patch:10: trailing whitespace.

newspell.active = IsPetAutoCastableSpell(spell_id) ? ACT_DISABLED : ACT_PASSIVE;

/home/cyrex/warlock.patch:14: trailing whitespace.

{

/home/cyrex/warlock.patch:15: trailing whitespace.

if (((active != ACT_DISABLED) && (active != ACT_ENABLED)) ||

/home/cyrex/warlock.patch:16: trailing whitespace.

IsPetAutoCastableSpell(spell_id))

/home/cyrex/warlock.patch:17: trailing whitespace.

newspell.active = active;

error: patch failed: src/game/Pet.cpp:1339

error: src/game/Pet.cpp: patch does not apply

error: patch failed: src/game/SharedDefines.h:259

error: src/game/SharedDefines.h: patch does not apply

error: patch failed: src/game/SpellMgr.cpp:98

error: src/game/SpellMgr.cpp: patch does not apply

error: patch failed: src/game/SpellMgr.h:148

error: src/game/SpellMgr.h: patch does not apply

error: patch failed: src/game/Unit.cpp:10385

error: src/game/Unit.cpp: patch does not apply

[Alex]

I found a mechanism to properly detect warlock pet spells, currently analyzing what I have, then will update patch with a correct method of detecting all warlock spells and selecting (not-)autocastable from them.

The patch is semantically correct, it may be applied even now. Only the IsPetAutoCastableSpell will be changing from now on.

2cyrex: what software are you using to apply the patch?

[Alex]

Update

Latest (and probably last) version of the patch. More correctly select spells for autocast flag check using family ID.

List of pet spells that are undergoing autocastable check (warlock pet spells selected by flags): http://pastebin.ca/1429765

List of pet spells that will not be autocastable is here (selected by new flag found): http://pastebin.ca/1429767

These lists are auto-generated based on flags used.

The check function IsPetAutoCastableSpell may be easily extended to disable autocast for more pet spells in the same way.

Overall changes list:

1. Constant SPELL_ATTR_EX_UNK17 is renamed SPELL_ATTR_EX_PET_NOT_AUTOCASTABLE

2. Function IsPetAutoCastableSpell(uint32 spellId) is added to SpellMgr.cpp

3. Added family selection masks SPELLFAMILYFLAG_WARLOCK_PET_SPELLS and SPELLFAMILYFLAG_WARLOCK_PET_SPELLS2 to SpellMgr.h

4. Checks in Pet.cpp are fixed to set not autocastable spells type to ACT_PASSIVE, it is the correct value to send to client to disable these 'corners' and autocast toggle feature

5. The same is done in Unit.cpp

Get the patch code here: http://pastebin.ca/1429788

First post also updated.

The patch is ready and will be updated only if some error is found.

[cyrex]

Am using git apply

Edit: I go to pastebin, click on dowload raw, download the raw version and use git apply to apply it. Anything wrong here i should know about?

[Alex]

I use GNU patch to apply, but create patches using GIT.

Tried GIT apply with the latest one. Works ok. If it's not the case for you, well... maybe our GIT versions are mismatched or pastebin is fiddling with the patch somehow.

[DasBlub]

don't download the patch, just copy the text into a file, else you could run into troubles with the newline encoding (windows CR LF (13 10) vs. linux LF (10))

[cyrex]

don't download the patch, just copy the text into a file, else you could run into troubles with the newline encoding (windows CR LF (13 10) vs. linux LF (10))

Am guessing this is it. Let me test it out right now.

[cyrex]

Bingo that was the problem. If i download the patch it gives the errors BUT if i copy it it works perfectly. Thanks a bunch guys.:lol:

[ApoC]

Patch looks ok, but what about Hunter's pets. Is'n there also similar rule?

(I never played Hunter, only asking )

[Alex]

If it is, it can be easily added. Can anyone post some information on that?

[biena]

pastebin links expired.

[Taur]

Alex, I think this patch needs to be revisioned due to the new changes in the pet action bar code made by vladimir.

[Alex]

Core changes do not touch most of the code this patch touches. I'm updating the patch now, and cleaning it up a bit (coding style).

Will post updated patch after testing.

[Alex]

Patch version 4

1. Updated for [7940], cleaned up code a bit.

2. No functional changes.

http://pastebin.ca/1444524

First post also updated.

[hunuza]

Anybody knows whether http://www.wowhead.com/?spell=53478 is auto-castable?

If so that flag probably fits.

That flag might also be used by mobs that mind control players whether to use that spell or not.

I don't think that SpellFamily checks are necessary though.

[Alex]

Spell family checks eliminate probability of errors, so they seem fit.

[Alex]

Erm... this patch may be accepted in its current form, can someone review it more deeply?

[Taur]

Seems to work fine, and it's not hacky, so i hope someone can review this. Thanks for the great work Alex

[ApoC]

Any news about Hunter's pet similars spells?

[cyrex]

Compile fine. Only tested what is said in the first post and it works oki.

[Taur]

Any news about Hunter's pet similars spells?

Yes, please someone that plays hunter tell us how it works, i never played it myself so i can't help here

Do hunter pets have non-autocastable spells that can be autocasted though?

[ChanF07]

Not too sure about source (http://forums.worldofwarcraft.com/thread.html?topicId=17367606461&sid=1) but

For my soloing turtle I have -

Growl, Shell Shield, Last Stand, Cower. Bite on auto in pet book.

Which would indicate indeed last stand is autocastable.