[LameFix] Magma Totems and Aggro

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

It disables generating aggro for Magma Totems.

For which repository revision was the patch created?

8078

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/viewtopic.php?id=8450

Who has been writing this patch? Please include either forum user names or email addresses.

Me. [email protected]

[HIGHLIGHT=diff]diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp

index 697367c..489340b 100644

--- a/src/game/Unit.cpp

+++ b/src/game/Unit.cpp

@@ -9558,8 +9558,13 @@ float Unit::ApplyTotalThreatModifier(float threat, SpellSchoolMask schoolMask)

void Unit::AddThreat(Unit* pVictim, float threat, SpellSchoolMask schoolMask, SpellEntry const *threatSpell)

{

// Only mobs can manage threat lists

- if(CanHaveThreatList())

+ if (CanHaveThreatList())

+ {

+ uint32 entry = pVictim->GetEntry();

+ if (entry == 5929 || entry == 7464 || entry == 7465 || entry == 7466 || entry == 15484 || entry == 31166 || entry == 31167)

+ return; // Don't add threat if aggroer is a Magma Totem

m_ThreatManager.addThreat(pVictim, threat, schoolMask, threatSpell);

+ }

}

//======================================================================[/HIGHLIGHT]

The way I wrote it is lame, I know, but it works. Do you have enums/masks for Magma Totems maybe?

@Ungaminga: I said, in this form it is lame, I am looking forward to be corrected.

[Ungaminga]

(entry == 5929 || entry == 7464 || entry == 7465 || entry == 7466 || entry == 15484 || entry == 31166 || entry == 31167)

Why not mask/icon/ swich construction/etc?

Dumn, i'm pritty stupid. Maybe some other ways kinda spellmods?

[SeTm]

Maybe should put 0 threat for totem spells in spell_threat table?

[Dagguh]

Maybe should put 0 threat for totem spells in spell_threat table?

Tested in the first place, didn't work.