[8132] Slam damage does not show in combat log

[Lynx3d]

MaNGOS 0.14, rev. 8132

UDB 381

SD2 rev. 1203

Damage done by Warrior's Slam ability (spell 1464 and ranks) does not show in combat log.

First i thought Slam does not do anything at all, but it does deal damage, i just have no clue how much, seems rather low though for the 2-h weapons i tried.

[pelle]

i can confirm on last revision

[darkstalker]

recent commit [9281] attempted to fix this, but doesnt work properly, you get the damage applied 1.5s after the spell lands (starts another cast when it lands)

[VladimirMangos]

Must be fixed in [9285]for this and similar cases when triggered spell copy master spells data for client use that redundent and wrong for server side.

[darkstalker]

there are other spell with similar problem like 60192 that triggers 60202 (Freezing Arrow), the triggered fails because of category cooldown, probably could use IsTriggeredSpellWithRedundentData() for cooldown check too

[Gommes]

and what about the fact that it still reset swing timer

[darkstalker]

spell now have double rage cost (from casted spell + triggered), so consumes 30 rage and fails to cast when you have less than that.

this fixes that:

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index 4ffdcff..ef101e0 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -5280,6 +5280,10 @@ int32 Spell::CalculatePowerCost()
    if (m_CastItem)
        return 0;

+    // triggered spell with power cost only usable for client
+    if (IsTriggeredSpellWithRedundentData())
+        return 0;
+
    // Spell drain all exist power on cast (Only paladin lay of Hands)
    if (m_spellInfo->AttributesEx & SPELL_ATTR_EX_DRAIN_ALL_POWER)
    {