[fix][8317] Exorcism

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

Exorcism cannot be casted on players and must be always critical hit when casted on a demon or undead target.

For which repository revision was the patch created?

8165

Who has been writing this patch?

Me

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

Something like http://getmangos.eu/community/viewtopic.php?id=8710

Link

[nos4r2zod]

Instead of having the first check in CheckCast, why not

@@ -5378,12 +5378,13 @@ bool Spell::IsAffectedByAura(Aura *aura)

bool Spell::CheckTargetCreatureType(Unit* target) const
{
    uint32 spellCreatureTargetMask = m_spellInfo->TargetCreatureType;

-    // Curse of Doom : not find another way to fix spell target check 
-    if(m_spellInfo->SpellFamilyName==SPELLFAMILY_WARLOCK && m_spellInfo->SpellFamilyFlags == UI64LIT(0x0200000000))
+    // Curse of Doom / Exorcism : not find another way to fix spell target check 
+    if((m_spellInfo->SpellFamilyName==SPELLFAMILY_WARLOCK || m_spellInfo->SpellFamilyName==SPELLFAMILY_PALADIN)
+        && m_spellInfo->SpellFamilyFlags == UI64LIT(0x0200000000))
    {
        // not allow cast at player
        if(target->GetTypeId()==TYPEID_PLAYER)
            return false;

It's a nice coincidence that Curse of Doom and Exorcism have the same SpellFamilyFlags

[[D4RK]Doom-Lord]

Fix suggested before by KAPATEJIb in Russian Mangos Forum.

Link

[Mondo01]

anyone test this?

[VladimirMangos]

Rewrited patch added in to [8317] base at version listed in KAPATEJIb thread in Russian Mangos Forum.

Anyway thanks for patch versions and comments.

It's a nice coincidence that Curse of Doom and Exorcism have the same SpellFamilyFlags

And include so not nice one more unrelated spell. I replace using spellmasks by category checks.