[Patch][8446] Fix for Achievement criteria 'Fall Without Diying'

[Opterman]

What bug does the patch fix? What features does the patch add?

It corrrect update of this criteria type with spells like Spirit of Redemption.

For which repository revision was the patch created?

8442

Who has been writing this patch? Please include either forum user names or email addresses.

Me

This is the fix:

From d480a5cbfbb3ba6d402b336e47a9b809d405766b Mon Sep 17 00:00:00 2001
From: unknown <Administrator@.(none)>
Date: Mon, 31 Aug 2009 05:08:55 -0700
Subject: [PATCH] Criteria Fall Without Dying

---
src/game/Player.cpp |    3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/game/Player.cpp b/src/game/Player.cpp
index 5e52b87..8e86e7c 100644
--- a/src/game/Player.cpp
+++ b/src/game/Player.cpp
@@ -19886,10 +19886,11 @@ void Player::HandleFall(MovementInfo const& movementInfo)
                if (GetDummyAura(43621))
                    damage = GetMaxHealth()/2;

+                uint32 Health = GetHealth();
                EnvironmentalDamage(DAMAGE_FALL, damage);

                // recheck alive, might have died of EnvironmentalDamage
-                if (isAlive())
+                if (isAlive() && damage < Health)
                    GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_FALL_WITHOUT_DYING, uint32(z_diff*100));
            }

-- 
1.6.2.msysgit.0.186.gf7512

This patch avoid to update criteria fall without diying if you die but you have auras like Spirit of Redemption or DK Ghoul..

Greetings, Opterman

[Patman128]

// recheck alive, might have died of EnvironmentalDamage
if (isAlive() && (damage < Health))                     
GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_FALL_WITHOUT_DYING, uint32(z_diff*100));

Cleaned that for you.

[Opterman]

// recheck alive, might have died of EnvironmentalDamage
if (isAlive() && (damage < Health))                     
GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_FALL_WITHOUT_DYING, uint32(z_diff*100));

Cleaned that for you.

Ok, thanks , its already updated

[VladimirMangos]

In [8446]. Thank you

But i change to use _final_ damage.