[fix][9018] Faerie Fire (Feral) - Threat & Damage

[Auntie Mangos]

What bug does the patch fix?

Adding Faerie Fire (Feral) - Threat & Damage as triggered Spell to the original cast. Limiting it to Bear Forms.

For which repository revision was the patch created?

master @ b9d2db3a3737ec795b34fb755851c0c65afd5999

Is there a thread in the bug report section or at lighthouse?

http://getmangos.eu/community/viewtopic.php?id=7836

Who has been writing this patch?

Sarjuuk

Patch

[Download]

diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp
index a71d259..a1e7c44 100644
--- a/src/game/Spell.cpp
+++ b/src/game/Spell.cpp
@@ -2522,6 +2522,13 @@ void Spell::cast(bool skipCheck)
            }
            break;
        }
+        case SPELLFAMILY_DRUID:
+        {
+            // Faerie Fire (Feral) [Armor-Debuff]
+            if (m_spellInfo->Id == 16857 && m_caster->m_form != FORM_CAT)
+                AddTriggeredSpell(60089);                   // Faerie Fire (Feral) [Damage + Threat]
+            break;
+        }
        case SPELLFAMILY_ROGUE:
            // Fan of Knives (main hand)
            if (m_spellInfo->Id == 51723 && m_caster->GetTypeId() == TYPEID_PLAYER &&

[thenecromancer]

Stance data is correct, so you probably should just check if player has fiting shapeshift form for 60089 requirements.

Whie it'll take more lines of code, it might be useful when ability is updated. (but then again it might be just useless bloating of codebase)

[Sarjuuk]

hmmm, right..

i could throw "&& (m_caster->m_form == FORM_BEAR || m_caster->m_form == FORM_DIREBEAR)" out.

but wouldn't this cause ugly errors in the combat log, if used as Cat?

eg: "Failed to cast Faerie Fire (Feral) (Must be in $stance)"

[Sarjuuk]

updated to current revision in first post...

/e: updated without bumping

[VladimirMangos]

In [9018]. Thank you