[8560] Guild loading speedup

[Auntie Mangos]

On load

2009-09-29 23:11:50 Loading Guilds...
2009-09-29 23:11:50 ERROR:Player (GUID: 46567) has broken zone-data
2009-09-29 23:11:50 ERROR:Player (GUID: 31276) has broken zone-data
2009-09-29 23:11:50 ERROR:Player (GUID: 31795) has broken zone-data
2009-09-29 23:11:50 ERROR:Player (GUID: 4380) has broken zone-data
2009-09-29 23:11:50 ERROR:Player (GUID: 33051) has broken zone-data
2009-09-29 23:11:50 ERROR:Player (GUID: 43526) has broken zone-data
2009-09-29 23:11:50 ERROR:Player (GUID: 34059) has broken zone-data
2009-09-29 23:11:50 ERROR:Player (GUID: 30750) has broken zone-data
2009-09-29 23:11:50 ERROR:Player (GUID: 46794) has broken zone-data
2009-09-29 23:11:50 ERROR:Player (GUID: 22740) has broken zone-data
2009-09-29 23:11:50 ERROR:Player (GUID: 47269) has broken zone-data
2009-09-29 23:11:50 ERROR:Player (GUID: 51741) has broken zone-data
2009-09-29 23:11:50 ERROR:Player (GUID: 53894) has broken zone-data
2009-09-29 23:11:50 ERROR:Player (GUID: 33504) has broken zone-data
2009-09-29 23:11:50 ERROR:Player (GUID: 45085) has broken zone-data

These players stay near flight master in Dalaran (it's a bugged duel area - players location shown as Unknown)

Program terminated with signal 11, Segmentation fault.
#0  0x08492cbd in Guild::LoadBankRightsFromDB (this=0xec71338,
   guildBankTabRightsResult=0xd799350)
       at ../../../src/game/../shared/Database/Field.h:54
       54              uint32 GetUInt32() const { return mValue ? static_cast<uint32>(a   tol(mValue)) : uint32(0); }
       (gdb) bt
       #0  0x08492cbd in Guild::LoadBankRightsFromDB (this=0xec71338,
           guildBankTabRightsResult=0xd799350)
               at ../../../src/game/../shared/Database/Field.h:54
               #1  0x082a6d3f in ObjectMgr::LoadGuilds (this=0x90c0cf8)
                   at ../../../src/game/ObjectMgr.cpp:2910
                   #2  0x0842f7ca in World::SetInitialWorldSettings (this=0x90bfc38)
                       at ../../../src/game/World.cpp:1398
                       #3  0x0813394d in Master::Run (this=0x90965d0)
                           at ../../../src/mangosd/Master.cpp:221
                           #4  0x08133293 in main (argc=1, argv=0xbfb5a204)
                               at ../../../src/mangosd/Main.cpp:172

more info at http://getmangos.eu/community/viewtopic.php?id=10209

[Triplex]

Hi,

i recently optimized guild loading. But there was always problem that mangos run few querries for each guild and it caused slow startup.

So i got an idea, to load all guilds data from database in 4 selects.

And then guilds were loaded 2 seconds later, after those 4 querries were executed.

Patch is tested, it doesn't change almost anything so it should work without problems.

Please test it and report here..

[therapist]

Tested Works good

I like the better idea on a way to load it

[Triplex]

Implemented also arena_team loading speedup

patch is available in:

http://paste2.org/p/435312

patch is tested and it will be committed soon, any bug reports are welcome.

[Triplex]

commited in [8560].

[Triplex]

fixed in [8565], thx for report. That log errors are correct, and they doesn't cause any problems - players with bad zone data are added to guild as members, only error message is shown, you can disable that message by commenting it... ;-)