[patch] [8648] Aura 281

[qsa]

What bug does the patch fix? What features does the patch add?

Implementing aura 281 SPELL_AURA_MOD_HONOR_GAIN

id    spellname_0
58553    Honorable
58554    Lok-Regar
58555    Great Honor
58556    Greater Honor
58557    Greatest Honor
58558    Lok-Narash!
58559    Lok'tar
58560    Lok'tar ogar!

For which repository revision was the patch created?

8542

Who has been writing this patch? Please include either forum user names or email addresses.

Me

diff --git a/src/game/Player.cpp b/src/game/Player.cpp
index 63f6a34..0b94ec5 100644
--- a/src/game/Player.cpp
+++ b/src/game/Player.cpp
@@ -6071,6 +6071,7 @@ bool Player::RewardHonor(Unit *uVictim, uint32 groupsize, float honor)
    if (uVictim != NULL)
    {
        honor *= sWorld.getRate(RATE_HONOR);
+        honor *= (GetMaxPositiveAuraModifier(SPELL_AURA_MOD_HONOR_GAIN) + 100.0f)/100.0f;

        if(groupsize > 1)
            honor /= groupsize;
diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index ff6d791..4716ebb 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -331,7 +331,7 @@ pAuraHandler AuraHandler[TOTAL_AURAS]=
    &Aura::HandleNULL,                                      //278 SPELL_AURA_MOD_DISARM_RANGED disarm ranged weapon
    &Aura::HandleNULL,                                      //279 visual effects? 58836 and 57507
    &Aura::HandleModTargetArmorPct,                         //280 SPELL_AURA_MOD_TARGET_ARMOR_PCT
-    &Aura::HandleNULL,                                      //281 SPELL_AURA_MOD_HONOR_GAIN
+    &Aura::HandleNoImmediateEffect,                         //281 SPELL_AURA_MOD_HONOR_GAIN             implemented in Player::RewardHonor
    &Aura::HandleAuraIncreaseBaseHealthPercent,             //282 SPELL_AURA_INCREASE_BASE_HEALTH_PERCENT
    &Aura::HandleNoImmediateEffect,                         //283 SPELL_AURA_MOD_HEALING_RECEIVED       implemented in Unit::SpellHealingBonus
    &Aura::HandleUnused,                                    //284 not used by any spells (3.08a)

[cyrex]

Kung Fu Bump!:eek:

[Lynx3d]

Are you Chuck Norris? You just roundhouse-bumped the forum :blink:

[The_Game_Master]

I think it's rather funny.

[Eliu]

Are you Chuck Norris? You just roundhouse-bumped the forum :blink:

no hes not chuck norris, as you stated chuck norris roundhouse kicks stuff and punches with the fist under his beard, cyrex is just kung fu bumping maybe hes a drunk kung fu panda? (more epic cause of the pandarens in warcraft )

[cyrex]

I only train with the best!

[VladimirMangos]

In [8648]. Thank you.

As i understand rank req. for new continnent outdoor battle must be checked in BG code.

[qsa]

In [8648]. Thank you.

As i understand rank req. for new continnent outdoor battle must be checked in BG code.

While it is true this aura used only in BG related spells for now, I don't think it is has anything to do with this specific aura. We don't have this BG implemented by default ( yet ), so dealing with casting those spells used ( when opposite faction have numeric advantage), is irrelevant.

For now, on default mangos, it is to "fill the blanks" in aura implementations.

Thanks for reviewing.

[VladimirMangos]

I make BG note only to remark that honor rank referecned inl description of some from spels not part of spell functionality and must be checked wher spell will be casted (in script or any)